* [PATCH] uapi/drm/i915_drm.h: fix userspace compilation.
@ 2015-09-02 11:41 Artem Savkov
2015-09-02 11:52 ` Ville Syrjälä
0 siblings, 1 reply; 4+ messages in thread
From: Artem Savkov @ 2015-09-02 11:41 UTC (permalink / raw)
To: daniel.vetter; +Cc: intel-gfx, Artem Savkov
Patch "drm/i915: Use expcitly fixed type in compat32 structs" changed the type
of param field in drm_i915_getparam from int to s32. This header is exported to
userspace and needs to use userspace type __s32 instead.
This fixes userspace compilation errors like the following:
include/drm/i915_drm.h:361:2: error: unknown type name 's32'
s32 param;
Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
include/uapi/drm/i915_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index dbd16a2..fd5aa47 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -358,7 +358,7 @@ typedef struct drm_i915_irq_wait {
#define I915_PARAM_HAS_RESOURCE_STREAMER 36
typedef struct drm_i915_getparam {
- s32 param;
+ __s32 param;
/*
* WARNING: Using pointers instead of fixed-size u64 means we need to write
* compat32 code. Don't repeat this mistake.
--
2.1.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] uapi/drm/i915_drm.h: fix userspace compilation.
2015-09-02 11:41 [PATCH] uapi/drm/i915_drm.h: fix userspace compilation Artem Savkov
@ 2015-09-02 11:52 ` Ville Syrjälä
2015-09-02 12:20 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2015-09-02 11:52 UTC (permalink / raw)
To: Artem Savkov; +Cc: daniel.vetter, intel-gfx
On Wed, Sep 02, 2015 at 01:41:18PM +0200, Artem Savkov wrote:
> Patch "drm/i915: Use expcitly fixed type in compat32 structs" changed the type
> of param field in drm_i915_getparam from int to s32. This header is exported to
> userspace and needs to use userspace type __s32 instead.
>
> This fixes userspace compilation errors like the following:
> include/drm/i915_drm.h:361:2: error: unknown type name 's32'
> s32 param;
>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
> ---
> include/uapi/drm/i915_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> index dbd16a2..fd5aa47 100644
> --- a/include/uapi/drm/i915_drm.h
> +++ b/include/uapi/drm/i915_drm.h
> @@ -358,7 +358,7 @@ typedef struct drm_i915_irq_wait {
> #define I915_PARAM_HAS_RESOURCE_STREAMER 36
>
> typedef struct drm_i915_getparam {
> - s32 param;
> + __s32 param;
Hmm. I don't understand why this one in particular got changed to s32
when there are other ioctl structs still using int.
> /*
> * WARNING: Using pointers instead of fixed-size u64 means we need to write
> * compat32 code. Don't repeat this mistake.
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] uapi/drm/i915_drm.h: fix userspace compilation.
2015-09-02 11:52 ` Ville Syrjälä
@ 2015-09-02 12:20 ` Daniel Vetter
2015-09-02 13:30 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2015-09-02 12:20 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: daniel.vetter, Artem Savkov, intel-gfx
On Wed, Sep 02, 2015 at 02:52:19PM +0300, Ville Syrjälä wrote:
> On Wed, Sep 02, 2015 at 01:41:18PM +0200, Artem Savkov wrote:
> > Patch "drm/i915: Use expcitly fixed type in compat32 structs" changed the type
> > of param field in drm_i915_getparam from int to s32. This header is exported to
> > userspace and needs to use userspace type __s32 instead.
> >
> > This fixes userspace compilation errors like the following:
> > include/drm/i915_drm.h:361:2: error: unknown type name 's32'
> > s32 param;
> >
> > Signed-off-by: Artem Savkov <asavkov@redhat.com>
> > ---
> > include/uapi/drm/i915_drm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> > index dbd16a2..fd5aa47 100644
> > --- a/include/uapi/drm/i915_drm.h
> > +++ b/include/uapi/drm/i915_drm.h
> > @@ -358,7 +358,7 @@ typedef struct drm_i915_irq_wait {
> > #define I915_PARAM_HAS_RESOURCE_STREAMER 36
> >
> > typedef struct drm_i915_getparam {
> > - s32 param;
> > + __s32 param;
>
> Hmm. I don't understand why this one in particular got changed to s32
> when there are other ioctl structs still using int.
Mostly me being incompetent.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> on this one, not that
it seems to be worth much ...
-Daniel
>
> > /*
> > * WARNING: Using pointers instead of fixed-size u64 means we need to write
> > * compat32 code. Don't repeat this mistake.
> > --
> > 2.1.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] uapi/drm/i915_drm.h: fix userspace compilation.
2015-09-02 12:20 ` Daniel Vetter
@ 2015-09-02 13:30 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2015-09-02 13:30 UTC (permalink / raw)
To: Daniel Vetter, Ville Syrjälä
Cc: daniel.vetter, Artem Savkov, intel-gfx
On Wed, 02 Sep 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Sep 02, 2015 at 02:52:19PM +0300, Ville Syrjälä wrote:
>> On Wed, Sep 02, 2015 at 01:41:18PM +0200, Artem Savkov wrote:
>> > Patch "drm/i915: Use expcitly fixed type in compat32 structs" changed the type
>> > of param field in drm_i915_getparam from int to s32. This header is exported to
>> > userspace and needs to use userspace type __s32 instead.
>> >
>> > This fixes userspace compilation errors like the following:
>> > include/drm/i915_drm.h:361:2: error: unknown type name 's32'
>> > s32 param;
>> >
>> > Signed-off-by: Artem Savkov <asavkov@redhat.com>
>> > ---
>> > include/uapi/drm/i915_drm.h | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
>> > index dbd16a2..fd5aa47 100644
>> > --- a/include/uapi/drm/i915_drm.h
>> > +++ b/include/uapi/drm/i915_drm.h
>> > @@ -358,7 +358,7 @@ typedef struct drm_i915_irq_wait {
>> > #define I915_PARAM_HAS_RESOURCE_STREAMER 36
>> >
>> > typedef struct drm_i915_getparam {
>> > - s32 param;
>> > + __s32 param;
>>
>> Hmm. I don't understand why this one in particular got changed to s32
>> when there are other ioctl structs still using int.
>
> Mostly me being incompetent.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> on this one, not that
> it seems to be worth much ...
Pushed to drm-intel-next-fixes, thanks for the patch and review.
BR,
Jani.
> -Daniel
>
>>
>> > /*
>> > * WARNING: Using pointers instead of fixed-size u64 means we need to write
>> > * compat32 code. Don't repeat this mistake.
>> > --
>> > 2.1.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Ville Syrjälä
>> Intel OTC
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-02 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02 11:41 [PATCH] uapi/drm/i915_drm.h: fix userspace compilation Artem Savkov
2015-09-02 11:52 ` Ville Syrjälä
2015-09-02 12:20 ` Daniel Vetter
2015-09-02 13:30 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox