From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH 1/3] drm/i915: Fix command parser to validate multiple register access with the same command. Date: Mon, 15 Jun 2015 14:18:01 +0300 Message-ID: <87d20xkyom.fsf@riseup.net> References: <1432907055-8268-1-git-send-email-currojerez@riseup.net> <000901d09d17$99c5f380$cd51da80$@linux.intel.com> <20150615103559.GX8341@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1155513634==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTP id C162C6E74C for ; Mon, 15 Jun 2015 04:18:20 -0700 (PDT) In-Reply-To: <20150615103559.GX8341@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Zhigang Gong Cc: 'Brad Volkin' , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1155513634== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Tue, Jun 02, 2015 at 05:36:26PM +0800, Zhigang Gong wrote: >> The patchset LGTM and works well with beignet. The 80%+ performance regr= ession issue in darktable also has been fixed >> after this patchset applied and enable the atomic in L3 at beignet side.= So, >>=20 >> Reviewed-by: Zhigang Gong > > All three merged. Thanks Daniel. > Aside: Dont we need an increment for the cmd parser version for > userspace to be able to detect this? > Yeah, that would be a good idea, patch attached. > And please follow up with a link to the beignet patches used to validate > these kernel patches for references. > Zhigang, do you have a link to your Beignet patch? > Thanks, Daniel > >>=20 >> Thanks, >> Zhigang Gong. >>=20 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-drm-i915-Bump-command-parser-version-number.patch Content-Transfer-Encoding: quoted-printable From=209f26beaf96473800252db35c4513933ae43e3c84 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Mon, 15 Jun 2015 14:03:29 +0300 Subject: [PATCH] drm/i915: Bump command parser version number. Signed-off-by: Francisco Jerez =2D-- drivers/gpu/drm/i915/i915_cmd_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/= i915_cmd_parser.c index 0146fe6..6722098 100644 =2D-- a/drivers/gpu/drm/i915/i915_cmd_parser.c +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c @@ -1219,6 +1219,7 @@ int i915_cmd_parser_get_version(void) * 2. Allow access to the MI_PREDICATE_SRC0 and * MI_PREDICATE_SRC1 registers. * 3. Allow access to the GPGPU_THREADS_DISPATCHED register. + * 4. L3 atomic chicken bits of HSW_SCRATCH1 and HSW_ROW_CHICKEN3. */ =2D return 3; + return 4; } =2D-=20 2.4.3 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlV+tGkACgkQg5k4nX1Sv1uU7AEAjC941h5GHoh9tzraBxv/TR5E GsCmDD6RHsajtcPPsroA/iBhAj79LEP0cD1D4TZXWZXUpFhJfL7sRzH39J8xQIAM =+lMX -----END PGP SIGNATURE----- --==-=-=-- --===============1155513634== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1155513634==--