From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] drm/i915: Make DRM_I915_WERROR depend on !COMPILE_TEST
Date: Mon, 25 May 2015 12:26:38 +0300 [thread overview]
Message-ID: <87d21pj9dd.fsf@intel.com> (raw)
In-Reply-To: <20150525073605.GA17761@nuc-i3427.alporthouse.com>
On Mon, 25 May 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sun, May 24, 2015 at 10:48:07AM +0100, Damien Lespiau wrote:
>> With allyesconfig/allmodconfig, kbuild enables all the options it can,
>> including DRM_I915_WERROR. That's not really what we want with -Werror,
>> and this was breaking the build for Andrew.
>>
>> Andrew suggested to use COMPILE_TEST as a way to 'detect' these
>> configurations.
>>
>> An alternative would be to inverse the condition of the option:
>> DRM_I915_NO_WERROR. Setting that one to Y would have no effect, at the
>> price of a bit of confusion.
>>
>> Another alternative would be to introduce a allyesmodconfig_n property
>> to config entries, like the allnoconfig_y one we have today:
>>
>> - "allnoconfig_y"
>> This declares the symbol as one that should have the value y when
>> using "allnoconfig". Used for symbols that hide other symbols.
>>
>> Of course, allyesmodconfig_n would set the value to n when using
>> "allmodconfig" or "allmodconfig". That alternative needs a bit more work
>> though and may not be desirable, given that even allnoconfig_y is used
>> only once today.
>>
>> Reported-by: Andrew Morton <akpm@linux-foundation.org>
>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> As a proxy, it seems reasonable.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Do you also have a patch for the broken code? :)
One of the things I looked at was the compiler being silly.
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-25 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 9:48 [PATCH] drm/i915: Make DRM_I915_WERROR depend on !COMPILE_TEST Damien Lespiau
2015-05-25 7:36 ` Chris Wilson
2015-05-25 9:26 ` Jani Nikula [this message]
2015-05-25 12:15 ` Chris Wilson
2015-05-25 12:31 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d21pj9dd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox