From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49E40C36010 for ; Tue, 1 Apr 2025 15:32:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 328D110E5E9; Tue, 1 Apr 2025 15:32:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="GMFYHBDm"; dkim-atps=neutral Received: from mslow3.mail.gandi.net (mslow3.mail.gandi.net [217.70.178.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38D9510E5E3; Tue, 1 Apr 2025 15:32:28 +0000 (UTC) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by mslow3.mail.gandi.net (Postfix) with ESMTP id 26CAE5814B4; Tue, 1 Apr 2025 15:00:47 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 921F5441C8; Tue, 1 Apr 2025 15:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1743519646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z6SUzGcMkPKel2Eccn/jYaKzkfn5nDr4VwnUJsYHcl0=; b=GMFYHBDmkQqPnwkmOAvUpfp7X/+LmL7dcjdsCjsTdJynnH4itkSn1hQxCz5+SCHo1uaclf DhgtZjY4wTeHh3eozM/vo5clyziidRAKCKFpzukdJ18oiayB6OHyD0IAd2+Luv1CSMp1gD zY/JN/ez/OxbyQY0KoB1rJxDH4cgB5kVBny+R9Xqxu+BqgxnjIxQ7QpvHp8Jrrz21EIWBv 8JOX6UARWLuysU9uR3cJezATqmPZbdx1VtrBi/dHC/aKYZWjiGqymqvGJBV9Qw7YGDO25i GAc2Rla0P/hRZ+f7DASVPsS87VlZylgntjN5l/aSlpNhYftOGqddTvQHiMmsfA== From: Miquel Raynal To: Alexander Usyskin Cc: Richard Weinberger , Vignesh Raghavendra , Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karthik Poosa , Reuven Abliyev , Oren Weil , linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 01/12] mtd: core: always create master device In-Reply-To: <20250326152623.3897204-2-alexander.usyskin@intel.com> (Alexander Usyskin's message of "Wed, 26 Mar 2025 17:26:12 +0200") References: <20250326152623.3897204-1-alexander.usyskin@intel.com> <20250326152623.3897204-2-alexander.usyskin@intel.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 01 Apr 2025 17:00:43 +0200 Message-ID: <87ecycrko4.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeeftdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepofhiqhhuvghlucftrgihnhgrlhcuoehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeffgefhjedtfeeigeduudekudejkedtiefhleelueeiueevheekvdeludehiedvfeenucfkphepledvrddukeegrdduuddtrdduleefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledvrddukeegrdduuddtrdduleefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvuddprhgtphhtthhopegrlhgvgigrnhguvghrrdhushihshhkihhnsehinhhtvghlrdgtohhmpdhrtghpthhtoheprhhitghhrghrugesnhhougdrrghtpdhrtghpthhtohepvhhighhnvghshhhrsehtihdrtghomhdprhgtphhtthhopehluhgtrghsrdguvghmrghrtghhihesihhnthgvlhdrtghomhdprhgtphhtthhopehthhhomhgrshdrhhgvlhhlshhtrhhomheslhhinhhugidrihhnthgvl hdrtghomhdprhgtphhtthhopehrohgurhhighhordhvihhvihesihhnthgvlhdrtghomhdprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhhohhrshhtsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepmhhrihhprghrugeskhgvrhhnvghlrdhorhhg X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hello Alexander, On 26/03/2025 at 17:26:12 +02, Alexander Usyskin wrote: > Create master device without partition when > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > This streamlines device tree and allows to anchor > runtime power management on master device in all cases. > > Signed-off-by: Alexander Usyskin I successfully tested it, this patch will be applied at -rc1 to the mtd/next tree. I was wondering, do you think it would be possible to keep the creation of mtd_master and make it a symbolic link to mtdx when MTD_PARTITIONED_MASTER=3Dy or when there is no partition? In short, always having mtd_masterx, because I fear at some point we'll have problems otherwise :-) Right now we have: - Without partition: mtd0 (mtd0ro mtdblock0) - With partition and MTD_PARTITIONED_MASTER=3Dn mtd0 (mtd0ro mtdblock0) mtd_master0 - With partition and MTD_PARTITIONED_MASTER=3Dy mtd0 (mtd0ro mtdblock0) [this is the master] mtd1 (mtd1ro mtdblock1) I am suggesting: - Without partition: mtd0 (mtd0ro mtdblock0) mtd_master0 -> link to mtd0 - With partition and MTD_PARTITIONED_MASTER=3Dn mtd0 (mtd0ro mtdblock0) mtd_master0 - With partition and MTD_PARTITIONED_MASTER=3Dy mtd0 (mtd0ro mtdblock0) [this is the master] mtd1 (mtd1ro mtdblock1) mtd_master0 -> link to mtd0 What do you think? Or maybe even always mtd_master in the first place. Richard, your point of view on this? Thanks, Miqu=C3=A8l