intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] drm: revert some framebuffer API tests
@ 2024-09-17 17:43 Jani Nikula
  2024-09-17 17:43 ` [PATCH 1/2] Revert "drm/tests: Add test for drm_framebuffer_free()" Jani Nikula
                   ` (5 more replies)
  0 siblings, 6 replies; 24+ messages in thread
From: Jani Nikula @ 2024-09-17 17:43 UTC (permalink / raw)
  To: dri-devel
  Cc: intel-gfx, jani.nikula, Carlos Eduardo Gallo Filho, Maxime Ripard,
	Maarten Lankhorst, Thomas Zimmermann, Jeff Johnson

The tests consistently trigger WARNs in drm_framebuffer code. I'm not
sure what the point is with type of belts and suspenders tests. The
warnings *are* the way to flag erroneous API usage.

Warnings in turn trigger failures in CI. Filtering the warnings are
error prone, and, crucially, would also filter actual errors in case the
kunit tests are not run.

I acknowledge there may be complex test cases where you'd end up
triggering warnings somewhere deep, but these are not it. These are
simple.

Revert the tests, back to the drawing board.

BR,
Jani.


Cc: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>


Jani Nikula (2):
  Revert "drm/tests: Add test for drm_framebuffer_free()"
  Revert "drm/tests: Add test for drm_framebuffer_init()"

 drivers/gpu/drm/drm_framebuffer.c            |   1 -
 drivers/gpu/drm/drm_mode_object.c            |   1 -
 drivers/gpu/drm/tests/drm_framebuffer_test.c | 134 -------------------
 3 files changed, 136 deletions(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2024-10-03 12:04 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-17 17:43 [PATCH 0/2] drm: revert some framebuffer API tests Jani Nikula
2024-09-17 17:43 ` [PATCH 1/2] Revert "drm/tests: Add test for drm_framebuffer_free()" Jani Nikula
2024-09-17 17:43 ` [PATCH 2/2] Revert "drm/tests: Add test for drm_framebuffer_init()" Jani Nikula
2024-09-17 19:01 ` ✗ Fi.CI.SPARSE: warning for drm: revert some framebuffer API tests Patchwork
2024-09-17 19:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-18  8:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-24 10:06 ` [PATCH 0/2] " Simona Vetter
2024-09-24 11:54   ` Maxime Ripard
2024-09-24 13:37     ` Guenter Roeck
2024-09-24 13:56       ` Maxime Ripard
2024-09-24 15:09         ` Guenter Roeck
2024-09-24 15:56           ` Jani Nikula
2024-09-24 16:35             ` Guenter Roeck
2024-09-24 16:57             ` Maxime Ripard
2024-09-24 17:37               ` Guenter Roeck
2024-09-25  9:41               ` Jani Nikula
2024-09-25 12:59                 ` Maxime Ripard
2024-09-25 15:57                   ` Guenter Roeck
2024-09-25 11:52           ` Simona Vetter
2024-09-25 13:05             ` Maxime Ripard
2024-09-25 16:04               ` Guenter Roeck
2024-09-26  7:05                 ` Maxime Ripard
2024-10-02 12:10               ` Jani Nikula
2024-10-03 12:04                 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).