From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D46C0CD13CF for ; Tue, 3 Sep 2024 12:13:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A3E210E555; Tue, 3 Sep 2024 12:13:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="HpJiuVR6"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id F40C910E555 for ; Tue, 3 Sep 2024 12:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725365620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lYL4yI1IqzmTa462iF0M0rcy8Y9bEoz/jvmUsF6QjPQ=; b=HpJiuVR6zvKxtITVDk0YYJVT10UMVxhpcbKY6qduuesa2XxtJu+pkit2ORRImmF4284Sal 21gOeMYWDqRVn8mPiFjQGV7W0AeBT9iCFoh/X/fUirsZinCmS+yvXs+ZEU90e3AseqQvIw SF4+l1xx2bcu0LfawTOOHLRuOHBLSLE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-Fj5xbNkUOleE4CGStjcpQA-1; Tue, 03 Sep 2024 08:13:37 -0400 X-MC-Unique: Fj5xbNkUOleE4CGStjcpQA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42c7aa6c13cso25318095e9.1 for ; Tue, 03 Sep 2024 05:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725365616; x=1725970416; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lYL4yI1IqzmTa462iF0M0rcy8Y9bEoz/jvmUsF6QjPQ=; b=Ut9nOavA3oI1d3mpbkqrUPYx8wXN7FlNik21Byj5uafdkea4qMh8Ki7jRqrb/NAyVY 2cPMj0o7udQEej4rYy3FsIXdPaZN7fWizHiXc2Y52uI0n9U7IZLRcTrHQjUbIhfaH8Ot PBrx48aI+QHlq+ut4fhSI7QQNiFK9DIYmwsGgoL9VKaqpKl5oJY6dvjll2OE2dXDxOvH qB5XJGuIri0Lv/qmcbiMMvWl2HxXk/cQyYtMuz0hfPW7AnyXplCBsyMWGcWVWj4q5IpQ xuonco66LIw069/hxVcRZv6dWx+E4dPtRt3olop17XzItqxmba2Duz657GCcKLP951hn PcLQ== X-Forwarded-Encrypted: i=1; AJvYcCXoUrhvFHRajBFqNv9WtZZAWXBxkcJxGd9K7zCMKyZNGsIM9kELn7l2Ag5nB/5d2OtTND2Qm7zpmxM=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yyq3AWJIWegjaNdLkhbYAEbV4AnK8PT29IXTut5RTG8cAFKcscA Mv4YclLN/dD2W5548yM20DEXWrpI+Z+ton7ru9mJQB6fhaQAUNqrgLX46b6i2l5yhVpISVkvU+Q jXduHQMqNsAZrKA4oYkfZiYFzEtc0ypGg/lekdcZm4Ea0pEjt7ewptnYScDHcOc5NDA== X-Received: by 2002:a05:600c:46c9:b0:42b:8a35:1acf with SMTP id 5b1f17b1804b1-42bbb436e9amr93420935e9.25.1725365615909; Tue, 03 Sep 2024 05:13:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKyGHamdOmgpgASh3pFqLFGqaTwSD2fibtBzdjqhIRmCcY1nScQMQjUyszdt7TYUTr28vP9g== X-Received: by 2002:a05:600c:46c9:b0:42b:8a35:1acf with SMTP id 5b1f17b1804b1-42bbb436e9amr93420625e9.25.1725365615408; Tue, 03 Sep 2024 05:13:35 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df9705sm168910015e9.27.2024.09.03.05.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 05:13:35 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann , Inki Dae , Seung-Woo Kim , Kyungmin Park Subject: Re: [PATCH v3 75/81] drm/exynos-drm: Run DRM default client setup In-Reply-To: <20240830084456.77630-76-tzimmermann@suse.de> References: <20240830084456.77630-1-tzimmermann@suse.de> <20240830084456.77630-76-tzimmermann@suse.de> Date: Tue, 03 Sep 2024 14:13:34 +0200 Message-ID: <87ed61c4up.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The exynos-drm driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 101 ++-------------------- > drivers/gpu/drm/exynos/exynos_drm_fbdev.h | 15 ++-- > 3 files changed, 19 insertions(+), 101 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index 7c59e1164a48..2a466d8179f4 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -15,6 +15,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -111,6 +112,7 @@ static const struct drm_driver exynos_drm_driver = { > .dumb_create = exynos_drm_gem_dumb_create, > .gem_prime_import = exynos_drm_gem_prime_import, > .gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table, > + EXYNOS_DRM_FBDEV_DRIVER_OPS, > .ioctls = exynos_ioctls, > .num_ioctls = ARRAY_SIZE(exynos_ioctls), > .fops = &exynos_drm_driver_fops, > @@ -288,7 +290,7 @@ static int exynos_drm_bind(struct device *dev) > if (ret < 0) > goto err_cleanup_poll; > > - exynos_drm_fbdev_setup(drm); > + drm_client_setup(drm, NULL); > > return 0; > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > index a379c8ca435a..73fa7b77d8d0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > @@ -22,9 +22,6 @@ > #include "exynos_drm_fb.h" > #include "exynos_drm_fbdev.h" > > -#define MAX_CONNECTOR 4 I see this constant was unused. Is an unrelated cleanup but I guess is OK too. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat