From: Jani Nikula <jani.nikula@intel.com>
To: "Ruhl, Michael J" <michael.j.ruhl@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 8/8] drm/print: introduce new struct drm_device based logging macros
Date: Thu, 10 Oct 2019 12:32:20 +0300 [thread overview]
Message-ID: <87eezlgd3v.fsf@intel.com> (raw)
In-Reply-To: <14063C7AD467DE4B82DEDB5C278E8663D9C2390F@FMSMSX108.amr.corp.intel.com>
On Wed, 09 Oct 2019, "Ruhl, Michael J" <michael.j.ruhl@intel.com> wrote:
>>-----Original Message-----
>>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>>Jani Nikula
>>+/* Helper for struct drm_device based logging. */
>>+#define __drm_printk(drm, level, type, fmt, ...) \
>>+ dev_##level##type(drm->dev, "[drm] " fmt, ##__VA_ARGS__)
>
> In the past, I have been able to do a:
>
> #undef pr_fmt
> #define pr_fmt(fmt) "[myinfo here] " fmt
>
> And have the "[myinfo here]" portion show up the output.
>
> Is it possible that you might be able to use this instead of "[drm] " fmt?
>
> I think that the this will be the same result, but might be more in
> line with the printk interface?
pr_fmt is only used by the pr_<level>() macros in printk.h that use
printk. This does not use printk.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-10 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:37 [PATCH 0/8] drm/print: cleanup and new drm_device based logging Jani Nikula
2019-10-09 15:37 ` [PATCH 1/8] drm/i915: use drm_debug_enabled() to check for debug categories Jani Nikula
2019-10-09 15:37 ` [PATCH 2/8] drm/nouveau: " Jani Nikula
2019-10-09 15:37 ` [PATCH 3/8] drm/amdgpu: " Jani Nikula
2019-10-09 15:37 ` [PATCH 4/8] drm/print: rename drm_debug to __drm_debug to discourage use Jani Nikula
2019-10-09 15:37 ` [PATCH 5/8] drm/print: underscore prefix functions that should be private to print Jani Nikula
2019-10-09 15:37 ` [PATCH 6/8] drm/print: convert debug category macros into an enum Jani Nikula
2019-10-09 15:37 ` [PATCH 7/8] drm/print: group logging functions by prink or device based Jani Nikula
2019-10-09 15:37 ` [PATCH 8/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-10-09 18:15 ` Ruhl, Michael J
2019-10-10 9:32 ` Jani Nikula [this message]
2019-10-09 16:47 ` ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging Patchwork
2019-10-09 17:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-09 23:55 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eezlgd3v.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michael.j.ruhl@intel.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).