From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers Date: Wed, 02 Oct 2019 13:11:06 +0300 Message-ID: <87eezvbgp1.fsf@intel.com> References: <8e697984-03b5-44f3-304e-42d303724eaa@rasmusvillemoes.dk> <20191001080739.18513-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191001080739.18513-1-jani.nikula@intel.com> Sender: netdev-owner@vger.kernel.org To: Rasmus Villemoes , linux-kernel@vger.kernel.org Cc: Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Vishal Kulkarni , netdev@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Andrew Morton , Julia Lawall List-Id: intel-gfx@lists.freedesktop.org On Tue, 01 Oct 2019, Jani Nikula wrote: > While the main goal here is to abstract recurring patterns, and slightly > clean up the code base by not open coding the ternary operators, there > are also some space savings to be had via better string constant > pooling. Make that """ While the main goal here is to abstract recurring patterns, and slightly clean up the code base by not open coding the ternary operators, using functions to access the strings also makes it easier to seek different implementation options for potential space savings on string constants in the future. """ to be more explicit that this change does not directly translate to any space savings. Rasmus, okay with that? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center