From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings. Date: Tue, 25 Jun 2019 12:48:22 +0300 Message-ID: <87ef3i572x.fsf@gaia.fi.intel.com> References: <20190625070829.25277-1-kenneth@whitecape.org> <20190625090655.19220-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190625090655.19220-1-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Kenneth Graunke , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Chris Wilson writes: > From: Kenneth Graunke > > The Demand Prefetch workaround (binding table prefetching) only applies > to Icelake A0/B0. But the Sampler Prefetch workaround needs to be > applied to all Gen11 steppings, according to a programming note in the > SARCHKMD documentation. > > Using the Intel Gallium driver, I have seen intermittent failures in > the dEQP-GLES31.functional.copy_image.non_compressed.* tests. After > applying this workaround, the tests reliably pass. > > v2: Remove the overlap with a pre-production w/a > > BSpec: 9663 > Signed-off-by: Kenneth Graunke > Signed-off-by: Chris Wilson > Cc: stable@vger.kernel.org Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index c70445adfb02..993804d09517 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -1252,8 +1252,12 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) > if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0)) > wa_write_or(wal, > GEN7_SARCHKMD, > - GEN7_DISABLE_DEMAND_PREFETCH | > - GEN7_DISABLE_SAMPLER_PREFETCH); > + GEN7_DISABLE_DEMAND_PREFETCH); > + > + /* Wa_1606682166:icl */ > + wa_write_or(wal, > + GEN7_SARCHKMD, > + GEN7_DISABLE_SAMPLER_PREFETCH); > } > > if (IS_GEN_RANGE(i915, 9, 11)) { > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx