From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 02/38] drm/i915: Make all GPU resets atomic Date: Fri, 18 Jan 2019 16:22:39 +0200 Message-ID: <87ef9avyds.fsf@gaia.fi.intel.com> References: <20190118140109.25261-1-chris@chris-wilson.co.uk> <20190118140109.25261-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B147F6F7DB for ; Fri, 18 Jan 2019 14:24:27 +0000 (UTC) In-Reply-To: <20190118140109.25261-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gcHJl cGFyYXRpb24gZm9yIHRoZSBuZXh0IGZldyBjb21taXRzLCBtYWtlIHJlc2V0dGluZyB0aGUgR1BV IGF0b21pYy4KPiBDdXJyZW50bHksIHdlIGhhdmUgcHJlcGFyZWQgZ2VuNisgZm9yIGF0b21pYyBy ZXNldHRpbmcgb2YgaW5kaXZpZHVhbAo+IGVuZ2luZXMsIGJ1dCBub3cgdGhlcmUgaXMgYSByZXF1 aXJlbWVudCB0byBwZXJmb3JtIHRoZSB3aG9sZSBkZXZpY2UKPiBsZXZlbCByZXNldCAoanVzdCB0 aGUgcmVnaXN0ZXIgcG9raW5nKSBmcm9tIGluc2lkZSBhbiBhdG9taWMgY29udGV4dC4KPgo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKUmV2 aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoK PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jIHwgNTAgKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygr KSwgMjMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9yZXNldC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gaW5kZXgg MzQyZDllZTQyNjAxLi5iOWQwZWE3MDM2MWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZXNldC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNl dC5jCj4gQEAgLTE0NCwxNCArMTQ0LDE0IEBAIHN0YXRpYyBpbnQgaTkxNV9kb19yZXNldChzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgCj4gIAkvKiBBc3NlcnQgcmVzZXQgZm9yIGF0 IGxlYXN0IDIwIHVzZWMsIGFuZCB3YWl0IGZvciBhY2tub3dsZWRnZW1lbnQuICovCj4gIAlwY2lf d3JpdGVfY29uZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwgR1JET01fUkVTRVRfRU5BQkxFKTsK PiAtCXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPiAtCWVyciA9IHdhaXRfZm9yKGk5MTVfaW5fcmVz ZXQocGRldiksIDUwMCk7Cj4gKwl1ZGVsYXkoNTApOwo+ICsJZXJyID0gd2FpdF9mb3JfYXRvbWlj KGk5MTVfaW5fcmVzZXQocGRldiksIDUwKTsKPiAgCj4gIAkvKiBDbGVhciB0aGUgcmVzZXQgcmVx dWVzdC4gKi8KPiAgCXBjaV93cml0ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCAwKTsK PiAtCXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPiArCXVkZWxheSg1MCk7Cj4gIAlpZiAoIWVycikK PiAtCQllcnIgPSB3YWl0X2ZvcighaTkxNV9pbl9yZXNldChwZGV2KSwgNTAwKTsKPiArCQllcnIg PSB3YWl0X2Zvcl9hdG9taWMoIWk5MTVfaW5fcmVzZXQocGRldiksIDUwKTsKPiAgCj4gIAlyZXR1 cm4gZXJyOwo+ICB9Cj4gQEAgLTE3MSw3ICsxNzEsNyBAQCBzdGF0aWMgaW50IGczM19kb19yZXNl dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgCXN0cnVjdCBwY2lfZGV2ICpwZGV2 ID0gaTkxNS0+ZHJtLnBkZXY7Cj4gIAo+ICAJcGNpX3dyaXRlX2NvbmZpZ19ieXRlKHBkZXYsIEk5 MTVfR0RSU1QsIEdSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gLQlyZXR1cm4gd2FpdF9mb3IoZzR4X3Jl c2V0X2NvbXBsZXRlKHBkZXYpLCA1MDApOwo+ICsJcmV0dXJuIHdhaXRfZm9yX2F0b21pYyhnNHhf cmVzZXRfY29tcGxldGUocGRldiksIDUwKTsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBnNHhfZG9f cmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC0xODIsMTMgKzE4 MiwxMyBAQCBzdGF0aWMgaW50IGc0eF9kb19yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gIAlpbnQgcmV0Owo+ICAKPiAgCS8qIFdhVmNwQ2xrR2F0ZURpc2FibGVGb3JN ZWRpYVJlc2V0OmN0ZyxlbGsgKi8KPiAtCUk5MTVfV1JJVEUoVkRFQ0NMS19HQVRFX0QsCj4gLQkJ ICAgSTkxNV9SRUFEKFZERUNDTEtfR0FURV9EKSB8IFZDUF9VTklUX0NMT0NLX0dBVEVfRElTQUJM RSk7Cj4gLQlQT1NUSU5HX1JFQUQoVkRFQ0NMS19HQVRFX0QpOwo+ICsJSTkxNV9XUklURV9GVyhW REVDQ0xLX0dBVEVfRCwKPiArCQkgICAgICBJOTE1X1JFQUQoVkRFQ0NMS19HQVRFX0QpIHwgVkNQ X1VOSVRfQ0xPQ0tfR0FURV9ESVNBQkxFKTsKPiArCVBPU1RJTkdfUkVBRF9GVyhWREVDQ0xLX0dB VEVfRCk7Cj4gIAo+ICAJcGNpX3dyaXRlX2NvbmZpZ19ieXRlKHBkZXYsIEk5MTVfR0RSU1QsCj4g IAkJCSAgICAgIEdSRE9NX01FRElBIHwgR1JET01fUkVTRVRfRU5BQkxFKTsKPiAtCXJldCA9ICB3 YWl0X2ZvcihnNHhfcmVzZXRfY29tcGxldGUocGRldiksIDUwMCk7Cj4gKwlyZXQgPSAgd2FpdF9m b3JfYXRvbWljKGc0eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTApOwo+ICAJaWYgKHJldCkgewo+ ICAJCURSTV9ERUJVR19EUklWRVIoIldhaXQgZm9yIG1lZGlhIHJlc2V0IGZhaWxlZFxuIik7Cj4g IAkJZ290byBvdXQ7Cj4gQEAgLTE5Niw3ICsxOTYsNyBAQCBzdGF0aWMgaW50IGc0eF9kb19yZXNl dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJcGNpX3dyaXRlX2Nv bmZpZ19ieXRlKHBkZXYsIEk5MTVfR0RSU1QsCj4gIAkJCSAgICAgIEdSRE9NX1JFTkRFUiB8IEdS RE9NX1JFU0VUX0VOQUJMRSk7Cj4gLQlyZXQgPSAgd2FpdF9mb3IoZzR4X3Jlc2V0X2NvbXBsZXRl KHBkZXYpLCA1MDApOwo+ICsJcmV0ID0gIHdhaXRfZm9yX2F0b21pYyhnNHhfcmVzZXRfY29tcGxl dGUocGRldiksIDUwKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlEUk1fREVCVUdfRFJJVkVSKCJXYWl0 IGZvciByZW5kZXIgcmVzZXQgZmFpbGVkXG4iKTsKPiAgCQlnb3RvIG91dDsKPiBAQCAtMjA1LDkg KzIwNSw5IEBAIHN0YXRpYyBpbnQgZzR4X2RvX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgb3V0Ogo+ICAJcGNpX3dyaXRlX2NvbmZpZ19ieXRlKHBkZXYsIEk5MTVf R0RSU1QsIDApOwo+ICAKPiAtCUk5MTVfV1JJVEUoVkRFQ0NMS19HQVRFX0QsCj4gLQkJICAgSTkx NV9SRUFEKFZERUNDTEtfR0FURV9EKSAmIH5WQ1BfVU5JVF9DTE9DS19HQVRFX0RJU0FCTEUpOwo+ IC0JUE9TVElOR19SRUFEKFZERUNDTEtfR0FURV9EKTsKPiArCUk5MTVfV1JJVEVfRlcoVkRFQ0NM S19HQVRFX0QsCj4gKwkJICAgICAgSTkxNV9SRUFEKFZERUNDTEtfR0FURV9EKSAmIH5WQ1BfVU5J VF9DTE9DS19HQVRFX0RJU0FCTEUpOwo+ICsJUE9TVElOR19SRUFEX0ZXKFZERUNDTEtfR0FURV9E KTsKPiAgCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gQEAgLTIxOCwyNyArMjE4LDI5IEBAIHN0YXRp YyBpbnQgaXJvbmxha2VfZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCUk5MTVfV1JJVEUoSUxLX0dEU1IsIElMS19HUkRP TV9SRU5ERVIgfCBJTEtfR1JET01fUkVTRVRfRU5BQkxFKTsKPiAtCXJldCA9IGludGVsX3dhaXRf Zm9yX3JlZ2lzdGVyKGRldl9wcml2LAo+IC0JCQkJICAgICAgSUxLX0dEU1IsIElMS19HUkRPTV9S RVNFVF9FTkFCTEUsIDAsCj4gLQkJCQkgICAgICA1MDApOwo+ICsJSTkxNV9XUklURV9GVyhJTEtf R0RTUiwgSUxLX0dSRE9NX1JFTkRFUiB8IElMS19HUkRPTV9SRVNFVF9FTkFCTEUpOwo+ICsJcmV0 ID0gX19pbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcl9mdyhkZXZfcHJpdiwgSUxLX0dEU1IsCj4gKwkJ CQkJICAgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSwgMCwKPiArCQkJCQkgICA1MDAwLCAwLAo+ICsJ CQkJCSAgIE5VTEwpOwo+ICAJaWYgKHJldCkgewo+ICAJCURSTV9ERUJVR19EUklWRVIoIldhaXQg Zm9yIHJlbmRlciByZXNldCBmYWlsZWRcbiIpOwo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAt CUk5MTVfV1JJVEUoSUxLX0dEU1IsIElMS19HUkRPTV9NRURJQSB8IElMS19HUkRPTV9SRVNFVF9F TkFCTEUpOwo+IC0JcmV0ID0gaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJ CQkgICAgICBJTEtfR0RTUiwgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSwgMCwKPiAtCQkJCSAgICAg IDUwMCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKElMS19HRFNSLCBJTEtfR1JET01fTUVESUEgfCBJTEtf R1JET01fUkVTRVRfRU5BQkxFKTsKPiArCXJldCA9IF9faW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXJf ZncoZGV2X3ByaXYsIElMS19HRFNSLAo+ICsJCQkJCSAgIElMS19HUkRPTV9SRVNFVF9FTkFCTEUs IDAsCj4gKwkJCQkJICAgNTAwMCwgMCwKPiArCQkJCQkgICBOVUxMKTsKPiAgCWlmIChyZXQpIHsK PiAgCQlEUk1fREVCVUdfRFJJVkVSKCJXYWl0IGZvciBtZWRpYSByZXNldCBmYWlsZWRcbiIpOwo+ ICAJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgb3V0Ogo+IC0JSTkxNV9XUklURShJTEtfR0RTUiwg MCk7Cj4gLQlQT1NUSU5HX1JFQUQoSUxLX0dEU1IpOwo+ICsJSTkxNV9XUklURV9GVyhJTEtfR0RT UiwgMCk7Cj4gKwlQT1NUSU5HX1JFQURfRlcoSUxLX0dEU1IpOwo+ICAJcmV0dXJuIHJldDsKPiAg fQo+ICAKPiBAQCAtNTcyLDcgKzU3NCw5IEBAIGludCBpbnRlbF9ncHVfcmVzZXQoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmk5MTUsIHVuc2lnbmVkIGludCBlbmdpbmVfbWFzaykKPiAgCQlyZXQg PSAtRU5PREVWOwo+ICAJCWlmIChyZXNldCkgewo+ICAJCQlHRU1fVFJBQ0UoImVuZ2luZV9tYXNr PSV4XG4iLCBlbmdpbmVfbWFzayk7Cj4gKwkJCXByZWVtcHRfZGlzYWJsZSgpOwo+ICAJCQlyZXQg PSByZXNldChpOTE1LCBlbmdpbmVfbWFzaywgcmV0cnkpOwo+ICsJCQlwcmVlbXB0X2VuYWJsZSgp Owo+ICAJCX0KPiAgCQlpZiAocmV0ICE9IC1FVElNRURPVVQgfHwgZW5naW5lX21hc2sgIT0gQUxM X0VOR0lORVMpCj4gIAkJCWJyZWFrOwo+IC0tIAo+IDIuMjAuMQo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=