From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v7 02/23] drm/i915/dsi: refactor bitrate calculations in intel_dsi_vbt_init() Date: Tue, 16 Oct 2018 15:44:06 +0300 Message-ID: <87efcqkqnd.fsf@intel.com> References: <100e9721dfdec4f3987549ef24291bafc9cb0517.1539613303.git.jani.nikula@intel.com> <1bc2cf04-6908-4858-0f61-26c6831bee86@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E3F26E20E for ; Tue, 16 Oct 2018 12:44:24 +0000 (UTC) In-Reply-To: <1bc2cf04-6908-4858-0f61-26c6831bee86@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Madhav Chauhan , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxNiBPY3QgMjAxOCwgTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVs LmNvbT4gd3JvdGU6Cj4gT24gMTAvMTUvMjAxOCA3OjU3IFBNLCBKYW5pIE5pa3VsYSB3cm90ZToK Pj4gQWJzdHJhY3QgYml0cmF0ZSBjYWxjdWxhdGlvbiB0byBhIG5ld2x5IHJlc3VycmVjdGVkIGlu dGVsX2RzaS5jIGZpbGUKPj4gdGhhdCB3aWxsIGNvbnRhaW4gY29tbW9uIGNvZGUgZm9yIFZMViBh bmQgSUNMIERTSS4KPj4KPj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgo+Pgo+PiBDYzogTWFkaGF2 IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4gQ2M6IFZpbGxlIFN5cmphbGEg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5p a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9NYWtlZmlsZSAgICAgICAgfCAgMSArCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHNpLmMgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKPj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kc2kuaCAgICAgfCAgMyArKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kc2lfdmJ0LmMgfCAyOCArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAgNCBm aWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4gICBjcmVh dGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmMKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvTWFrZWZpbGUKPj4gaW5kZXggNDhjYWUwZWFlM2Y5Li4yMmNiZjljM2JiMGMgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlCj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L01ha2VmaWxlCj4+IEBAIC0xNDMsNiArMTQzLDcgQEAgaTkxNS15ICs9IGR2 b19jaDcwMTcubyBcCj4+ICAgCSAgaW50ZWxfZHBfbGlua190cmFpbmluZy5vIFwKPj4gICAJICBp bnRlbF9kcF9tc3QubyBcCj4+ICAgCSAgaW50ZWxfZHAubyBcCj4+ICsJICBpbnRlbF9kc2kubyBc Cj4+ICAgCSAgaW50ZWxfZHNpX2Rjc19iYWNrbGlnaHQubyBcCj4+ICAgCSAgaW50ZWxfZHNpX3Zi dC5vIFwKPj4gICAJICBpbnRlbF9kdm8ubyBcCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5jCj4+ IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uNGRhYTFkYTk0MDQ3 Cj4+IC0tLSAvZGV2L251bGwKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNp LmMKPj4gQEAgLTAsMCArMSwxNyBAQAo+PiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IE1J VAo+PiArLyoKPj4gKyAqIENvcHlyaWdodCDCqSAyMDE4IEludGVsIENvcnBvcmF0aW9uCj4+ICsg Ki8KPj4gKwo+PiArI2luY2x1ZGUgPGRybS9kcm1fbWlwaV9kc2kuaD4KPj4gKyNpbmNsdWRlICJp bnRlbF9kc2kuaCIKPj4gKwo+PiAraW50IGludGVsX2RzaV9iaXRyYXRlKGNvbnN0IHN0cnVjdCBp bnRlbF9kc2kgKmludGVsX2RzaSkKPj4gK3sKPj4gKwlpbnQgYnBwID0gbWlwaV9kc2lfcGl4ZWxf Zm9ybWF0X3RvX2JwcChpbnRlbF9kc2ktPnBpeGVsX2Zvcm1hdCk7Cj4+ICsKPj4gKwlpZiAoV0FS Tl9PTihicHAgPCAwKSkKPj4gKwkJYnBwID0gMTY7Cj4KPiBTaG91bGRuJ3Qgd2Uga2VlcCB0aGUg ZGVmYXVsdCBicHAgdG8gMjQgaGVyZSBhcyBpbiBtb3N0IG9mIHRoZSBjYXNlcyBicHAgCj4gaXMg MjQgZm9yIERTSSBvciB3aHkgMTY/PwoKKnNocnVnKgoKTm90IHN1cmUgaXQgbWF0dGVycyBhbGwg dGhhdCBtdWNoIHJlYWxseS4gV2Ugc2V0IHRoZSBwaXhlbCBmb3JtYXQgaW4KaW50ZWxfZHNpX3Zi dC5jLCBhbmQgaWYgdGhhdCBnaXZlcyB1cyBzb21ldGhpbmcgYm9ndXMsIG5vdCBtdWNoIG9mIGEK Y2hhbmNlIGFueSBvZiBpdCB3aWxsIHdvcmsuIE1vcmUgdGhhbiBhbnl0aGluZyBJIGp1c3Qgd2Fu dGVkIHRvIGF2b2lkIGEKbmVnYXRpdmUgcmV0dXJuIGZyb20gdGhpcyBmdW5jdGlvbi4KCkJSLApK YW5pLgoKPgo+IFJlZ2FyZHMsCj4gTWFkaGF2Cj4KPj4gKwo+PiArCXJldHVybiBpbnRlbF9kc2kt PnBjbGsgKiBicHAgLyBpbnRlbF9kc2ktPmxhbmVfY291bnQ7Cj4+ICt9Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RzaS5oCj4+IGluZGV4IGFkN2MxY2IzMjk4My4uNjhmMTRkOGYxZTE4IDEwMDY0NAo+ PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaAo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaAo+PiBAQCAtMTI5LDYgKzEyOSw5IEBAIHN0YXRpYyBp bmxpbmUgc3RydWN0IGludGVsX2RzaSAqZW5jX3RvX2ludGVsX2RzaShzdHJ1Y3QgZHJtX2VuY29k ZXIgKmVuY29kZXIpCj4+ICAgCXJldHVybiBjb250YWluZXJfb2YoZW5jb2Rlciwgc3RydWN0IGlu dGVsX2RzaSwgYmFzZS5iYXNlKTsKPj4gICB9Cj4+ICAgCj4+ICsvKiBpbnRlbF9kc2kuYyAqLwo+ PiAraW50IGludGVsX2RzaV9iaXRyYXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2Rz aSk7Cj4+ICsKPj4gICAvKiB2bHZfZHNpLmMgKi8KPj4gICB2b2lkIHZsdl9kc2lfd2FpdF9mb3Jf Zmlmb19lbXB0eShzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2ksIGVudW0gcG9ydCBwb3J0KTsK Pj4gICBlbnVtIG1pcGlfZHNpX3BpeGVsX2Zvcm1hdCBwaXhlbF9mb3JtYXRfZnJvbV9yZWdpc3Rl cl9iaXRzKHUzMiBmbXQpOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHNpX3ZidC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3ZidC5jCj4+IGlu ZGV4IGFjODNkNmI4OWFlMC4uNmM0Y2M5MmY1OTQ3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHNpX3ZidC5jCj4+IEBAIC01MDYsMTQgKzUwNiwxMiBAQCBib29sIGludGVsX2RzaV92 YnRfaW5pdChzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2ksIHUxNiBwYW5lbF9pZCkKPj4gICAJ c3RydWN0IG1pcGlfY29uZmlnICptaXBpX2NvbmZpZyA9IGRldl9wcml2LT52YnQuZHNpLmNvbmZp ZzsKPj4gICAJc3RydWN0IG1pcGlfcHBzX2RhdGEgKnBwcyA9IGRldl9wcml2LT52YnQuZHNpLnBw czsKPj4gICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSBkZXZfcHJpdi0+dmJ0Lmxm cF9sdmRzX3ZidF9tb2RlOwo+PiAtCXUzMiBicHA7Cj4+IC0JdTMyIHRscHhfbnMsIGV4dHJhX2J5 dGVfY291bnQsIGJpdHJhdGUsIHRscHhfdWk7Cj4+ICsJdTMyIHRscHhfbnMsIGV4dHJhX2J5dGVf Y291bnQsIHRscHhfdWk7Cj4+ICAgCXUzMiB1aV9udW0sIHVpX2RlbjsKPj4gICAJdTMyIHByZXBh cmVfY250LCBleGl0X3plcm9fY250LCBjbGtfemVyb19jbnQsIHRyYWlsX2NudDsKPj4gICAJdTMy IHRoc19wcmVwYXJlX25zLCB0Y2xrX3RyYWlsX25zOwo+PiAgIAl1MzIgdGNsa19wcmVwYXJlX2Ns a3plcm8sIHRoc19wcmVwYXJlX2hzemVybzsKPj4gICAJdTMyIGxwX3RvX2hzX3N3aXRjaCwgaHNf dG9fbHBfc3dpdGNoOwo+PiAtCXUzMiBwY2xrLCBjb21wdXRlZF9kZHI7Cj4+ICAgCXUzMiBtdWw7 Cj4+ICAgCXUxNiBidXJzdF9tb2RlX3JhdGlvOwo+PiAgIAllbnVtIHBvcnQgcG9ydDsKPj4gQEAg LTUyNiw3ICs1MjQsNiBAQCBib29sIGludGVsX2RzaV92YnRfaW5pdChzdHJ1Y3QgaW50ZWxfZHNp ICppbnRlbF9kc2ksIHUxNiBwYW5lbF9pZCkKPj4gICAJaW50ZWxfZHNpLT5waXhlbF9mb3JtYXQg PQo+PiAgIAkJCXBpeGVsX2Zvcm1hdF9mcm9tX3JlZ2lzdGVyX2JpdHMoCj4+ICAgCQkJCW1pcGlf Y29uZmlnLT52aWRlb21vZGVfY29sb3JfZm9ybWF0IDw8IDcpOwo+PiAtCWJwcCA9IG1pcGlfZHNp X3BpeGVsX2Zvcm1hdF90b19icHAoaW50ZWxfZHNpLT5waXhlbF9mb3JtYXQpOwo+PiAgIAo+PiAg IAlpbnRlbF9kc2ktPmR1YWxfbGluayA9IG1pcGlfY29uZmlnLT5kdWFsX2xpbms7Cj4+ICAgCWlu dGVsX2RzaS0+cGl4ZWxfb3ZlcmxhcCA9IG1pcGlfY29uZmlnLT5waXhlbF9vdmVybGFwOwo+PiBA QCAtNTQxLDE5ICs1MzgsMTggQEAgYm9vbCBpbnRlbF9kc2lfdmJ0X2luaXQoc3RydWN0IGludGVs X2RzaSAqaW50ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4+ICAgCWludGVsX2RzaS0+dmlkZW9fZnJt dF9jZmdfYml0cyA9Cj4+ICAgCQltaXBpX2NvbmZpZy0+YnRhX2VuYWJsZWQgPyBESVNBQkxFX1ZJ REVPX0JUQSA6IDA7Cj4+ICAgCj4+IC0JcGNsayA9IG1vZGUtPmNsb2NrOwo+PiArCS8qIFN0YXJ0 aW5nIHBvaW50LCBhZGp1c3RlZCBkZXBlbmRpbmcgb24gZHVhbCBsaW5rIGFuZCBidXJzdCBtb2Rl ICovCj4+ICsJaW50ZWxfZHNpLT5wY2xrID0gbW9kZS0+Y2xvY2s7Cj4+ICAgCj4+ICAgCS8qIElu IGR1YWwgbGluayBtb2RlIGVhY2ggcG9ydCBuZWVkcyBoYWxmIG9mIHBpeGVsIGNsb2NrICovCj4+ ICAgCWlmIChpbnRlbF9kc2ktPmR1YWxfbGluaykgewo+PiAtCQlwY2xrID0gcGNsayAvIDI7Cj4+ ICsJCWludGVsX2RzaS0+cGNsayAvPSAyOwo+PiAgIAo+PiAgIAkJLyogd2UgY2FuIGVuYWJsZSBw aXhlbF9vdmVybGFwIGlmIG5lZWRlZCBieSBwYW5lbC4gSW4gdGhpcwo+PiAgIAkJICogY2FzZSB3 ZSBuZWVkIHRvIGluY3JlYXNlIHRoZSBwaXhlbGNsb2NrIGZvciBleHRyYSBwaXhlbHMKPj4gICAJ CSAqLwo+PiAgIAkJaWYgKGludGVsX2RzaS0+ZHVhbF9saW5rID09IERTSV9EVUFMX0xJTktfRlJP TlRfQkFDSykgewo+PiAtCQkJcGNsayArPSBESVZfUk9VTkRfVVAobW9kZS0+dnRvdGFsICoKPj4g LQkJCQkJCWludGVsX2RzaS0+cGl4ZWxfb3ZlcmxhcCAqCj4+IC0JCQkJCQk2MCwgMTAwMCk7Cj4+ ICsJCQlpbnRlbF9kc2ktPnBjbGsgKz0gRElWX1JPVU5EX1VQKG1vZGUtPnZ0b3RhbCAqIGludGVs X2RzaS0+cGl4ZWxfb3ZlcmxhcCAqIDYwLCAxMDAwKTsKPj4gICAJCX0KPj4gICAJfQo+PiAgIAo+ PiBAQCAtNTYzLDE5ICs1NTksMTggQEAgYm9vbCBpbnRlbF9kc2lfdmJ0X2luaXQoc3RydWN0IGlu dGVsX2RzaSAqaW50ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4+ICAgCSAqLwo+PiAgIAlpZiAoaW50 ZWxfZHNpLT52aWRlb19tb2RlX2Zvcm1hdCA9PSBWSURFT19NT0RFX0JVUlNUKSB7Cj4+ICAgCQlp ZiAobWlwaV9jb25maWctPnRhcmdldF9idXJzdF9tb2RlX2ZyZXEpIHsKPj4gLQkJCWNvbXB1dGVk X2RkciA9IChwY2xrICogYnBwKSAvIGludGVsX2RzaS0+bGFuZV9jb3VudDsKPj4gKwkJCXUzMiBi aXRyYXRlID0gaW50ZWxfZHNpX2JpdHJhdGUoaW50ZWxfZHNpKTsKPj4gICAKPj4gLQkJCWlmICht aXBpX2NvbmZpZy0+dGFyZ2V0X2J1cnN0X21vZGVfZnJlcSA8Cj4+IC0JCQkJCQkJCWNvbXB1dGVk X2Rkcikgewo+PiArCQkJaWYgKG1pcGlfY29uZmlnLT50YXJnZXRfYnVyc3RfbW9kZV9mcmVxIDwg Yml0cmF0ZSkgewo+PiAgIAkJCQlEUk1fRVJST1IoIkJ1cnN0IG1vZGUgZnJlcSBpcyBsZXNzIHRo YW4gY29tcHV0ZWRcbiIpOwo+PiAgIAkJCQlyZXR1cm4gZmFsc2U7Cj4+ICAgCQkJfQo+PiAgIAo+ PiAgIAkJCWJ1cnN0X21vZGVfcmF0aW8gPSBESVZfUk9VTkRfVVAoCj4+ICAgCQkJCW1pcGlfY29u ZmlnLT50YXJnZXRfYnVyc3RfbW9kZV9mcmVxICogMTAwLAo+PiAtCQkJCWNvbXB1dGVkX2Rkcik7 Cj4+ICsJCQkJYml0cmF0ZSk7Cj4+ICAgCj4+IC0JCQlwY2xrID0gRElWX1JPVU5EX1VQKHBjbGsg KiBidXJzdF9tb2RlX3JhdGlvLCAxMDApOwo+PiArCQkJaW50ZWxfZHNpLT5wY2xrID0gRElWX1JP VU5EX1VQKGludGVsX2RzaS0+cGNsayAqIGJ1cnN0X21vZGVfcmF0aW8sIDEwMCk7Cj4+ICAgCQl9 IGVsc2Ugewo+PiAgIAkJCURSTV9FUlJPUigiQnVyc3QgbW9kZSB0YXJnZXQgaXMgbm90IHNldFxu Iik7Cj4+ICAgCQkJcmV0dXJuIGZhbHNlOwo+PiBAQCAtNTg0LDkgKzU3OSw2IEBAIGJvb2wgaW50 ZWxfZHNpX3ZidF9pbml0KHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgdTE2IHBhbmVsX2lk KQo+PiAgIAkJYnVyc3RfbW9kZV9yYXRpbyA9IDEwMDsKPj4gICAKPj4gICAJaW50ZWxfZHNpLT5i dXJzdF9tb2RlX3JhdGlvID0gYnVyc3RfbW9kZV9yYXRpbzsKPj4gLQlpbnRlbF9kc2ktPnBjbGsg PSBwY2xrOwo+PiAtCj4+IC0JYml0cmF0ZSA9IChwY2xrICogYnBwKSAvIGludGVsX2RzaS0+bGFu ZV9jb3VudDsKPj4gICAKPj4gICAJc3dpdGNoIChpbnRlbF9kc2ktPmVzY2FwZV9jbGtfZGl2KSB7 Cj4+ICAgCWNhc2UgMDoKPj4gQEAgLTYyMCw3ICs2MTIsNyBAQCBib29sIGludGVsX2RzaV92YnRf aW5pdChzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2ksIHUxNiBwYW5lbF9pZCkKPj4gICAKPj4g ICAJLyogaW4gS2JwcyAqLwo+PiAgIAl1aV9udW0gPSBOU19LSFpfUkFUSU87Cj4+IC0JdWlfZGVu ID0gYml0cmF0ZTsKPj4gKwl1aV9kZW4gPSBpbnRlbF9kc2lfYml0cmF0ZShpbnRlbF9kc2kpOwo+ PiAgIAo+PiAgIAl0Y2xrX3ByZXBhcmVfY2xremVybyA9IG1pcGlfY29uZmlnLT50Y2xrX3ByZXBh cmVfY2xremVybzsKPj4gICAJdGhzX3ByZXBhcmVfaHN6ZXJvID0gbWlwaV9jb25maWctPnRoc19w cmVwYXJlX2hzemVybzsKPgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw aGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==