From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 4/5] drm/i915/execlists: Split spinlock from
 its irq disabling side-effect
Date: Fri, 02 Mar 2018 17:50:53 +0200
Message-ID: <87efl2pjc2.fsf@gaia.fi.intel.com>
References: <20180302143246.2579-1-chris@chris-wilson.co.uk>
 <20180302143246.2579-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6A2E26E198
 for <intel-gfx@lists.freedesktop.org>; Fri,  2 Mar 2018 15:55:30 +0000 (UTC)
In-Reply-To: <20180302143246.2579-4-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gRHVyaW5n
IHJlc2V0L3dlZGdpbmcsIHdlIGhhdmUgdG8gY2xlYW4gdXAgdGhlIHJlcXVlc3RzIG9uIHRoZSB0
aW1lbGluZQo+IGFuZCBmbHVzaCB0aGUgcGVuZGluZyBpbnRlcnJ1cHQgc3RhdGUuIEN1cnJlbnRs
eSwgd2UgYXJlIGFidXNpbmcgdGhlIGlycQo+IGRpc2FibGluZyBvZiB0aGUgdGltZWxpbmUgc3Bp
bmxvY2sgdG8gcHJvdGVjdCB0aGUgaXJxIHN0YXRlIGluCj4gY29uanVuY3Rpb24gdG8gdGhlIGVu
Z2luZSdzIHRpbWVsaW5lIHJlcXVlc3RzLCBidXQgdGhpcyBpcyBhY2NpZGVudGFsCj4gYW5kIGNv
bmZsYXRlcyB0aGUgc3BpbmxvY2sgd2l0aCB0aGUgaXJxIHN0YXRlLiBBIGJhZmZsaW5nIHN0YXRl
IG9mCj4gYWZmYWlycyBmb3IgdGhlIHJlYWRlci4KPgo+IEluc3RlYWQsIGV4cGxpY2l0bHkgZGlz
YWJsZSBpcnFzIG92ZXIgdGhlIGNyaXRpY2FsIHNlY3Rpb24sIGFuZCBzZXBhcmF0ZQo+IG1vZGlm
eWluZyB0aGUgaXJxIHN0YXRlIGZyb20gdGhlIHRpbWVsaW5lJ3MgcmVxdWVzdHMuCj4KPiBTdWdn
ZXN0ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+
IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+
IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzog
TWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAyMSArKysrKysrKysrKysrKystLS0tLS0KPiAg
MSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4KPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDA0ODJlNTRjOTRmMC4uN2QxMTA5YWNlYWJiIDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtNjg5LDExICs2ODksMTMgQEAgc3Rh
dGljIHZvaWQgZXhlY2xpc3RzX2NhbmNlbF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz
ICplbmdpbmUpCj4gIAo+ICAJR0VNX1RSQUNFKCIlc1xuIiwgZW5naW5lLT5uYW1lKTsKPiAgCj4g
LQlzcGluX2xvY2tfaXJxc2F2ZSgmZW5naW5lLT50aW1lbGluZS0+bG9jaywgZmxhZ3MpOwo+ICsJ
bG9jYWxfaXJxX3NhdmUoZmxhZ3MpOwoKQ2hyaXMgZXhwbGFpbmVkIGluIGlyYyB0aGF0IHRoaXMg
aXMgZm9yIGxvY2tkZXAgb25seS4gSXQgd2FzIGEgYml0CmNvbmZ1c2luZyBhcyB3ZSBhbHJlYWR5
IGFyZSBndWFyYW50ZWVkIGV4Y2x1c2l2ZSBhY2Nlc3MgdG8Kc3RhdGUgYnkgdGFza2xldCBiZWlu
ZyBraWxsZWQgYW5kIGRlYWQgYXQgdGhpcyBwb2ludC4KCkkgdGhpbmsgdGhpcyB3YXJyYW50cyBh
IGNvbW1lbnQgdGhhdCB0aGlzIGlzIHRvIHNvb3RoZSBsb2NrZGVwLgo+ICAKPiAgCS8qIENhbmNl
bCB0aGUgcmVxdWVzdHMgb24gdGhlIEhXIGFuZCBjbGVhciB0aGUgRUxTUCB0cmFja2VyLiAqLwo+
ICAJZXhlY2xpc3RzX2NhbmNlbF9wb3J0X3JlcXVlc3RzKGV4ZWNsaXN0cyk7Cj4gIAo+ICsJc3Bp
bl9sb2NrKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrKTsKPiArCj4gIAkvKiBNYXJrIGFsbCBleGVj
dXRpbmcgcmVxdWVzdHMgYXMgc2tpcHBlZC4gKi8KPiAgCWxpc3RfZm9yX2VhY2hfZW50cnkocnEs
ICZlbmdpbmUtPnRpbWVsaW5lLT5yZXF1ZXN0cywgbGluaykgewo+ICAJCUdFTV9CVUdfT04oIXJx
LT5nbG9iYWxfc2Vxbm8pOwo+IEBAIC03MjcsNiArNzI5LDggQEAgc3RhdGljIHZvaWQgZXhlY2xp
c3RzX2NhbmNlbF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAll
eGVjbGlzdHMtPmZpcnN0ID0gTlVMTDsKPiAgCUdFTV9CVUdfT04ocG9ydF9pc3NldChleGVjbGlz
dHMtPnBvcnQpKTsKPiAgCj4gKwlzcGluX3VubG9jaygmZW5naW5lLT50aW1lbGluZS0+bG9jayk7
Cj4gKwo+ICAJLyoKPiAgCSAqIFRoZSBwb3J0IGlzIGNoZWNrZWQgcHJpb3IgdG8gc2NoZWR1bGlu
ZyBhIHRhc2tsZXQsIGJ1dAo+ICAJICoganVzdCBpbiBjYXNlIHdlIGhhdmUgc3VzcGVuZGVkIHRo
ZSB0YXNrbGV0IHRvIGRvIHRoZQo+IEBAIC03MzgsNyArNzQyLDcgQEAgc3RhdGljIHZvaWQgZXhl
Y2xpc3RzX2NhbmNlbF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4g
IAkvKiBNYXJrIGFsbCBDUyBpbnRlcnJ1cHRzIGFzIGNvbXBsZXRlICovCj4gIAlleGVjbGlzdHMt
PmFjdGl2ZSA9IDA7Cj4gIAo+IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT50aW1l
bGluZS0+bG9jaywgZmxhZ3MpOwo+ICsJbG9jYWxfaXJxX3Jlc3RvcmUoZmxhZ3MpOwo+ICB9Cj4g
IAo+ICAvKgo+IEBAIC0xNjE4LDEwICsxNjIyLDExIEBAIHN0YXRpYyB2b2lkIHJlc2V0X2NvbW1v
bl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCUdFTV9UUkFDRSgiJXMg
c2Vxbm89JXhcbiIsCj4gIAkJICBlbmdpbmUtPm5hbWUsIHJlcXVlc3QgPyByZXF1ZXN0LT5nbG9i
YWxfc2Vxbm8gOiAwKTsKPiAgCj4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmZW5naW5lLT50aW1lbGlu
ZS0+bG9jaywgZmxhZ3MpOwo+ICsJbG9jYWxfaXJxX3NhdmUoZmxhZ3MpOwo+ICAKPiAgCXJlc2V0
X2lycShlbmdpbmUpOwo+ICAKPiArCgpVbmludGVudGlvbmFsIGV4dHJhIGxpbmU/CgpSZXZpZXdl
ZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICAJ
LyoKPiAgCSAqIENhdGNoIHVwIHdpdGggYW55IG1pc3NlZCBjb250ZXh0LXN3aXRjaCBpbnRlcnJ1
cHRzLgo+ICAJICoKPiBAQCAtMTYzNCwxNCArMTYzOSwxNyBAQCBzdGF0aWMgdm9pZCByZXNldF9j
b21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAlleGVjbGlzdHNf
Y2FuY2VsX3BvcnRfcmVxdWVzdHMoZXhlY2xpc3RzKTsKPiAgCj4gIAkvKiBQdXNoIGJhY2sgYW55
IGluY29tcGxldGUgcmVxdWVzdHMgZm9yIHJlcGxheSBhZnRlciB0aGUgcmVzZXQuICovCj4gKwlz
cGluX2xvY2soJmVuZ2luZS0+dGltZWxpbmUtPmxvY2spOwo+ICAJX191bndpbmRfaW5jb21wbGV0
ZV9yZXF1ZXN0cyhlbmdpbmUpOwo+ICsJc3Bpbl91bmxvY2soJmVuZ2luZS0+dGltZWxpbmUtPmxv
Y2spOwo+ICAKPiAgCS8qIE1hcmsgYWxsIENTIGludGVycnVwdHMgYXMgY29tcGxldGUgKi8KPiAg
CWV4ZWNsaXN0cy0+YWN0aXZlID0gMDsKPiAgCj4gLQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZl
bmdpbmUtPnRpbWVsaW5lLT5sb2NrLCBmbGFncyk7Cj4gKwlsb2NhbF9pcnFfcmVzdG9yZShmbGFn
cyk7Cj4gIAo+IC0JLyogSWYgdGhlIHJlcXVlc3Qgd2FzIGlubm9jZW50LCB3ZSBsZWF2ZSB0aGUg
cmVxdWVzdCBpbiB0aGUgRUxTUAo+ICsJLyoKPiArCSAqIElmIHRoZSByZXF1ZXN0IHdhcyBpbm5v
Y2VudCwgd2UgbGVhdmUgdGhlIHJlcXVlc3QgaW4gdGhlIEVMU1AKPiAgCSAqIGFuZCB3aWxsIHRy
eSB0byByZXBsYXkgaXQgb24gcmVzdGFydGluZy4gVGhlIGNvbnRleHQgaW1hZ2UgbWF5Cj4gIAkg
KiBoYXZlIGJlZW4gY29ycnVwdGVkIGJ5IHRoZSByZXNldCwgaW4gd2hpY2ggY2FzZSB3ZSBtYXkg
aGF2ZQo+ICAJICogdG8gc2VydmljZSBhIG5ldyBHUFUgaGFuZywgYnV0IG1vcmUgbGlrZWx5IHdl
IGNhbiBjb250aW51ZSBvbgo+IEBAIC0xNjU0LDcgKzE2NjIsOCBAQCBzdGF0aWMgdm9pZCByZXNl
dF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAlpZiAoIXJl
cXVlc3QgfHwgcmVxdWVzdC0+ZmVuY2UuZXJyb3IgIT0gLUVJTykKPiAgCQlyZXR1cm47Cj4gIAo+
IC0JLyogV2Ugd2FudCBhIHNpbXBsZSBjb250ZXh0ICsgcmluZyB0byBleGVjdXRlIHRoZSBicmVh
ZGNydW1iIHVwZGF0ZS4KPiArCS8qCj4gKwkgKiBXZSB3YW50IGEgc2ltcGxlIGNvbnRleHQgKyBy
aW5nIHRvIGV4ZWN1dGUgdGhlIGJyZWFkY3J1bWIgdXBkYXRlLgo+ICAJICogV2UgY2Fubm90IHJl
bHkgb24gdGhlIGNvbnRleHQgYmVpbmcgaW50YWN0IGFjcm9zcyB0aGUgR1BVIGhhbmcsCj4gIAkg
KiBzbyBjbGVhciBpdCBhbmQgcmVidWlsZCBqdXN0IHdoYXQgd2UgbmVlZCBmb3IgdGhlIGJyZWFk
Y3J1bWIuCj4gIAkgKiBBbGwgcGVuZGluZyByZXF1ZXN0cyBmb3IgdGhpcyBjb250ZXh0IHdpbGwg
YmUgemFwcGVkLCBhbmQgYW55Cj4gLS0gCj4gMi4xNi4yCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=