Re: [PATCH v3 4/4] drm/i915: Add is-wedged flag to intel_engine_dump()

[Mika Kuoppala <mika.kuoppala@linux.intel.com>]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Comparing the state tested by intel_engine_is_idle() and printed by
> intel_engine_dump(), the only bit not shown is whether or not the device
> is wedged. Add that little bit of information to the pretty printer so
> that if the engine fails to idle we can see why.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index af5ecd4e5690..07432d3c6641 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1744,6 +1744,9 @@ void intel_engine_dump(struct intel_engine_cs *engine,
>  	drm_vprintf(m, fmt, &ap);
>  	va_end(ap);
>  
> +	if (i915_terminally_wedged(&engine->i915->gpu_error))
> +		drm_printf(m, "*** WEDGED ***\n");
> +
>  	drm_printf(m, "\tcurrent seqno %x, last %x, hangcheck %x [%d ms], inflight %d\n",
>  		   intel_engine_get_seqno(engine),
>  		   intel_engine_last_submit(engine),
> -- 
> 2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx