From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Wang, Quanxian" <quanxian.wang@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Defined NM doesn't work on KBL and uses automatic N/M.
Date: Fri, 26 May 2017 14:00:33 +0300 [thread overview]
Message-ID: <87efvbnar2.fsf@intel.com> (raw)
In-Reply-To: <50C7F552BA2A744D84D95119645BEABD7DC38BBF@SHSMSX104.ccr.corp.intel.com>
On Fri, 26 May 2017, "Wang, Quanxian" <quanxian.wang@intel.com> wrote:
> [Wang, Quanxian] in Ubuntu 17.04, we do audio testing on KBL/SKL/APL
> and more, the audio doesn't work on KBL specially, and other platform
> works fine. Even if with latest upstream kernel, but it works on 4.8
> kernel. Therefore It is a regression issue. After investigation, we
> found it is caused by commit
> "6014ac122ed081feca99217bc57b2e15c7fc1a51] drm/i915/audio: set proper
> N/M in modeset". Therefore I provided this patch.
If it's a regression, we need to backport the fix to stable kernels, and
the patch needs annotation:
Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset")
Cc: <stable@vger.kernel.org> # v4.10+
> After getting suggestion from you and Libin, we do more testing on 4K
> monitor for audio delay issue. Also talked with Libin why not use
> transcoder disable/enable process described in bspec, it will affect
> performance.
>
> This is the whole story. You can check LCK number 3791 in Intel JIRA
> about that.
Actually, I can't. And the commit message needs to have the
explanation. I still do not know what the bug is specifically, or why
Kabylake, and only Kabylake, needs this.
> [Wang, Quanxian] Basically if upstream could provide a reasonable
> patch, it will appreciate since you are expert in this area.
> Thanks for your understanding.
The patch is probably fine. But I can't invent an explanation if I don't
know what the problem is.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-26 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 6:07 [PATCH] Defined NM doesn't work on KBL and uses automatic N/M Quanxian Wang
2017-05-26 6:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-26 8:31 ` [PATCH] " Jani Nikula
2017-05-26 9:52 ` Wang, Quanxian
2017-05-26 11:00 ` Jani Nikula [this message]
2017-05-26 21:36 ` Wang, Quanxian
2017-05-29 8:29 ` Jani Nikula
2017-05-31 3:20 ` Wang, Quanxian
2017-12-08 0:41 ` Wang, Quanxian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efvbnar2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=quanxian.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).