From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 12:08:14 +0300 Message-ID: <87efwerzep.fsf@intel.com> References: <1493227086-3807-3-git-send-email-imre.deak@intel.com> <1493282214-11808-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32CC46E05D for ; Thu, 27 Apr 2017 09:05:48 +0000 (UTC) In-Reply-To: <1493282214-11808-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyNyBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBBbiBlcnJvciBmcm9tIGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKCkgd291bGQg bWVhbiBhIGJ1ZyBzb21ld2hlcmUKPiBlbHNlLCBidXQgd2Ugc3RpbGwgc2hvdWxkIGNoZWNrIGZv ciBpdCB0byBwcmV2ZW50IHNvbWUgb3RoZXIgbW9yZQo+IG9ic2N1cmUgYnVnIGxhdGVyLgo+Cj4g djI6Cj4gLSBGYWxsIGJhY2sgdG8gYSByZWFzb25hYmxlIGRlZmF1bHQgaW5zdGVhZCBvZiBiYWls aW5nIG91dCBpbiBjYXNlIG9mCj4gICBlcnJvci4gKEphbmkpCj4gdjM6Cj4gLSBGaXggcy9QSVBF X0lOVkFMSUQvSU5WQUxJRF9QSVBFLyB0eXBvLiAoSmFuaSkKPgo+IENjOiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5k ZWFrQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50 ZWwuY29tPgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgfCAx NyArKysrKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wYW5lbC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+IGluZGV4IGNi NTBjNTIuLmQxYWJiZjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBAQCAt ODg4LDEwICs4ODgsMTQgQEAgc3RhdGljIHZvaWQgcGNoX2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0 IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBpbnRl bF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiAgCWVudW0gcGlwZSBwaXBlID0g aW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAtCWVudW0gdHJhbnNj b2RlciBjcHVfdHJhbnNjb2RlciA9Cj4gLQkJaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2Rlcihk ZXZfcHJpdiwgcGlwZSk7Cj4gKwllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXI7Cj4gIAl1 MzIgY3B1X2N0bDIsIHBjaF9jdGwxLCBwY2hfY3RsMjsKPiAgCj4gKwlpZiAoIVdBUk5fT05fT05D RShwaXBlID09IElOVkFMSURfUElQRSkpCj4gKwkJY3B1X3RyYW5zY29kZXIgPSBpbnRlbF9waXBl X3RvX2NwdV90cmFuc2NvZGVyKGRldl9wcml2LCBwaXBlKTsKPiArCWVsc2UKPiArCQljcHVfdHJh bnNjb2RlciA9IFRSQU5TQ09ERVJfRURQOwo+ICsKPiAgCWNwdV9jdGwyID0gSTkxNV9SRUFEKEJM Q19QV01fQ1BVX0NUTDIpOwo+ICAJaWYgKGNwdV9jdGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPiAg CQlEUk1fREVCVUdfS01TKCJjcHUgYmFja2xpZ2h0IGFscmVhZHkgZW5hYmxlZFxuIik7Cj4gQEAg LTk3Myw2ICs5NzcsOSBAQCBzdGF0aWMgdm9pZCBpOTY1X2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0 IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9n ZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdTMyIGN0bCwgY3RsMiwgZnJl cTsKPiAgCj4gKwlpZiAoV0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiArCQlw aXBlID0gUElQRV9BOwo+ICsKPiAgCWN0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9DVEwyKTsKPiAg CWlmIChjdGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJiYWNrbGln aHQgYWxyZWFkeSBlbmFibGVkXG4iKTsKPiBAQCAtMTAzNyw2ICsxMDQ0LDkgQEAgc3RhdGljIHZv aWQgYnh0X2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9y KQo+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25u ZWN0b3IpOwo+ICAJdTMyIHB3bV9jdGwsIHZhbDsKPiAgCj4gKwlpZiAoV0FSTl9PTl9PTkNFKHBp cGUpID09IElOVkFMSURfUElQRSkKPiArCQlwaXBlID0gUElQRV9BOwo+ICsKPiAgCS8qIENvbnRy b2xsZXIgMSB1c2VzIHRoZSB1dGlsaXR5IHBpbi4gKi8KPiAgCWlmIChwYW5lbC0+YmFja2xpZ2h0 LmNvbnRyb2xsZXIgPT0gMSkgewo+ICAJCXZhbCA9IEk5MTVfUkVBRChVVElMX1BJTl9DVEwpOwo+ IEBAIC0xMDkzLDcgKzExMDMsOCBAQCB2b2lkIGludGVsX3BhbmVsX2VuYWJsZV9iYWNrbGlnaHQo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJaWYgKCFwYW5lbC0+YmFja2xp Z2h0LnByZXNlbnQpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCURSTV9ERUJVR19LTVMoInBpcGUgJWNc biIsIHBpcGVfbmFtZShwaXBlKSk7Cj4gKwlpZiAoIVdBUk5fT05fT05DRShwaXBlID09IElOVkFM SURfUElQRSkpCj4gKwkJRFJNX0RFQlVHX0tNUygicGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUp KTsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK