From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Date: Wed, 09 Nov 2016 11:27:37 +0200 Message-ID: <87eg2lgfzq.fsf@intel.com> References: <1478625682-8955-1-git-send-email-paulo.r.zanoni@intel.com> <20161109011315.GF6536@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C02886E650 for ; Wed, 9 Nov 2016 09:27:39 +0000 (UTC) In-Reply-To: <20161109011315.GF6536@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , Paulo Zanoni Cc: "Vetter, Daniel" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAwOSBOb3YgMjAxNiwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNv bT4gd3JvdGU6Cj4gT24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDM6MjE6MjJQTSAtMDIwMCwgUGF1 bG8gWmFub25pIHdyb3RlOgo+PiBPbmUgb2YgdGhlIG1lbXNldHMgd2FzIGFkZGVkIGJ5IDVhOTIw Yjg1ZjJjNiAoImRybS9pOTE1L2dlbjk6IGZpeCBEREIKPj4gcGFydGl0aW9uaW5nIGZvciBtdWx0 aS1zY3JlZW4gY2FzZXMiKSwgYW5kIHRoZSBvdGhlciB3YXMgYWRkZWQgYnkKPj4gMDFjNzJkNmMx NyAoImRybS9pOTE1L2dlbjk6IGZpeCBEREIgcGFydGl0aW9uaW5nIGZvciBtdWx0aS1zY3JlZW4K Pj4gY2FzZXMiKS4gSSdtIGNvbmZ1c2VkIGFuZCBJJ2xsIGxldCB0aGUgbWFpbnRhaW5lcnMgZmlu ZCBvdXQgd2hhdCB3ZW50Cj4+IHdyb25nIGhlcmUuCj4+IAo+PiBDYzogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVs by5yLnphbm9uaUBpbnRlbC5jb20+Cj4KPiBJIHRoaW5rIHRoaXMgaXMganVzdCBhbiBhcnRpZmFj dCBvZiBoYXZpbmcgdGhlIHBhdGNoIGluIGJvdGggLW5leHQgYW5kCj4gLWZpeGVzLiAgVGhlIGNv bnRleHQgcHJvYmFibHkgY2hhbmdlZCBsYXRlciBpbiAtbmV4dCBjYXVzaW5nIGEgY29uZmxpY3QK PiB3aGVuIHRoZSB0d28gd2VyZSBtZXJnZWQsIGFuZCB0aGVuIHRoZSBtZXJnZSByZXNvbHV0aW9u IGFjY2lkZW50YWxseQo+IGR1cGxpY2F0ZWQgdGhpcyBodW5rLiAgVGhlIG1lcmdlIGNvbW1pdCBh YzQxMzllZDcgaXMgd2hlcmUgd2Ugd291bmQgdXAKPiB3aXRoIHRoZSB0d28gY29waWVzOgoKSSBk b24ndCBoYXZlIHRoYXQgbWVyZ2UgY29tbWl0LiBJcyB0aGF0IGEgbmlnaHRseSByZWJ1aWxkPwoK SSBkb24ndCB0aGluayB3ZSBldmVuIGhhdmUgdGhpcyBpc3N1ZSBpbiBhbnl3aGVyZSBvdGhlciB0 aGFuCm5pZ2h0bHkuIFRoZXJlIGlzbid0IGEgYnJhbmNoIHdlIGNvdWxkIGFwcGx5IHRoaXMgZml4 IHRvLgoKQlIsCkphbmkuCgoKPgo+ICAgICAgICAgZGlmZiAtLWNjIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiAgICAgICAgIGluZGV4IGRiMjRmODksY2M5ZTBjMC4uODhlMjhjOQo+ ICAgICAgICAgLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICAgICAgICAg KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICAgICAgICAgQEBAIC0zMzYx LDExIC0zNDA0LDEzICszNDA0LDE3IEBAQCBza2xfYWxsb2NhdGVfcGlwZV9kZGIoc3RydWN0IGlu dGVsX2NydGMKPiAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHRvdGFsX2RhdGFfcmF0ZTsK PiAgICAgICAgICAgICAgICAgaW50IG51bV9hY3RpdmU7Cj4gICAgICAgICAgICAgICAgIGludCBp ZCwgaTsKPiAgICAgICAgICsgICAgICAgdW5zaWduZWQgcGxhbmVfZGF0YV9yYXRlW0k5MTVfTUFY X1BMQU5FU10gPSB7fTsKPiAgICAgICAgICsgICAgICAgdW5zaWduZWQgcGxhbmVfeV9kYXRhX3Jh dGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+ICAgICAgICAgKyAKPiAgICAgICAgICsgICAgICAg LyogQ2xlYXIgdGhlIHBhcnRpdGlvbmluZyBmb3IgZGlzYWJsZWQgcGxhbmVzLiAqLwo+ICAgICAg ICAgKyAgICAgICBtZW1zZXQoZGRiLT5wbGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxhbmVb cGlwZV0pKTsKPiAgICAgICAgICsgICAgICAgbWVtc2V0KGRkYi0+eV9wbGFuZVtwaXBlXSwgMCwg c2l6ZW9mKGRkYi0+eV9wbGFuZVtwaXBlXSkpOwo+ICAgICAgICAgICAKPiAgICAgICAgICArICAg ICAgLyogQ2xlYXIgdGhlIHBhcnRpdGlvbmluZyBmb3IgZGlzYWJsZWQgcGxhbmVzLiAqLwo+ICAg ICAgICAgICsgICAgICBtZW1zZXQoZGRiLT5wbGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxh bmVbcGlwZV0pKTsKPiAgICAgICAgICArICAgICAgbWVtc2V0KGRkYi0+eV9wbGFuZVtwaXBlXSwg MCwgc2l6ZW9mKGRkYi0+eV9wbGFuZVtwaXBlXSkpOwo+ICAgICAgICAgICsKPiAgICAgICAgICAg ICAgICAgaWYgKFdBUk5fT04oIXN0YXRlKSkKPiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gMDsKPiAgICAgICAgICAgCj4gRHJvcHBpbmcgb25lIGxvb2tzIGdvb2QgdG8gbWUuCj4KPiBS ZXZpZXdlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPgo+PiAt LS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA0IC0tLS0KPj4gIDEgZmls ZSBjaGFuZ2VkLCA0IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+ IGluZGV4IDg4ZTI4YzkuLmNjOWUwYzAgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ PiBAQCAtMzQxMSwxMCArMzQxMSw2IEBAIHNrbF9hbGxvY2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+PiAgCW1lbXNldChkZGItPnBsYW5lW3BpcGVdLCAwLCBz aXplb2YoZGRiLT5wbGFuZVtwaXBlXSkpOwo+PiAgCW1lbXNldChkZGItPnlfcGxhbmVbcGlwZV0s IDAsIHNpemVvZihkZGItPnlfcGxhbmVbcGlwZV0pKTsKPj4gIAo+PiAtCS8qIENsZWFyIHRoZSBw YXJ0aXRpb25pbmcgZm9yIGRpc2FibGVkIHBsYW5lcy4gKi8KPj4gLQltZW1zZXQoZGRiLT5wbGFu ZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxhbmVbcGlwZV0pKTsKPj4gLQltZW1zZXQoZGRiLT55 X3BsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT55X3BsYW5lW3BpcGVdKSk7Cj4+IC0KPj4gIAlp ZiAoV0FSTl9PTighc3RhdGUpKQo+PiAgCQlyZXR1cm4gMDsKPj4gIAo+PiAtLSAKPj4gMi43LjQK Pj4gCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK