From: Jani Nikula <jani.nikula@intel.com>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked
Date: Mon, 29 Aug 2016 12:06:14 +0300 [thread overview]
Message-ID: <87eg58rlkp.fsf@intel.com> (raw)
In-Reply-To: <1472447439.3227.1.camel@gmail.com>
On Mon, 29 Aug 2016, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> On Thu, 2016-08-25 at 15:04 +0300, Jani Nikula wrote:
>> The last user of for_each_intel_crtc_masked macro was removed in
>>
>> commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
>> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Date: Tue Apr 21 17:13:04 2015 +0300
>>
>> drm/i915: Remove all *_pipes flags from modeset
>>
>> Get rid of the unused macro.
>>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Pushed, thanks.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index e4e6141b38c0..19ffd024ddec 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
>> clock2)
>> return false;
>> }
>>
>> -#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
>> - list_for_each_entry((intel_crtc), \
>> - &(dev)->mode_config.crtc_list, \
>> - base.head) \
>> - for_each_if (mask & (1 <<(intel_crtc)->pipe))
>> -
>> static bool
>> intel_compare_m_n(unsigned int m, unsigned int n,
>> unsigned int m2, unsigned int n2,
>> @@ -14585,8 +14579,6 @@ out:
>> drm_atomic_state_free(state);
>> }
>>
>> -#undef for_each_intel_crtc_masked
>> -
>> /*
>> * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
>> * drm_atomic_helper_legacy_gamma_set() directly.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-29 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 12:04 [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked Jani Nikula
2016-08-25 12:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-29 5:10 ` [PATCH] " Ander Conselvan De Oliveira
2016-08-29 9:06 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg58rlkp.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox