public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked
@ 2016-08-25 12:04 Jani Nikula
  2016-08-25 12:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2016-08-29  5:10 ` [PATCH] " Ander Conselvan De Oliveira
  0 siblings, 2 replies; 4+ messages in thread
From: Jani Nikula @ 2016-08-25 12:04 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Ander Conselvan de Oliveira

The last user of for_each_intel_crtc_masked macro was removed in

commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Tue Apr 21 17:13:04 2015 +0300

    drm/i915: Remove all *_pipes flags from modeset

Get rid of the unused macro.

Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e4e6141b38c0..19ffd024ddec 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int clock2)
 	return false;
 }
 
-#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
-	list_for_each_entry((intel_crtc), \
-			    &(dev)->mode_config.crtc_list, \
-			    base.head) \
-		for_each_if (mask & (1 <<(intel_crtc)->pipe))
-
 static bool
 intel_compare_m_n(unsigned int m, unsigned int n,
 		  unsigned int m2, unsigned int n2,
@@ -14585,8 +14579,6 @@ out:
 		drm_atomic_state_free(state);
 }
 
-#undef for_each_intel_crtc_masked
-
 /*
  * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
  *        drm_atomic_helper_legacy_gamma_set() directly.
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: remove leftover for_each_intel_crtc_masked
  2016-08-25 12:04 [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked Jani Nikula
@ 2016-08-25 12:50 ` Patchwork
  2016-08-29  5:10 ` [PATCH] " Ander Conselvan De Oliveira
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-08-25 12:50 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: remove leftover for_each_intel_crtc_masked
URL   : https://patchwork.freedesktop.org/series/11563/
State : failure

== Summary ==

Series 11563v1 drm/i915: remove leftover for_each_intel_crtc_masked
http://patchwork.freedesktop.org/api/1.0/series/11563/revisions/1/mbox/

Test drv_hangman:
        Subgroup error-state-basic:
                pass       -> DMESG-WARN (fi-snb-2520m)
Test gem_basic:
        Subgroup bad-close:
                dmesg-warn -> PASS       (fi-snb-2520m)
Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> INCOMPLETE (fi-hsw-4770k)
Test gem_ringfill:
        Subgroup basic-default-forked:
                pass       -> DMESG-WARN (fi-snb-2520m)
        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-snb-2520m)

fi-bdw-5557u     total:252  pass:235  dwarn:0   dfail:0   fail:2   skip:15 
fi-bsw-n3050     total:252  pass:205  dwarn:0   dfail:0   fail:1   skip:46 
fi-byt-n2820     total:252  pass:207  dwarn:0   dfail:0   fail:3   skip:42 
fi-hsw-4770k     total:107  pass:91   dwarn:0   dfail:0   fail:0   skip:15 
fi-hsw-4770r     total:252  pass:224  dwarn:0   dfail:0   fail:2   skip:26 
fi-ivb-3520m     total:252  pass:220  dwarn:0   dfail:0   fail:1   skip:31 
fi-skl-6260u     total:252  pass:236  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-6700k     total:252  pass:222  dwarn:0   dfail:0   fail:2   skip:28 
fi-snb-2520m     total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 
fi-snb-2600      total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 

Results at /archive/results/CI_IGT_test/Patchwork_2430/

30de872fd5cf71a51994375fb4f76856c05b1c4c drm-intel-nightly: 2016y-08m-25d-11h-15m-39s UTC integration manifest
a57b606 drm/i915: remove leftover for_each_intel_crtc_masked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked
  2016-08-25 12:04 [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked Jani Nikula
  2016-08-25 12:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-08-29  5:10 ` Ander Conselvan De Oliveira
  2016-08-29  9:06   ` Jani Nikula
  1 sibling, 1 reply; 4+ messages in thread
From: Ander Conselvan De Oliveira @ 2016-08-29  5:10 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx

On Thu, 2016-08-25 at 15:04 +0300, Jani Nikula wrote:
> The last user of for_each_intel_crtc_masked macro was removed in
> 
> commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date:   Tue Apr 21 17:13:04 2015 +0300
> 
>     drm/i915: Remove all *_pipes flags from modeset
> 
> Get rid of the unused macro.
> 
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index e4e6141b38c0..19ffd024ddec 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
> clock2)
>  	return false;
>  }
>  
> -#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
> -	list_for_each_entry((intel_crtc), \
> -			    &(dev)->mode_config.crtc_list, \
> -			    base.head) \
> -		for_each_if (mask & (1 <<(intel_crtc)->pipe))
> -
>  static bool
>  intel_compare_m_n(unsigned int m, unsigned int n,
>  		  unsigned int m2, unsigned int n2,
> @@ -14585,8 +14579,6 @@ out:
>  		drm_atomic_state_free(state);
>  }
>  
> -#undef for_each_intel_crtc_masked
> -
>  /*
>   * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
>   *        drm_atomic_helper_legacy_gamma_set() directly.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked
  2016-08-29  5:10 ` [PATCH] " Ander Conselvan De Oliveira
@ 2016-08-29  9:06   ` Jani Nikula
  0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-08-29  9:06 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira, intel-gfx

On Mon, 29 Aug 2016, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> On Thu, 2016-08-25 at 15:04 +0300, Jani Nikula wrote:
>> The last user of for_each_intel_crtc_masked macro was removed in
>> 
>> commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
>> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Date:   Tue Apr 21 17:13:04 2015 +0300
>> 
>>     drm/i915: Remove all *_pipes flags from modeset
>> 
>> Get rid of the unused macro.
>> 
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

Pushed, thanks.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 8 --------
>>  1 file changed, 8 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index e4e6141b38c0..19ffd024ddec 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
>> clock2)
>>  	return false;
>>  }
>>  
>> -#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
>> -	list_for_each_entry((intel_crtc), \
>> -			    &(dev)->mode_config.crtc_list, \
>> -			    base.head) \
>> -		for_each_if (mask & (1 <<(intel_crtc)->pipe))
>> -
>>  static bool
>>  intel_compare_m_n(unsigned int m, unsigned int n,
>>  		  unsigned int m2, unsigned int n2,
>> @@ -14585,8 +14579,6 @@ out:
>>  		drm_atomic_state_free(state);
>>  }
>>  
>> -#undef for_each_intel_crtc_masked
>> -
>>  /*
>>   * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
>>   *        drm_atomic_helper_legacy_gamma_set() directly.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-29  9:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-25 12:04 [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked Jani Nikula
2016-08-25 12:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-29  5:10 ` [PATCH] " Ander Conselvan De Oliveira
2016-08-29  9:06   ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox