Re: [PATCH] drm/i915: Fix crtc_y assignment in intel_find_initial_plane_obj()

Jani Nikula
2015-11-16T12:42:54Z

On Mon, 16 Nov 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> Op 13-11-15 om 18:16 schreef ville.syrjala@linux.intel.com:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Let's set crtc_y to 0 instead of setting src_y twice.
>>
>> Multiple assignments in one statement is a good way to hide bugs.
>> Please don't do that.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Fixes: be5651f2d581 ("drm/i915: Update missing properties in find_initial_plane_obj")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
> Oops.
>
> R-b

Pushed to drm-intel-fixes, thanks for the patch and review.

Maarten, please give Damien and our tooling a chance and spell out the
R-b...

BR,
Jani.

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center