intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* Adding custom bugzilla fields
@ 2015-06-26 15:28 Ander Conselvan De Oliveira
  2015-06-26 17:05 ` Daniel Vetter
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
  0 siblings, 2 replies; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-26 15:28 UTC (permalink / raw)
  To: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 2718 bytes --]

Hi all,

I've been looking into creating custom fields in Bugzilla to help sort
our bugs in a more manageable way. I did some testing in a private
installation and came up with this proposal. In a nut shell, we would
add the following two fields:

	i915 platform:	list of platforms affected by a bug;
	i915 features:  list of features affected by a bug.

Both would be multiple selection fields. The accepted values would be
configured in the Bugzilla installation. The attached screenshots show
how this would look like in the bug view and bug list views.

My expectation is that using those fields we could have a clearer view
of which areas and/or platforms require more attention. For example, I
attached a screenshot of a sample report breaking down the bugs per
feature and platform. That report requires Bugzilla 5.0 (which hasn't
been released yet) since prior versions didn't support reports with
multiple selection fields. However, it is also possible to script a
similar report, as the attached python script does. The output looks
something like this:

Feature                ALL  ILK  SNB  BYT  IVB  HSW  BDW  BSW  SKL
display - atomic         0    0    1    0    0    0    1    0    0
display - audio          0    0    0    0    0    0    0    0    0
display - DP             0    0    1    0    1    0    1    0    0
display - DP MST         0    0    0    0    0    0    0    0    0
display - DSI            0    0    0    0    0    0    0    0    0
display - eDP            0    0    0    0    0    0    0    0    0
display - fastboot       0    0    0    0    0    0    0    0    0
display - FBC            0    0    0    0    0    0    0    0    0
display - HDMI           0    0    0    0    0    0    0    0    0
display - IPS            0    0    0    0    0    0    0    0    0
display - LVDS           0    0    0    0    0    0    0    0    0
display - PSR            0    0    0    0    0    0    0    0    0
display - Other          0    0    0    0    0    0    0    0    0
GEM - execlists          0    0    0    0    0    0    0    0    0
GEM - PPGTT              0    0    0    0    0    0    0    0    0
GEM - Other              1    0    0    0    0    0    1    0    0
power - RC6              0    0    0    1    0    0    0    0    0
power - RCS              0    0    0    0    0    0    0    0    0
power - Other            0    0    0    0    0    0    0    0    0


So I would like to hear what other people think about this. Specially,
about what should be in the features field. The values can change
overtime, but would be good to have a good list from the start. The
values above are an incomplete list I threw together while looking at
different open bugs.

Thanks,
Ander

[-- Attachment #2: bug.png --]
[-- Type: image/png, Size: 72559 bytes --]

[-- Attachment #3: bug_list.png --]
[-- Type: image/png, Size: 66466 bytes --]

[-- Attachment #4: report.png --]
[-- Type: image/png, Size: 36688 bytes --]

[-- Attachment #5: features_vs_platform.py --]
[-- Type: text/x-python, Size: 1748 bytes --]

import bugzilla
import collections

bugzilla_url = "http://192.168.100.244/bugzilla/xmlrpc.cgi"

closed_states = ['RESOLVED', 'VERIFIED', 'CLOSED']
open_states = ["REOPENED", "NEEDINFO", "NEW", "ASSIGNED"]

def get_custom_fields_allowed_values(bz):
	fields = ['cf_i915_platform', 'cf_i915_features']
	r =  bz._proxy.Bug.fields({'names': fields,
				   'include_fields': ['values']})

	list_of_raw_values = [f['values'] for f in r['fields']]
	values = [[v['name'] for v in f] for f in list_of_raw_values]

	assert len(values) == len(fields)
	return dict(zip(fields, values))

def get_drm_intel_bugs(bz):
	query = bz.build_query(product="DRI", component="DRM/Intel",
			       status=open_states)
	return bz.query(query)

def split_bugs_per_field(bz, bugs, field):
	split = collections.OrderedDict()

	allowed_values = get_custom_fields_allowed_values(bz)
	for v in allowed_values[field]:
		split[v] = []

	for bug in bugs:
		if field in bug.__dict__:
			for value in bug.__dict__[field]:
				split[value].append(bug)

	return split

def intersect_lists(list1, list2):
	return [v for v in list1 if v in list2]

def stringfy_list(l, spacing=5):
	return ''.join([s.rjust(spacing) for s in map(str, l)])

if __name__ == "__main__":
	bz = bugzilla.Bugzilla(url=bugzilla_url)

	bugs = get_drm_intel_bugs(bz)

	per_platform = split_bugs_per_field(bz, bugs, 'cf_i915_platform')
	per_feature = split_bugs_per_field(bz, bugs, 'cf_i915_features')

	print "Feature".ljust(20), stringfy_list(per_platform)

	for feature in per_feature:
		common_count = []
		for platform in per_platform:
			common = intersect_lists(per_feature[feature],
						 per_platform[platform])
			common_count.append(len(common))

		print feature.ljust(20), stringfy_list(common_count)


[-- Attachment #6: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 15:28 Adding custom bugzilla fields Ander Conselvan De Oliveira
@ 2015-06-26 17:05 ` Daniel Vetter
  2015-06-26 17:23   ` Chris Wilson
  2015-06-29  8:50   ` Ander Conselvan De Oliveira
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
  1 sibling, 2 replies; 24+ messages in thread
From: Daniel Vetter @ 2015-06-26 17:05 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira; +Cc: intel-gfx

On Fri, Jun 26, 2015 at 06:28:39PM +0300, Ander Conselvan De Oliveira wrote:
> Hi all,
> 
> I've been looking into creating custom fields in Bugzilla to help sort
> our bugs in a more manageable way. I did some testing in a private
> installation and came up with this proposal. In a nut shell, we would
> add the following two fields:
> 
> 	i915 platform:	list of platforms affected by a bug;
> 	i915 features:  list of features affected by a bug.
> 
> Both would be multiple selection fields. The accepted values would be
> configured in the Bugzilla installation. The attached screenshots show
> how this would look like in the bug view and bug list views.
> 
> My expectation is that using those fields we could have a clearer view
> of which areas and/or platforms require more attention. For example, I
> attached a screenshot of a sample report breaking down the bugs per
> feature and platform. That report requires Bugzilla 5.0 (which hasn't
> been released yet) since prior versions didn't support reports with
> multiple selection fields. However, it is also possible to script a
> similar report, as the attached python script does. The output looks
> something like this:
> 
> Feature                ALL  ILK  SNB  BYT  IVB  HSW  BDW  BSW  SKL
> display - atomic         0    0    1    0    0    0    1    0    0
> display - audio          0    0    0    0    0    0    0    0    0
> display - DP             0    0    1    0    1    0    1    0    0
> display - DP MST         0    0    0    0    0    0    0    0    0
> display - DSI            0    0    0    0    0    0    0    0    0
> display - eDP            0    0    0    0    0    0    0    0    0
> display - fastboot       0    0    0    0    0    0    0    0    0

Fastboot is very soonish no more (Maarten has patches to move it all into
normal modeset code). I'd drop it.

The other missing bit is all the plane stuff, color manager and similar.
Otoh this is new, so not clear yet what kind of bugs will be common. Imo
better to wait and then maybe add more categories.

> display - FBC            0    0    0    0    0    0    0    0    0
> display - HDMI           0    0    0    0    0    0    0    0    0
> display - IPS            0    0    0    0    0    0    0    0    0
> display - LVDS           0    0    0    0    0    0    0    0    0
> display - PSR            0    0    0    0    0    0    0    0    0
> display - Other          0    0    0    0    0    0    0    0    0
> GEM - execlists          0    0    0    0    0    0    0    0    0
> GEM - PPGTT              0    0    0    0    0    0    0    0    0
> GEM - Other              1    0    0    0    0    0    1    0    0

GEM - gpu hang

blows up all the time. And we need a bucket to catch all the userspace
hangs which are reported against the kernel.

> power - RC6              0    0    0    1    0    0    0    0    0
> power - RCS              0    0    0    0    0    0    0    0    0

RPS is turbo stuff, and it's tightly coupled with rc6. Maybe instead just

power - GT

for all the GT related power saving features?

I'd also add

power - runtime PM

and 

power - suspend/resume

here. Tons of stuff blows up here.

> power - Other            0    0    0    0    0    0    0    0    0
> 
> 
> So I would like to hear what other people think about this. Specially,
> about what should be in the features field. The values can change
> overtime, but would be good to have a good list from the start. The
> values above are an incomplete list I threw together while looking at
> different open bugs.

Maybe we need a bit more polish, but probably not worth it to spend too
much time on the exact feature list. If we spot serious gaps we can always
add more. And remove old ones which have gone out of favour (having that
script handy somewhere would be good).
-Daniel

> 
> Thanks,
> Ander




> import bugzilla
> import collections
> 
> bugzilla_url = "http://192.168.100.244/bugzilla/xmlrpc.cgi"
> 
> closed_states = ['RESOLVED', 'VERIFIED', 'CLOSED']
> open_states = ["REOPENED", "NEEDINFO", "NEW", "ASSIGNED"]
> 
> def get_custom_fields_allowed_values(bz):
> 	fields = ['cf_i915_platform', 'cf_i915_features']
> 	r =  bz._proxy.Bug.fields({'names': fields,
> 				   'include_fields': ['values']})
> 
> 	list_of_raw_values = [f['values'] for f in r['fields']]
> 	values = [[v['name'] for v in f] for f in list_of_raw_values]
> 
> 	assert len(values) == len(fields)
> 	return dict(zip(fields, values))
> 
> def get_drm_intel_bugs(bz):
> 	query = bz.build_query(product="DRI", component="DRM/Intel",
> 			       status=open_states)
> 	return bz.query(query)
> 
> def split_bugs_per_field(bz, bugs, field):
> 	split = collections.OrderedDict()
> 
> 	allowed_values = get_custom_fields_allowed_values(bz)
> 	for v in allowed_values[field]:
> 		split[v] = []
> 
> 	for bug in bugs:
> 		if field in bug.__dict__:
> 			for value in bug.__dict__[field]:
> 				split[value].append(bug)
> 
> 	return split
> 
> def intersect_lists(list1, list2):
> 	return [v for v in list1 if v in list2]
> 
> def stringfy_list(l, spacing=5):
> 	return ''.join([s.rjust(spacing) for s in map(str, l)])
> 
> if __name__ == "__main__":
> 	bz = bugzilla.Bugzilla(url=bugzilla_url)
> 
> 	bugs = get_drm_intel_bugs(bz)
> 
> 	per_platform = split_bugs_per_field(bz, bugs, 'cf_i915_platform')
> 	per_feature = split_bugs_per_field(bz, bugs, 'cf_i915_features')
> 
> 	print "Feature".ljust(20), stringfy_list(per_platform)
> 
> 	for feature in per_feature:
> 		common_count = []
> 		for platform in per_platform:
> 			common = intersect_lists(per_feature[feature],
> 						 per_platform[platform])
> 			common_count.append(len(common))
> 
> 		print feature.ljust(20), stringfy_list(common_count)
> 

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 17:05 ` Daniel Vetter
@ 2015-06-26 17:23   ` Chris Wilson
  2015-06-26 17:34     ` Daniel Vetter
  2015-06-29  7:42     ` Jani Nikula
  2015-06-29  8:50   ` Ander Conselvan De Oliveira
  1 sibling, 2 replies; 24+ messages in thread
From: Chris Wilson @ 2015-06-26 17:23 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Fri, Jun 26, 2015 at 07:05:20PM +0200, Daniel Vetter wrote:
> Maybe we need a bit more polish, but probably not worth it to spend too
> much time on the exact feature list. If we spot serious gaps we can always
> add more. And remove old ones which have gone out of favour (having that
> script handy somewhere would be good).

That's the big one where just being strict about using summary keywords
pays off - flexibility. From pov, I like the summary keywords as that is
shown in the search window - so if custom fields are introduced, I want
them visible in the results list.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 17:23   ` Chris Wilson
@ 2015-06-26 17:34     ` Daniel Vetter
  2015-06-29  7:42     ` Jani Nikula
  1 sibling, 0 replies; 24+ messages in thread
From: Daniel Vetter @ 2015-06-26 17:34 UTC (permalink / raw)
  To: Chris Wilson, Daniel Vetter, Ander Conselvan De Oliveira,
	intel-gfx

On Fri, Jun 26, 2015 at 06:23:39PM +0100, Chris Wilson wrote:
> On Fri, Jun 26, 2015 at 07:05:20PM +0200, Daniel Vetter wrote:
> > Maybe we need a bit more polish, but probably not worth it to spend too
> > much time on the exact feature list. If we spot serious gaps we can always
> > add more. And remove old ones which have gone out of favour (having that
> > script handy somewhere would be good).
> 
> That's the big one where just being strict about using summary keywords
> pays off - flexibility. From pov, I like the summary keywords as that is
> shown in the search window - so if custom fields are introduced, I want
> them visible in the results list.

Yeah visibility in search results was my big concern too. That's why I
asked Ander to merge the 3 areas into one, since otherwise the search
result page looks super wasteful. It can be shown by just adding more
default fields.

Flexibility is another one, but the problem we have with rotating
different people through bug duty is that without a list we don't have
that consistency - heck even QA engineers fail to be consistent with
platform tags.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 17:23   ` Chris Wilson
  2015-06-26 17:34     ` Daniel Vetter
@ 2015-06-29  7:42     ` Jani Nikula
  1 sibling, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2015-06-29  7:42 UTC (permalink / raw)
  To: Chris Wilson, Daniel Vetter; +Cc: intel-gfx

On Fri, 26 Jun 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Jun 26, 2015 at 07:05:20PM +0200, Daniel Vetter wrote:
>> Maybe we need a bit more polish, but probably not worth it to spend too
>> much time on the exact feature list. If we spot serious gaps we can always
>> add more. And remove old ones which have gone out of favour (having that
>> script handy somewhere would be good).
>
> That's the big one where just being strict about using summary keywords
> pays off - flexibility. From pov, I like the summary keywords as that is
> shown in the search window - so if custom fields are introduced, I want
> them visible in the results list.

You'll be able to add these to the search results list using the "change
columns" link at the bottom.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 17:05 ` Daniel Vetter
  2015-06-26 17:23   ` Chris Wilson
@ 2015-06-29  8:50   ` Ander Conselvan De Oliveira
  2015-06-29 10:19     ` Ville Syrjälä
  1 sibling, 1 reply; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-29  8:50 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Fri, 2015-06-26 at 19:05 +0200, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 06:28:39PM +0300, Ander Conselvan De Oliveira wrote:
> > Hi all,
> > 
> > I've been looking into creating custom fields in Bugzilla to help sort
> > our bugs in a more manageable way. I did some testing in a private
> > installation and came up with this proposal. In a nut shell, we would
> > add the following two fields:
> > 
> > 	i915 platform:	list of platforms affected by a bug;
> > 	i915 features:  list of features affected by a bug.
> > 
> > Both would be multiple selection fields. The accepted values would be
> > configured in the Bugzilla installation. The attached screenshots show
> > how this would look like in the bug view and bug list views.
> > 
> > My expectation is that using those fields we could have a clearer view
> > of which areas and/or platforms require more attention. For example, I
> > attached a screenshot of a sample report breaking down the bugs per
> > feature and platform. That report requires Bugzilla 5.0 (which hasn't
> > been released yet) since prior versions didn't support reports with
> > multiple selection fields. However, it is also possible to script a
> > similar report, as the attached python script does. The output looks
> > something like this:
> > 
> > Feature                ALL  ILK  SNB  BYT  IVB  HSW  BDW  BSW  SKL
> > display - atomic         0    0    1    0    0    0    1    0    0
> > display - audio          0    0    0    0    0    0    0    0    0
> > display - DP             0    0    1    0    1    0    1    0    0
> > display - DP MST         0    0    0    0    0    0    0    0    0
> > display - DSI            0    0    0    0    0    0    0    0    0
> > display - eDP            0    0    0    0    0    0    0    0    0
> > display - fastboot       0    0    0    0    0    0    0    0    0
> 
> Fastboot is very soonish no more (Maarten has patches to move it all into
> normal modeset code). I'd drop it.
> 
> The other missing bit is all the plane stuff, color manager and similar.
> Otoh this is new, so not clear yet what kind of bugs will be common. Imo
> better to wait and then maybe add more categories.
> 
> > display - FBC            0    0    0    0    0    0    0    0    0
> > display - HDMI           0    0    0    0    0    0    0    0    0
> > display - IPS            0    0    0    0    0    0    0    0    0
> > display - LVDS           0    0    0    0    0    0    0    0    0
> > display - PSR            0    0    0    0    0    0    0    0    0
> > display - Other          0    0    0    0    0    0    0    0    0
> > GEM - execlists          0    0    0    0    0    0    0    0    0
> > GEM - PPGTT              0    0    0    0    0    0    0    0    0
> > GEM - Other              1    0    0    0    0    0    1    0    0
> 
> GEM - gpu hang
> 
> blows up all the time. And we need a bucket to catch all the userspace
> hangs which are reported against the kernel.
> 
> > power - RC6              0    0    0    1    0    0    0    0    0
> > power - RCS              0    0    0    0    0    0    0    0    0
> 
> RPS is turbo stuff, and it's tightly coupled with rc6. Maybe instead just
> 
> power - GT
> 
> for all the GT related power saving features?
> 
> I'd also add
> 
> power - runtime PM
> 
> and 
> 
> power - suspend/resume
> 
> here. Tons of stuff blows up here.
> 
> > power - Other            0    0    0    0    0    0    0    0    0
> > 
> > 
> > So I would like to hear what other people think about this. Specially,
> > about what should be in the features field. The values can change
> > overtime, but would be good to have a good list from the start. The
> > values above are an incomplete list I threw together while looking at
> > different open bugs.
> 
> Maybe we need a bit more polish, but probably not worth it to spend too
> much time on the exact feature list. If we spot serious gaps we can always
> add more. And remove old ones which have gone out of favour 

Here's what I got so far, after updating with your suggestions.

i915 platform:

ALL
SKL
BXT
BDW
BSW
HSW
IVB
BYT
SNB
ILK
I965G
I965GM
G45
GM45
PNV
G33
I945G
I945GM
I915G
I915GM
I865G
I85X
I845G
I830

i915 features:

display - atomic 
display - audio 
display - DP 
display - DP MST 
display - DSI 
display - eDP 
display - FBC 
display - HDMI 
display - IPS 
display - LVDS 
display - PSR 
display - Other 
GEM - execlists 
GEM - PPGTT 
GEM - GPU hang
GEM - Other 
power - GT
power - runtime PM
power - suspend/resume 
power - Other 


> (having that script handy somewhere would be good).

It would be good to have a repository we can dump these to. Or at least
a branch in i-g-t.

Ander



> -Daniel
> 
> > 
> > Thanks,
> > Ander
> 
> 
> 
> 
> > import bugzilla
> > import collections
> > 
> > bugzilla_url = "http://192.168.100.244/bugzilla/xmlrpc.cgi"
> > 
> > closed_states = ['RESOLVED', 'VERIFIED', 'CLOSED']
> > open_states = ["REOPENED", "NEEDINFO", "NEW", "ASSIGNED"]
> > 
> > def get_custom_fields_allowed_values(bz):
> > 	fields = ['cf_i915_platform', 'cf_i915_features']
> > 	r =  bz._proxy.Bug.fields({'names': fields,
> > 				   'include_fields': ['values']})
> > 
> > 	list_of_raw_values = [f['values'] for f in r['fields']]
> > 	values = [[v['name'] for v in f] for f in list_of_raw_values]
> > 
> > 	assert len(values) == len(fields)
> > 	return dict(zip(fields, values))
> > 
> > def get_drm_intel_bugs(bz):
> > 	query = bz.build_query(product="DRI", component="DRM/Intel",
> > 			       status=open_states)
> > 	return bz.query(query)
> > 
> > def split_bugs_per_field(bz, bugs, field):
> > 	split = collections.OrderedDict()
> > 
> > 	allowed_values = get_custom_fields_allowed_values(bz)
> > 	for v in allowed_values[field]:
> > 		split[v] = []
> > 
> > 	for bug in bugs:
> > 		if field in bug.__dict__:
> > 			for value in bug.__dict__[field]:
> > 				split[value].append(bug)
> > 
> > 	return split
> > 
> > def intersect_lists(list1, list2):
> > 	return [v for v in list1 if v in list2]
> > 
> > def stringfy_list(l, spacing=5):
> > 	return ''.join([s.rjust(spacing) for s in map(str, l)])
> > 
> > if __name__ == "__main__":
> > 	bz = bugzilla.Bugzilla(url=bugzilla_url)
> > 
> > 	bugs = get_drm_intel_bugs(bz)
> > 
> > 	per_platform = split_bugs_per_field(bz, bugs, 'cf_i915_platform')
> > 	per_feature = split_bugs_per_field(bz, bugs, 'cf_i915_features')
> > 
> > 	print "Feature".ljust(20), stringfy_list(per_platform)
> > 
> > 	for feature in per_feature:
> > 		common_count = []
> > 		for platform in per_platform:
> > 			common = intersect_lists(per_feature[feature],
> > 						 per_platform[platform])
> > 			common_count.append(len(common))
> > 
> > 		print feature.ljust(20), stringfy_list(common_count)
> > 
> 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29  8:50   ` Ander Conselvan De Oliveira
@ 2015-06-29 10:19     ` Ville Syrjälä
  2015-06-29 10:26       ` Ville Syrjälä
  0 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjälä @ 2015-06-29 10:19 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira; +Cc: intel-gfx

On Mon, Jun 29, 2015 at 11:50:23AM +0300, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-06-26 at 19:05 +0200, Daniel Vetter wrote:
> > On Fri, Jun 26, 2015 at 06:28:39PM +0300, Ander Conselvan De Oliveira wrote:
> > > Hi all,
> > > 
> > > I've been looking into creating custom fields in Bugzilla to help sort
> > > our bugs in a more manageable way. I did some testing in a private
> > > installation and came up with this proposal. In a nut shell, we would
> > > add the following two fields:
> > > 
> > > 	i915 platform:	list of platforms affected by a bug;
> > > 	i915 features:  list of features affected by a bug.
> > > 
> > > Both would be multiple selection fields. The accepted values would be
> > > configured in the Bugzilla installation. The attached screenshots show
> > > how this would look like in the bug view and bug list views.
> > > 
> > > My expectation is that using those fields we could have a clearer view
> > > of which areas and/or platforms require more attention. For example, I
> > > attached a screenshot of a sample report breaking down the bugs per
> > > feature and platform. That report requires Bugzilla 5.0 (which hasn't
> > > been released yet) since prior versions didn't support reports with
> > > multiple selection fields. However, it is also possible to script a
> > > similar report, as the attached python script does. The output looks
> > > something like this:
> > > 
> > > Feature                ALL  ILK  SNB  BYT  IVB  HSW  BDW  BSW  SKL
> > > display - atomic         0    0    1    0    0    0    1    0    0
> > > display - audio          0    0    0    0    0    0    0    0    0
> > > display - DP             0    0    1    0    1    0    1    0    0
> > > display - DP MST         0    0    0    0    0    0    0    0    0
> > > display - DSI            0    0    0    0    0    0    0    0    0
> > > display - eDP            0    0    0    0    0    0    0    0    0
> > > display - fastboot       0    0    0    0    0    0    0    0    0
> > 
> > Fastboot is very soonish no more (Maarten has patches to move it all into
> > normal modeset code). I'd drop it.
> > 
> > The other missing bit is all the plane stuff, color manager and similar.
> > Otoh this is new, so not clear yet what kind of bugs will be common. Imo
> > better to wait and then maybe add more categories.
> > 
> > > display - FBC            0    0    0    0    0    0    0    0    0
> > > display - HDMI           0    0    0    0    0    0    0    0    0
> > > display - IPS            0    0    0    0    0    0    0    0    0
> > > display - LVDS           0    0    0    0    0    0    0    0    0
> > > display - PSR            0    0    0    0    0    0    0    0    0
> > > display - Other          0    0    0    0    0    0    0    0    0
> > > GEM - execlists          0    0    0    0    0    0    0    0    0
> > > GEM - PPGTT              0    0    0    0    0    0    0    0    0
> > > GEM - Other              1    0    0    0    0    0    1    0    0
> > 
> > GEM - gpu hang
> > 
> > blows up all the time. And we need a bucket to catch all the userspace
> > hangs which are reported against the kernel.
> > 
> > > power - RC6              0    0    0    1    0    0    0    0    0
> > > power - RCS              0    0    0    0    0    0    0    0    0
> > 
> > RPS is turbo stuff, and it's tightly coupled with rc6. Maybe instead just
> > 
> > power - GT
> > 
> > for all the GT related power saving features?
> > 
> > I'd also add
> > 
> > power - runtime PM
> > 
> > and 
> > 
> > power - suspend/resume
> > 
> > here. Tons of stuff blows up here.
> > 
> > > power - Other            0    0    0    0    0    0    0    0    0
> > > 
> > > 
> > > So I would like to hear what other people think about this. Specially,
> > > about what should be in the features field. The values can change
> > > overtime, but would be good to have a good list from the start. The
> > > values above are an incomplete list I threw together while looking at
> > > different open bugs.
> > 
> > Maybe we need a bit more polish, but probably not worth it to spend too
> > much time on the exact feature list. If we spot serious gaps we can always
> > add more. And remove old ones which have gone out of favour 
> 
> Here's what I got so far, after updating with your suggestions.
> 
> i915 platform:
> 
> ALL
> SKL
> BXT
> BDW
> BSW

CHV

> HSW
> IVB
> BYT

VLV

> SNB
> ILK
> I965G
> I965GM
> G45
> GM45
> PNV
> G33
> I945G
> I945GM
> I915G
> I915GM
> I865G
> I85X
> I845G
> I830

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 10:19     ` Ville Syrjälä
@ 2015-06-29 10:26       ` Ville Syrjälä
  2015-06-29 11:20         ` Ander Conselvan De Oliveira
  0 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjälä @ 2015-06-29 10:26 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira; +Cc: intel-gfx

On Mon, Jun 29, 2015 at 01:19:05PM +0300, Ville Syrjälä wrote:
> On Mon, Jun 29, 2015 at 11:50:23AM +0300, Ander Conselvan De Oliveira wrote:
> > On Fri, 2015-06-26 at 19:05 +0200, Daniel Vetter wrote:
> > > On Fri, Jun 26, 2015 at 06:28:39PM +0300, Ander Conselvan De Oliveira wrote:
> > > > Hi all,
> > > > 
> > > > I've been looking into creating custom fields in Bugzilla to help sort
> > > > our bugs in a more manageable way. I did some testing in a private
> > > > installation and came up with this proposal. In a nut shell, we would
> > > > add the following two fields:
> > > > 
> > > > 	i915 platform:	list of platforms affected by a bug;
> > > > 	i915 features:  list of features affected by a bug.
> > > > 
> > > > Both would be multiple selection fields. The accepted values would be
> > > > configured in the Bugzilla installation. The attached screenshots show
> > > > how this would look like in the bug view and bug list views.
> > > > 
> > > > My expectation is that using those fields we could have a clearer view
> > > > of which areas and/or platforms require more attention. For example, I
> > > > attached a screenshot of a sample report breaking down the bugs per
> > > > feature and platform. That report requires Bugzilla 5.0 (which hasn't
> > > > been released yet) since prior versions didn't support reports with
> > > > multiple selection fields. However, it is also possible to script a
> > > > similar report, as the attached python script does. The output looks
> > > > something like this:
> > > > 
> > > > Feature                ALL  ILK  SNB  BYT  IVB  HSW  BDW  BSW  SKL
> > > > display - atomic         0    0    1    0    0    0    1    0    0
> > > > display - audio          0    0    0    0    0    0    0    0    0
> > > > display - DP             0    0    1    0    1    0    1    0    0
> > > > display - DP MST         0    0    0    0    0    0    0    0    0
> > > > display - DSI            0    0    0    0    0    0    0    0    0
> > > > display - eDP            0    0    0    0    0    0    0    0    0
> > > > display - fastboot       0    0    0    0    0    0    0    0    0
> > > 
> > > Fastboot is very soonish no more (Maarten has patches to move it all into
> > > normal modeset code). I'd drop it.
> > > 
> > > The other missing bit is all the plane stuff, color manager and similar.
> > > Otoh this is new, so not clear yet what kind of bugs will be common. Imo
> > > better to wait and then maybe add more categories.
> > > 
> > > > display - FBC            0    0    0    0    0    0    0    0    0
> > > > display - HDMI           0    0    0    0    0    0    0    0    0
> > > > display - IPS            0    0    0    0    0    0    0    0    0
> > > > display - LVDS           0    0    0    0    0    0    0    0    0
> > > > display - PSR            0    0    0    0    0    0    0    0    0
> > > > display - Other          0    0    0    0    0    0    0    0    0
> > > > GEM - execlists          0    0    0    0    0    0    0    0    0
> > > > GEM - PPGTT              0    0    0    0    0    0    0    0    0
> > > > GEM - Other              1    0    0    0    0    0    1    0    0
> > > 
> > > GEM - gpu hang
> > > 
> > > blows up all the time. And we need a bucket to catch all the userspace
> > > hangs which are reported against the kernel.
> > > 
> > > > power - RC6              0    0    0    1    0    0    0    0    0
> > > > power - RCS              0    0    0    0    0    0    0    0    0
> > > 
> > > RPS is turbo stuff, and it's tightly coupled with rc6. Maybe instead just
> > > 
> > > power - GT
> > > 
> > > for all the GT related power saving features?
> > > 
> > > I'd also add
> > > 
> > > power - runtime PM
> > > 
> > > and 
> > > 
> > > power - suspend/resume
> > > 
> > > here. Tons of stuff blows up here.
> > > 
> > > > power - Other            0    0    0    0    0    0    0    0    0
> > > > 
> > > > 
> > > > So I would like to hear what other people think about this. Specially,
> > > > about what should be in the features field. The values can change
> > > > overtime, but would be good to have a good list from the start. The
> > > > values above are an incomplete list I threw together while looking at
> > > > different open bugs.
> > > 
> > > Maybe we need a bit more polish, but probably not worth it to spend too
> > > much time on the exact feature list. If we spot serious gaps we can always
> > > add more. And remove old ones which have gone out of favour 
> > 
> > Here's what I got so far, after updating with your suggestions.
> > 
> > i915 platform:
> > 
> > ALL
> > SKL
> > BXT
> > BDW
> > BSW
> 
> CHV

Or alternatively add CHT, in which case BSW and BYT could make sense.

> 
> > HSW
> > IVB
> > BYT
> 
> VLV
> 
> > SNB
> > ILK
> > I965G
> > I965GM
> > G45
> > GM45
> > PNV
> > G33
> > I945G
> > I945GM
> > I915G
> > I915GM
> > I865G
> > I85X
> > I845G
> > I830
> 
> -- 
> Ville Syrjälä
> Intel OTC

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 10:26       ` Ville Syrjälä
@ 2015-06-29 11:20         ` Ander Conselvan De Oliveira
  0 siblings, 0 replies; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-29 11:20 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Mon, 2015-06-29 at 13:26 +0300, Ville Syrjälä wrote:
> On Mon, Jun 29, 2015 at 01:19:05PM +0300, Ville Syrjälä wrote:
> > On Mon, Jun 29, 2015 at 11:50:23AM +0300, Ander Conselvan De Oliveira wrote:
> > > Here's what I got so far, after updating with your suggestions.
> > > 
> > > i915 platform:
> > > 
> > > ALL
> > > SKL
> > > BXT
> > > BDW
> > > BSW
> > 
> > CHV
> 
> Or alternatively add CHT, in which case BSW and BYT could make sense.

For the record, I  had a quick chat with Ville and updated the "BSW"
entry to "BSW/CHT".

Ander


> 
> > 
> > > HSW
> > > IVB
> > > BYT
> > 
> > VLV
> > 
> > > SNB
> > > ILK
> > > I965G
> > > I965GM
> > > G45
> > > GM45
> > > PNV
> > > G33
> > > I945G
> > > I945GM
> > > I915G
> > > I915GM
> > > I865G
> > > I85X
> > > I845G
> > > I830
> > 
> > -- 
> > Ville Syrjälä
> > Intel OTC
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-26 15:28 Adding custom bugzilla fields Ander Conselvan De Oliveira
  2015-06-26 17:05 ` Daniel Vetter
@ 2015-06-29 11:31 ` Ander Conselvan De Oliveira
  2015-06-29 11:34   ` Chris Wilson
                     ` (3 more replies)
  1 sibling, 4 replies; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-29 11:31 UTC (permalink / raw)
  To: intel-gfx

On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> Hi all,
> 
> I've been looking into creating custom fields in Bugzilla to help sort
> our bugs in a more manageable way.

[...]

> So I would like to hear what other people think about this. Specially,
> about what should be in the features field. The values can change
> overtime, but would be good to have a good list from the start.

So here's the list after including Daniel's and Ville's feedback. If
there's no more suggestions/objections, I'd like to create those fields
already tomorrow. We can edit the list entries afterwards if needed.

i915 platform:

ALL
SKL
BXT
BDW
BSW/CHT
HSW
IVB
BYT
SNB
ILK
I965G
I965GM
G45
GM45
PNV
G33
I945G
I945GM
I915G
I915GM
I865G
I85X
I845G
I830

i915 features:

display - atomic 
display - audio 
display - DP 
display - DP MST 
display - DSI 
display - eDP 
display - FBC 
display - HDMI 
display - IPS 
display - LVDS 
display - PSR 
display - Other 
GEM - execlists 
GEM - PPGTT 
GEM - GPU hang
GEM - Other 
power - GT
power - runtime PM
power - suspend/resume 
power - Other 


Thanks,
Ander

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
@ 2015-06-29 11:34   ` Chris Wilson
  2015-06-29 11:46     ` Ander Conselvan De Oliveira
  2015-06-29 11:47   ` Jani Nikula
                     ` (2 subsequent siblings)
  3 siblings, 1 reply; 24+ messages in thread
From: Chris Wilson @ 2015-06-29 11:34 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira; +Cc: intel-gfx

On Mon, Jun 29, 2015 at 02:31:22PM +0300, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> > Hi all,
> > 
> > I've been looking into creating custom fields in Bugzilla to help sort
> > our bugs in a more manageable way.
> 
> [...]
> 
> > So I would like to hear what other people think about this. Specially,
> > about what should be in the features field. The values can change
> > overtime, but would be good to have a good list from the start.
> 
> So here's the list after including Daniel's and Ville's feedback. If
> there's no more suggestions/objections, I'd like to create those fields
> already tomorrow. We can edit the list entries afterwards if needed.
> 
> i915 platform:
> 
> ALL
> SKL
> BXT
> BDW
> BSW/CHT
> HSW
> IVB
> BYT
> SNB
> ILK
> I965G
> I965GM
> G45
> GM45
> PNV
> G33
> I945G
> I945GM
> I915G
> I915GM
> I865G
> I85X
> I845G
> I830
> 
> i915 features:
> 
> display - atomic 
> display - audio 
> display - DP 
> display - DP MST 
> display - DSI 
> display - eDP 
> display - FBC 
> display - HDMI 
> display - IPS 
> display - LVDS 
> display - PSR 
> display - Other 
> GEM - execlists 
> GEM - PPGTT 
> GEM - GPU hang

GPU hang's are their own top level category. They can be anything from
hardware failure, display faults, driver bugs and last but not least,
userspace.

Presumably we can select multiple fields for bugs?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:34   ` Chris Wilson
@ 2015-06-29 11:46     ` Ander Conselvan De Oliveira
  0 siblings, 0 replies; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-29 11:46 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Mon, 2015-06-29 at 12:34 +0100, Chris Wilson wrote:
> On Mon, Jun 29, 2015 at 02:31:22PM +0300, Ander Conselvan De Oliveira wrote:
> > On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> > > Hi all,
> > > 
> > > I've been looking into creating custom fields in Bugzilla to help sort
> > > our bugs in a more manageable way.
> > 
> > [...]
> > 
> > > So I would like to hear what other people think about this. Specially,
> > > about what should be in the features field. The values can change
> > > overtime, but would be good to have a good list from the start.
> > 
> > So here's the list after including Daniel's and Ville's feedback. If
> > there's no more suggestions/objections, I'd like to create those fields
> > already tomorrow. We can edit the list entries afterwards if needed.
> > 
> > i915 platform:
> > 
> > ALL
> > SKL
> > BXT
> > BDW
> > BSW/CHT
> > HSW
> > IVB
> > BYT
> > SNB
> > ILK
> > I965G
> > I965GM
> > G45
> > GM45
> > PNV
> > G33
> > I945G
> > I945GM
> > I915G
> > I915GM
> > I865G
> > I85X
> > I845G
> > I830
> > 
> > i915 features:
> > 
> > display - atomic 
> > display - audio 
> > display - DP 
> > display - DP MST 
> > display - DSI 
> > display - eDP 
> > display - FBC 
> > display - HDMI 
> > display - IPS 
> > display - LVDS 
> > display - PSR 
> > display - Other 
> > GEM - execlists 
> > GEM - PPGTT 
> > GEM - GPU hang
> 
> GPU hang's are their own top level category. They can be anything from
> hardware failure, display faults, driver bugs and last but not least,
> userspace.
> 
> Presumably we can select multiple fields for bugs?

Yes, it's a multiple selection field.

> -Chris
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
  2015-06-29 11:34   ` Chris Wilson
@ 2015-06-29 11:47   ` Jani Nikula
  2015-06-29 11:59     ` Ander Conselvan De Oliveira
  2015-06-29 16:31   ` Daniel Vetter
  2015-06-30 12:14   ` Ander Conselvan De Oliveira
  3 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2015-06-29 11:47 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira, intel-gfx

On Mon, 29 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> i915 features:
>
> display - atomic 
> display - audio 
> display - DP 
> display - DP MST 
> display - DSI 
> display - eDP 
> display - FBC 
> display - HDMI 
> display - IPS 
> display - LVDS 
> display - PSR 
> display - Other 

*gasp* huge omissions, backlight and hotplug!

> GEM - execlists 
> GEM - PPGTT 
> GEM - GPU hang
> GEM - Other 
> power - GT
> power - runtime PM
> power - suspend/resume 
> power - Other

Bikeshedding, would it be worth changing s, - ,/, so that it gets
slightly more condensed int the search results?

What about perf?

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:47   ` Jani Nikula
@ 2015-06-29 11:59     ` Ander Conselvan De Oliveira
  0 siblings, 0 replies; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-29 11:59 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Mon, 2015-06-29 at 14:47 +0300, Jani Nikula wrote:
> On Mon, 29 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> > i915 features:
> >
> > display - atomic 
> > display - audio 
> > display - DP 
> > display - DP MST 
> > display - DSI 
> > display - eDP 
> > display - FBC 
> > display - HDMI 
> > display - IPS 
> > display - LVDS 
> > display - PSR 
> > display - Other 
> 
> *gasp* huge omissions, backlight and hotplug!

Added.


> > GEM - execlists 
> > GEM - PPGTT 
> > GEM - GPU hang
> > GEM - Other 
> > power - GT
> > power - runtime PM
> > power - suspend/resume 
> > power - Other
> 
> Bikeshedding, would it be worth changing s, - ,/, so that it gets
> slightly more condensed int the search results?

Yeah, it does indeed look better. 

> What about perf?

I haven't thought about that, but I can add a "performance" entry to the
list.

Ander


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
  2015-06-29 11:34   ` Chris Wilson
  2015-06-29 11:47   ` Jani Nikula
@ 2015-06-29 16:31   ` Daniel Vetter
  2015-06-29 20:11     ` Chris Wilson
  2015-06-30 12:14   ` Ander Conselvan De Oliveira
  3 siblings, 1 reply; 24+ messages in thread
From: Daniel Vetter @ 2015-06-29 16:31 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira; +Cc: intel-gfx

On Mon, Jun 29, 2015 at 02:31:22PM +0300, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> > Hi all,
> > 
> > I've been looking into creating custom fields in Bugzilla to help sort
> > our bugs in a more manageable way.
> 
> [...]
> 
> > So I would like to hear what other people think about this. Specially,
> > about what should be in the features field. The values can change
> > overtime, but would be good to have a good list from the start.
> 
> So here's the list after including Daniel's and Ville's feedback. If
> there's no more suggestions/objections, I'd like to create those fields
> already tomorrow. We can edit the list entries afterwards if needed.
> 
> i915 platform:
> 
> ALL
> SKL
> BXT
> BDW
> BSW/CHT
> HSW
> IVB
> BYT
> SNB
> ILK
> I965G
> I965GM
> G45
> GM45
> PNV
> G33
> I945G
> I945GM
> I915G
> I915GM
> I865G
> I85X
> I845G
> I830

I think we can condense the older platforms down a lot, maybe even just
GEN2, GEN3, GEN4. Or at least group desktop and mobile together, i.e.

I8XX, I915, I945, G33/PNV, I965, G4X (we put both under that tag usually).

I'd also vote to not split up platforms which are just tailored chips for
specific markets, e.g. chv/bsw is pretty much the same thing really from
the driver pov.
-Daniel

> 
> i915 features:
> 
> display - atomic 
> display - audio 
> display - DP 
> display - DP MST 
> display - DSI 
> display - eDP 
> display - FBC 
> display - HDMI 
> display - IPS 
> display - LVDS 
> display - PSR 
> display - Other 
> GEM - execlists 
> GEM - PPGTT 
> GEM - GPU hang
> GEM - Other 
> power - GT
> power - runtime PM
> power - suspend/resume 
> power - Other 
> 
> 
> Thanks,
> Ander
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 16:31   ` Daniel Vetter
@ 2015-06-29 20:11     ` Chris Wilson
  2015-06-30 10:05       ` Daniel Vetter
  0 siblings, 1 reply; 24+ messages in thread
From: Chris Wilson @ 2015-06-29 20:11 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Mon, Jun 29, 2015 at 06:31:16PM +0200, Daniel Vetter wrote:
> I think we can condense the older platforms down a lot, maybe even just
> GEN2, GEN3, GEN4. Or at least group desktop and mobile together, i.e.
> 
> I8XX, I915, I945, G33/PNV, I965, G4X (we put both under that tag usually).

I would actually vote for the opposite. We often find bugs that are GT
specific in modern chips, and each of the early gen have different
features sets and their own quirks.

So I would say split it by PCI ID, with human readable strings, both
codename (inc. target feature set, GT + ULT/ULX/Halo etc) and market name
(though given that 50% is just HD Graphics, very meh).

So long as can intelligently group based on the PCI ID, I think it will
be of benefit long term.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 20:11     ` Chris Wilson
@ 2015-06-30 10:05       ` Daniel Vetter
  2015-06-30 10:07         ` Chris Wilson
  0 siblings, 1 reply; 24+ messages in thread
From: Daniel Vetter @ 2015-06-30 10:05 UTC (permalink / raw)
  To: Chris Wilson, Daniel Vetter, Ander Conselvan De Oliveira,
	intel-gfx, Jani Nikula, Ville Syrjälä

On Mon, Jun 29, 2015 at 09:11:06PM +0100, Chris Wilson wrote:
> On Mon, Jun 29, 2015 at 06:31:16PM +0200, Daniel Vetter wrote:
> > I think we can condense the older platforms down a lot, maybe even just
> > GEN2, GEN3, GEN4. Or at least group desktop and mobile together, i.e.
> > 
> > I8XX, I915, I945, G33/PNV, I965, G4X (we put both under that tag usually).
> 
> I would actually vote for the opposite. We often find bugs that are GT
> specific in modern chips, and each of the early gen have different
> features sets and their own quirks.
> 
> So I would say split it by PCI ID, with human readable strings, both
> codename (inc. target feature set, GT + ULT/ULX/Halo etc) and market name
> (though given that 50% is just HD Graphics, very meh).
> 
> So long as can intelligently group based on the PCI ID, I think it will
> be of benefit long term.

Seems like that'll result in massive lists. And we can always denote
special-cases in the summary of the bug. Also maintaining all that
information accurately will be a pain and for many bugs it's not needed,
hence why I think a bit more coarseness would be good.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-30 10:05       ` Daniel Vetter
@ 2015-06-30 10:07         ` Chris Wilson
  2015-06-30 10:13           ` Chris Wilson
  0 siblings, 1 reply; 24+ messages in thread
From: Chris Wilson @ 2015-06-30 10:07 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Tue, Jun 30, 2015 at 12:05:58PM +0200, Daniel Vetter wrote:
> On Mon, Jun 29, 2015 at 09:11:06PM +0100, Chris Wilson wrote:
> > On Mon, Jun 29, 2015 at 06:31:16PM +0200, Daniel Vetter wrote:
> > > I think we can condense the older platforms down a lot, maybe even just
> > > GEN2, GEN3, GEN4. Or at least group desktop and mobile together, i.e.
> > > 
> > > I8XX, I915, I945, G33/PNV, I965, G4X (we put both under that tag usually).
> > 
> > I would actually vote for the opposite. We often find bugs that are GT
> > specific in modern chips, and each of the early gen have different
> > features sets and their own quirks.
> > 
> > So I would say split it by PCI ID, with human readable strings, both
> > codename (inc. target feature set, GT + ULT/ULX/Halo etc) and market name
> > (though given that 50% is just HD Graphics, very meh).
> > 
> > So long as can intelligently group based on the PCI ID, I think it will
> > be of benefit long term.
> 
> Seems like that'll result in massive lists. And we can always denote
> special-cases in the summary of the bug. Also maintaining all that
> information accurately will be a pain and for many bugs it's not needed,
> hence why I think a bit more coarseness would be good.

On the other hand, the more common task of working out which value
should be used is trivial (and it gets harder and harder to remember the
mappings over time, so make the computer do it!). I'm in favour of making
bug reporting and bug maintenance simple. I'm sure with a bit of perl
the bugzilla fields can be maintained directly from i915_pciids.h :-p
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-30 10:07         ` Chris Wilson
@ 2015-06-30 10:13           ` Chris Wilson
  0 siblings, 0 replies; 24+ messages in thread
From: Chris Wilson @ 2015-06-30 10:13 UTC (permalink / raw)
  To: Daniel Vetter, Ander Conselvan De Oliveira, intel-gfx,
	Jani Nikula, Ville Syrjälä

On Tue, Jun 30, 2015 at 11:07:40AM +0100, Chris Wilson wrote:
> On Tue, Jun 30, 2015 at 12:05:58PM +0200, Daniel Vetter wrote:
> > On Mon, Jun 29, 2015 at 09:11:06PM +0100, Chris Wilson wrote:
> > > On Mon, Jun 29, 2015 at 06:31:16PM +0200, Daniel Vetter wrote:
> > > > I think we can condense the older platforms down a lot, maybe even just
> > > > GEN2, GEN3, GEN4. Or at least group desktop and mobile together, i.e.
> > > > 
> > > > I8XX, I915, I945, G33/PNV, I965, G4X (we put both under that tag usually).
> > > 
> > > I would actually vote for the opposite. We often find bugs that are GT
> > > specific in modern chips, and each of the early gen have different
> > > features sets and their own quirks.
> > > 
> > > So I would say split it by PCI ID, with human readable strings, both
> > > codename (inc. target feature set, GT + ULT/ULX/Halo etc) and market name
> > > (though given that 50% is just HD Graphics, very meh).
> > > 
> > > So long as can intelligently group based on the PCI ID, I think it will
> > > be of benefit long term.
> > 
> > Seems like that'll result in massive lists. And we can always denote
> > special-cases in the summary of the bug. Also maintaining all that
> > information accurately will be a pain and for many bugs it's not needed,
> > hence why I think a bit more coarseness would be good.

Another addendum: Often those patterns are not apparent until we have
many reports, at which point we have to go back through all the
duplicates to look for patterns. Maintaining the field upfront would
make those patterns stand out much earlier.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-29 11:31 ` Ander Conselvan De Oliveira
                     ` (2 preceding siblings ...)
  2015-06-29 16:31   ` Daniel Vetter
@ 2015-06-30 12:14   ` Ander Conselvan De Oliveira
  2015-08-21  8:41     ` Jani Nikula
  3 siblings, 1 reply; 24+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-06-30 12:14 UTC (permalink / raw)
  To: intel-gfx

On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> > Hi all,
> > 
> > I've been looking into creating custom fields in Bugzilla to help sort
> > our bugs in a more manageable way.
> 
> [...]
> 
> > So I would like to hear what other people think about this. Specially,
> > about what should be in the features field. The values can change
> > overtime, but would be good to have a good list from the start.
> 
> So here's the list after including Daniel's and Ville's feedback. If
> there's no more suggestions/objections, I'd like to create those fields
> already tomorrow. We can edit the list entries afterwards if needed.

Thank you, everyone, for the input. The fields are now created.

Cheers,
Ander


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-06-30 12:14   ` Ander Conselvan De Oliveira
@ 2015-08-21  8:41     ` Jani Nikula
  2015-08-25 12:49       ` Daniel Vetter
  0 siblings, 1 reply; 24+ messages in thread
From: Jani Nikula @ 2015-08-21  8:41 UTC (permalink / raw)
  To: Ander Conselvan De Oliveira, intel-gfx

On Tue, 30 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
>> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
>> > Hi all,
>> > 
>> > I've been looking into creating custom fields in Bugzilla to help sort
>> > our bugs in a more manageable way.
>> 
>> [...]
>> 
>> > So I would like to hear what other people think about this. Specially,
>> > about what should be in the features field. The values can change
>> > overtime, but would be good to have a good list from the start.
>> 
>> So here's the list after including Daniel's and Ville's feedback. If
>> there's no more suggestions/objections, I'd like to create those fields
>> already tomorrow. We can edit the list entries afterwards if needed.
>
> Thank you, everyone, for the input. The fields are now created.

There are some additional feature fields that I've found might be
useful:

display/adapter (or display/dongle?)
display/hotplug
display/multi-gpu
GEM/prime (or GEM/dma-buf?)

other/IOMMU (or GEM/IOMMU?)
other/BIOS
other/module-reload (?)

performance?


BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-08-21  8:41     ` Jani Nikula
@ 2015-08-25 12:49       ` Daniel Vetter
  2015-08-25 15:20         ` Jani Nikula
  2015-08-28  6:50         ` Jani Nikula
  0 siblings, 2 replies; 24+ messages in thread
From: Daniel Vetter @ 2015-08-25 12:49 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Fri, Aug 21, 2015 at 11:41:45AM +0300, Jani Nikula wrote:
> On Tue, 30 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> > On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
> >> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> >> > Hi all,
> >> > 
> >> > I've been looking into creating custom fields in Bugzilla to help sort
> >> > our bugs in a more manageable way.
> >> 
> >> [...]
> >> 
> >> > So I would like to hear what other people think about this. Specially,
> >> > about what should be in the features field. The values can change
> >> > overtime, but would be good to have a good list from the start.
> >> 
> >> So here's the list after including Daniel's and Ville's feedback. If
> >> there's no more suggestions/objections, I'd like to create those fields
> >> already tomorrow. We can edit the list entries afterwards if needed.
> >
> > Thank you, everyone, for the input. The fields are now created.
> 
> There are some additional feature fields that I've found might be
> useful:
> 
> display/adapter (or display/dongle?)
display/DP?

> display/hotplug
tag it with relevant output port?

> display/multi-gpu
> GEM/prime (or GEM/dma-buf?)

Yeah this might be useful, but not sure how much we care.

> other/IOMMU (or GEM/IOMMU?)
> other/BIOS

Imo better to label with relevant feature that gets broken. And IOMMU
should always have dwmw on cc so he can escalate.

> other/module-reload (?)

This is BAT now and should never break ;-)

> performance?

Yeah this would be good I guess.

In general I'm vary of adding too many since it'll be hard to maintain.
Can you please join the bug scrub org mtg on Thu so we can discuss these?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-08-25 12:49       ` Daniel Vetter
@ 2015-08-25 15:20         ` Jani Nikula
  2015-08-28  6:50         ` Jani Nikula
  1 sibling, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2015-08-25 15:20 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Tue, 25 Aug 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Aug 21, 2015 at 11:41:45AM +0300, Jani Nikula wrote:
>> On Tue, 30 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
>> > On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
>> >> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
>> >> > Hi all,
>> >> > 
>> >> > I've been looking into creating custom fields in Bugzilla to help sort
>> >> > our bugs in a more manageable way.
>> >> 
>> >> [...]
>> >> 
>> >> > So I would like to hear what other people think about this. Specially,
>> >> > about what should be in the features field. The values can change
>> >> > overtime, but would be good to have a good list from the start.
>> >> 
>> >> So here's the list after including Daniel's and Ville's feedback. If
>> >> there's no more suggestions/objections, I'd like to create those fields
>> >> already tomorrow. We can edit the list entries afterwards if needed.
>> >
>> > Thank you, everyone, for the input. The fields are now created.
>> 
>> There are some additional feature fields that I've found might be
>> useful:
>> 
>> display/adapter (or display/dongle?)
> display/DP?
>
>> display/hotplug
> tag it with relevant output port?
>
>> display/multi-gpu
>> GEM/prime (or GEM/dma-buf?)
>
> Yeah this might be useful, but not sure how much we care.
>
>> other/IOMMU (or GEM/IOMMU?)
>> other/BIOS
>
> Imo better to label with relevant feature that gets broken. And IOMMU
> should always have dwmw on cc so he can escalate.
>
>> other/module-reload (?)
>
> This is BAT now and should never break ;-)
>
>> performance?
>
> Yeah this would be good I guess.
>
> In general I'm vary of adding too many since it'll be hard to maintain.

All of these spun from a few sessions of actually trying to tag the bugs
that were/are still missing the tags.

> Can you please join the bug scrub org mtg on Thu so we can discuss these?

Ok.

Jani.


>
> Thanks, Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: Adding custom bugzilla fields
  2015-08-25 12:49       ` Daniel Vetter
  2015-08-25 15:20         ` Jani Nikula
@ 2015-08-28  6:50         ` Jani Nikula
  1 sibling, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2015-08-28  6:50 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Tue, 25 Aug 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Aug 21, 2015 at 11:41:45AM +0300, Jani Nikula wrote:
>> On Tue, 30 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
>> > On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
>> >> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
>> >> > Hi all,
>> >> > 
>> >> > I've been looking into creating custom fields in Bugzilla to help sort
>> >> > our bugs in a more manageable way.
>> >> 
>> >> [...]
>> >> 
>> >> > So I would like to hear what other people think about this. Specially,
>> >> > about what should be in the features field. The values can change
>> >> > overtime, but would be good to have a good list from the start.
>> >> 
>> >> So here's the list after including Daniel's and Ville's feedback. If
>> >> there's no more suggestions/objections, I'd like to create those fields
>> >> already tomorrow. We can edit the list entries afterwards if needed.
>> >
>> > Thank you, everyone, for the input. The fields are now created.
>> 
>> There are some additional feature fields that I've found might be
>> useful:

The discussion yesterday never materialized, so I'll reply here.

>> display/adapter (or display/dongle?)
> display/DP?

This does not answer the question "I want to see all our adapter bugs".

>> display/hotplug
> tag it with relevant output port?

This does not answer the question "I want to see all our hotplug bugs".

>> display/multi-gpu
>> GEM/prime (or GEM/dma-buf?)
>
> Yeah this might be useful, but not sure how much we care.

I might continue like above, because it's useful for finding dupes, but
also it's nice to flag bugs we're not sure how much we care. If they end
up being flagged, say, DP because gpu switching affects that, it's still
a useful distinction to know it's not your average DP bug.

>> other/IOMMU (or GEM/IOMMU?)
>> other/BIOS
>
> Imo better to label with relevant feature that gets broken.

This does not answer the question "I want to see all our bugs related to
VBT/BIOS screwups".

> And IOMMU should always have dwmw on cc so he can escalate.

That is totally irrelevant to the discussion about fields.

>> other/module-reload (?)
>
> This is BAT now and should never break ;-)

Fine.

>> performance?
>
> Yeah this would be good I guess.
>
> In general I'm vary of adding too many since it'll be hard to maintain.

Don't worry, we can remove them too.

> Can you please join the bug scrub org mtg on Thu so we can discuss these?
>
> Thanks, Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2015-08-28  6:47 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 15:28 Adding custom bugzilla fields Ander Conselvan De Oliveira
2015-06-26 17:05 ` Daniel Vetter
2015-06-26 17:23   ` Chris Wilson
2015-06-26 17:34     ` Daniel Vetter
2015-06-29  7:42     ` Jani Nikula
2015-06-29  8:50   ` Ander Conselvan De Oliveira
2015-06-29 10:19     ` Ville Syrjälä
2015-06-29 10:26       ` Ville Syrjälä
2015-06-29 11:20         ` Ander Conselvan De Oliveira
2015-06-29 11:31 ` Ander Conselvan De Oliveira
2015-06-29 11:34   ` Chris Wilson
2015-06-29 11:46     ` Ander Conselvan De Oliveira
2015-06-29 11:47   ` Jani Nikula
2015-06-29 11:59     ` Ander Conselvan De Oliveira
2015-06-29 16:31   ` Daniel Vetter
2015-06-29 20:11     ` Chris Wilson
2015-06-30 10:05       ` Daniel Vetter
2015-06-30 10:07         ` Chris Wilson
2015-06-30 10:13           ` Chris Wilson
2015-06-30 12:14   ` Ander Conselvan De Oliveira
2015-08-21  8:41     ` Jani Nikula
2015-08-25 12:49       ` Daniel Vetter
2015-08-25 15:20         ` Jani Nikula
2015-08-28  6:50         ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).