Re: [PATCH 02/17] drm/i915: Move vma vfuns to adddress_space

Mika Kuoppala
2015-04-16T06:18:57Z

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Tue, Apr 14, 2015 at 05:35:12PM +0200, Daniel Vetter wrote:
>> They change with the address space and not with each vma, so move them
>> into the right pile of vfuncs. Save 2 pointers per vma and clarifies
>> the code.
>
> Using per-vma vfunc allows you make, for example, the pagetables
> themselves an ordinary vma in the GGTT and so operate identically wrt
> to

Page tables don't need to be in ggtt. Is this comment about
eviction of page directories (for gen < 8)?

Thanks,
-Mika

> the shrinker and eviction logic - removing some very fragile code in the
> process.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx