Re: [PATCH 02/17] drm/i915: Move vma vfuns to adddress_space

Chris Wilson
2015-04-16T07:39:29Z

On Thu, Apr 16, 2015 at 09:18:48AM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > On Tue, Apr 14, 2015 at 05:35:12PM +0200, Daniel Vetter wrote:
> >> They change with the address space and not with each vma, so move them
> >> into the right pile of vfuncs. Save 2 pointers per vma and clarifies
> >> the code.
> >
> > Using per-vma vfunc allows you make, for example, the pagetables
> > themselves an ordinary vma in the GGTT and so operate identically wrt
> > to
>
> Page tables don't need to be in ggtt. Is this comment about
> eviction of page directories (for gen < 8)?

Yes. The root table is always in ggtt. But we don't even have correct
context eviction yet...
-Chris

--
Chris Wilson, Intel Open Source Technology Centre