Re: [PATCH 11/17] drm/i915: Fix up the vma aliasing ppgtt binding

Chris Wilson
2015-04-15T10:47:11Z

On Tue, Apr 14, 2015 at 05:35:21PM +0200, Daniel Vetter wrote:
> Currently we have the problem that the decision whether ptes need to
> be (re)written is splattered all over the codebase. Move all that into
> i915_vma_bind. This needs a few changes:
> - Just reuse the PIN_* flags for i915_vma_bind and do the conversion
> to vma->bound in there to avoid duplicating the conversion code all
> over.
> - We need to make binding for EXECBUF (i.e. pick aliasing ppgtt if
> around) explicit, add PIN_EXECBUF for that.

I am in favour of making the PIN_GLOBAL | PIN_LOCAL explicit, but
PIN_EXECBUF doesn't seem descriptive of what happens, nor why it should
be execbuf specific. Just use PIN_LOCAL with the execbuf oring in
PIN_GLOBAL as it needs for workarounds + relocations.
-chris

--
Chris Wilson, Intel Open Source Technology Centre