[PATCH 00/17] i915_gem_gtt.c polish

Daniel Vetter
2015-04-14T15:35:35Z

Hi all,

I ended up reading a bit of i915_gem_gtt.c and spotted a few things to clean up
after the dynamic pagetable stuff landed. I haven't done the checkpatch polish
and kerneldoc, Mika/Michel will be doing that, but overall I think the code
looks fairly tidy now. I also untangled the vma binding logic a bit since it's
related, which means we can finally enable the gen7 cmd parser.

Btw my idea is that we'll move the higher level vma related code in
i915_gem_gtt.c out into a new i915_gem_vma.c file, together with the other vma
code sprinkled in various places. But that's probably better to do after the
partial mmap support from Joonas has landed. With that reorg i915_gem_gtt.c
would only concern itself with the low-level pagetable handling.

Survived light testing on my snb here.

Comments&review highly welcome.

Cheers, Daniel

Daniel Vetter (17):
drm/i915: Move gen8 clear_range vfunc setup into common code
drm/i915: Move vma vfuns to adddress_space
drm/i915: Clean up aliasing ppgtt correctly on error paths
drm/i915: Unify aliasing ppgtt handling
drm/i915: Move PTE_READ_ONLY to ->pte_encode vfunc
drm/i915: Dont clear PIN_GLOBAL in the execbuf pinning fallback
drm/i915: Drop redundant GGTT rebinding
drm/i915: Don't look at pg_dirty_rings for aliasing ppgtt
drm/i915: Don't use atomics for pg_dirty_rings
drm/i915: Remove misleading comment around bind_to_vm
drm/i915: Fix up the vma aliasing ppgtt binding
drm/i915: Arm cmd parser with aliasng ppgtt only
drm/i915: move i915_gem_restore_gtt_mappings around
drm/i915: Move ppgtt_bind/unbind around
drm/i915: Unduplicate i915_ggtt_unbind/bind_vma
drm/i915: Don't try to outsmart gcc in i915_gem_gtt.c
drm/i915: Move i915_get_ggtt_vma_pages into ggtt_bind_vma

drivers/gpu/drm/i915/i915_drv.h | 11 +-
drivers/gpu/drm/i915/i915_gem.c | 17 +-
drivers/gpu/drm/i915/i915_gem_context.c | 33 +-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 23 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 502 +++++++++++------------------
drivers/gpu/drm/i915/i915_gem_gtt.h | 18 +-
6 files changed, 225 insertions(+), 379 deletions(-)

--
2.1.0