Re: [PATCH 10/17] drm/i915: Remove misleading comment around bind_to_vm

Mika Kuoppala
2015-04-17T18:09:45Z

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> It's true that we might need to context switch, but both the signalling
> and implementation of the same are a few source files away. Remove it.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> ---
> drivers/gpu/drm/i915/i915_gem.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 4578772c5509..10e873c8957f 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4183,10 +4183,6 @@ i915_gem_object_do_pin(struct drm_i915_gem_object *obj,
>
> bound = vma ? vma->bound : 0;
> if (vma == NULL || !drm_mm_node_allocated(&vma->node)) {
> - /* In true PPGTT, bind has possibly changed PDEs, which
> - * means we must do a context switch before the GPU can
> - * accurately read some of the VMAs.
> - */
> vma = i915_gem_object_bind_to_vm(obj, vm, ggtt_view, alignment,
> flags);
> if (IS_ERR(vma))
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx