Re: [PATCH 17/17] drm/i915: Move i915_get_ggtt_vma_pages into ggtt_bind_vma

Daniel Vetter
2015-04-23T19:06:01Z

On Tue, Apr 21, 2015 at 04:36:55PM +0300, Mika Kuoppala wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
> > We have this neat abstraction between ppgtt and ggtt for (un)bind_vma
> > and didn't end up using it really. What a shame, so fix this and make
> > the ->bind_vma hook a bit more useful.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> This one I had problems with applying. But it looks simple enough.
>
> Patches 13-17,
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> With 12/17 I don't yet understand all the implications so I left
> that out.

Thanks for the review, remaining patches except patch 12 pulled in.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation