Re: [PATCH 12/17] drm/i915: Arm cmd parser with aliasng ppgtt only

Daniel Vetter
2015-04-15T09:41:27Z

On Tue, Apr 14, 2015 at 07:10:30PM +0100, Chris Wilson wrote:
> On Tue, Apr 14, 2015 at 05:35:22PM +0200, Daniel Vetter wrote:
> > With the binding regression from the original full ppgtt patches
> > fixed we can throw the switch. Yay!
>
> This changelog is misleading. The validation part of the command parser
> has been running for some time, with people starting to notice the
> performance regressions. What is being turned on here is the enabling
> part to allow userspace to do more. So shouldn't that also be a bump in
> the command parser version?

mesa has independent checks that the register writes go through, so just
switching the cmd parser to permission granting mode should be all that's
neeeded really.

And yes the cmd parser is enabled already, I thought "to arm" does convey
that it's now going from dummy mode to live.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation