Re: [PATCH 02/17] drm/i915: Move vma vfuns to adddress_space

Chris Wilson
2015-04-14T16:12:35Z

On Tue, Apr 14, 2015 at 05:09:27PM +0100, Chris Wilson wrote:
> On Tue, Apr 14, 2015 at 05:35:12PM +0200, Daniel Vetter wrote:
> > They change with the address space and not with each vma, so move them
> > into the right pile of vfuncs. Save 2 pointers per vma and clarifies
> > the code.
>
> Using per-vma vfunc allows you make, for example, the pagetables
> themselves an ordinary vma in the GGTT and so operate identically wrt to
> the shrinker and eviction logic - removing some very fragile code in the
> process.

A vma->ops would be an interesting compromise.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre