Re: [PATCH 00/17] i915_gem_gtt.c polish

Chris Wilson
2015-04-15T10:49:36Z

On Tue, Apr 14, 2015 at 05:35:10PM +0200, Daniel Vetter wrote:
> Hi all,
>
> I ended up reading a bit of i915_gem_gtt.c and spotted a few things to clean up
> after the dynamic pagetable stuff landed. I haven't done the checkpatch polish
> and kerneldoc, Mika/Michel will be doing that, but overall I think the code
> looks fairly tidy now. I also untangled the vma binding logic a bit since it's
> related, which means we can finally enable the gen7 cmd parser.
>
> Btw my idea is that we'll move the higher level vma related code in
> i915_gem_gtt.c out into a new i915_gem_vma.c file, together with the other vma
> code sprinkled in various places. But that's probably better to do after the
> partial mmap support from Joonas has landed. With that reorg i915_gem_gtt.c
> would only concern itself with the low-level pagetable handling.
>
> Survived light testing on my snb here.
>
> Comments&review highly welcome.

Ok, I think I've commented on everything I want to, the rest lgtm.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre