Re: [PATCH 08/17] drm/i915: Don't look at pg_dirty_rings for aliasing ppgtt

Chris Wilson
2015-04-23T21:52:58Z

On Thu, Apr 23, 2015 at 08:56:40PM +0200, Daniel Vetter wrote:
> Yeah, but I didn't really see the point in the debug infrastructure for
> aliasing ppgtt. The pde loading is done somewhere completely else than for
> full ppgtt. And if we forget to load the pdes the effects are obvious,
> whereas failing to reload when changes happen with full ppgtt is much
> harder to spot quickly. So I opted to undo those checks again, they have
> been defunct before my changes anyway.

You removed the WARN, but didn't fix the broken code the WARN was
telling you about.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre