Re: [PATCH 1/3] drm/i915: Wait for render state init

Mika Kuoppala
2015-03-16T14:20:53Z

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Mon, Mar 16, 2015 at 03:46:34PM +0200, Mika Kuoppala wrote:
>> We are freeing the batch that is just pushed to ring.
>
> Kill this. It is not correct.
>
>> Further, other ring inits should assume that the render
>> context with the workarounds are pushed before their rings
>> execute anything.
>>
>> This fixes (or papers over) a problem where with full ppgtt
>> the blitter ring init sometimes fails, where the blt ring
>> ACTHD runs wild through the address space until eventually
>> hangcheck kills it.
>
> Interesting. We don't do anything inside the golden render state to be
> of relevance to the blitter engine. So I think this is pure paper and
> will not ultimately fix the problem.
> -Chris
>

Perhaps not in the golden state, but do we push any workarounds through
render ring init, that are global in scope and required by the other rings?

-Mika