Multiple declarations for intel_fbc_enabled

Multiple declarations for intel_fbc_enabled

[Ed Maste]

A FreeBSD developer discovered that intel_fbc_enabled has a
declaration in two headers:

sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);

We have a slightly older version of the i915 driver on FreeBSD, but I
see that this is still the case in Linux (although the "extern" has
been removed from one of them). Commit 85208be added the one in
intel_drv.h and didn't remove the existing one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Multiple declarations for intel_fbc_enabled

[Jani Nikula]

On Mon, 02 Feb 2015, Ed Maste <carpeddiem@gmail.com> wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
>
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
>
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.

Fixed by

commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Mon Dec 8 14:09:10 2014 -0200

    drm/i915: Move FBC stuff to intel_fbc.c

which is queued for v3.20.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Multiple declarations for intel_fbc_enabled

[Ed Maste]

On 4 February 2015 at 08:27, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 02 Feb 2015, Ed Maste <carpeddiem@gmail.com> wrote:
>> A FreeBSD developer discovered that intel_fbc_enabled has a
>> declaration in two headers:
>>
>> ...
>
> Fixed by
>
> commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364

Thanks.

Sorry for the double post - one was stuck in moderation by the mailing
list software, presumably because it came from a non-subscribed
address.

I've added linux-next now and will check there if we find other issues
in the future.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Multiple declarations for intel_fbc_enabled

[Ed Maste]

A FreeBSD developer discovered that intel_fbc_enabled has a
declaration in two headers:

sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);

We have a slightly older version of the i915 driver on FreeBSD, but I
see that this is still the case in Linux (although the "extern" has
been removed from one of them). Commit 85208be added the one in
intel_drv.h and didn't remove the existing one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Multiple declarations for intel_fbc_enabled

[Daniel Vetter]

On Mon, Feb 02, 2015 at 11:40:13AM -0500, Ed Maste wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
> 
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> 
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.

Seems to be fixed already with

commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Mon Dec 8 14:09:10 2014 -0200

    drm/i915: Move FBC stuff to intel_fbc.c

which will be in 3.20. Thanks for reporting anyway.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx