From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence Date: Fri, 31 Oct 2014 11:17:04 +0200 Message-ID: <87egtoioof.fsf@intel.com> References: <1414497894-10046-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FFB66E566 for ; Fri, 31 Oct 2014 02:17:15 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAzMCBPY3QgMjAxNCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAZ21haWwuY29t PiB3cm90ZToKPiBPbiBUdWUsIE9jdCAyOCwgMjAxNCBhdCA1OjA0IEFNLCBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPj4gU2ltaWxhciB0byB0aGUgaHN3L2JkdyBl bmFibGUgc2VxdWVuY2UgcmV3cml0ZS4KPj4KPj4gdjM6IHJlcGxhY2UgdmJsYW5rIHdhaXQgd2l0 aCBhIGNvbW1lbnQKPj4KPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh QGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5j IHwgNTggKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBj aGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9hdWRpby5jCj4+IGluZGV4IDJlN2Q0Mjg3OGI5ZC4uYzA2MDQ3MzYxZTJhIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPj4gQEAgLTIxMCw2ICsyMTAsMTAg QEAgc3RhdGljIHZvaWQgaWxrX2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yLAo+PiAgewo+PiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGNvbm5lY3Rvci0+ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gICAgICAgICBzdHJ1Y3Qg aW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRj KTsKPj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9 Cj4+ICsgICAgICAgICAgICAgICBlbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2UpOwo+PiAr ICAgICAgIGVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGlnX3BvcnQtPnBvcnQ7Cj4+ICsgICAgICAg ZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+PiAgICAgICAgIHVpbnQ4X3QgKmVs ZCA9IGNvbm5lY3Rvci0+ZWxkOwo+PiAgICAgICAgIHVpbnQzMl90IGVsZHY7Cj4+ICAgICAgICAg dWludDMyX3QgdG1wOwo+PiBAQCAtMjE4LDggKzIyMiwxMSBAQCBzdGF0aWMgdm9pZCBpbGtfYXVk aW9fY29kZWNfZW5hYmxlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAgICAg ICAgaW50IGF1ZF9jb25maWc7Cj4+ICAgICAgICAgaW50IGF1ZF9jbnRsX3N0Owo+PiAgICAgICAg IGludCBhdWRfY250cmxfc3QyOwo+PiAtICAgICAgIGVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0 Yy0+cGlwZTsKPj4gLSAgICAgICBlbnVtIHBvcnQgcG9ydDsKPj4gKwo+PiArICAgICAgIERSTV9E RUJVR19LTVMoIkVuYWJsZSBhdWRpbyBjb2RlYyBvbiBwb3J0ICVjLCBwaXBlICVjLCAldSBieXRl cyBFTERcbiIsCj4+ICsgICAgICAgICAgICAgICAgICAgICBwb3J0X25hbWUocG9ydCksIHBpcGVf bmFtZShwaXBlKSwgZWxkWzJdKTsKPgo+IE9uIFNOQiBzcGVjIHdlIHNob3VsZAo+Cj4gRW5hYmxl IGF1ZGlvIFByZXNlbmNlIERldGVjdAo+Cj4gU2V0IHRoZSBwb3J0IGNvbnRyb2wgcmVnaXN0ZXIg KEhETUlfQ1RMIG9yIERQX0NUTCkgQXVkaW9fT3V0cHV0X0VuYWJsZQo+IChiaXQgNikgdG8gIjEi Cj4KPiBhdCB0aGlzIHBvaW50CgpUaGF0J3MgZG9uZSBhIGJpdCBlYXJsaWVyIGluIGludGVsX2Vu YWJsZV9oZG1pIGFuZCBpbnRlbF9kcF9lbmFibGVfcG9ydAood2hlcmUgaW50ZWxfZHAtPkRQIGhh cyBoYWQgdGhlIERQX0FVRElPX09VVFBVVF9FTkFCTEUgYml0IHNldCBpbgppbnRlbF9kcF9wcmVw YXJlKS4KCj4KPj4gKwo+PiArICAgICAgIC8qIFhYWDogdmJsYW5rIHdhaXQgaGVyZSAqLwo+Cj4g c2FtZSBxdWVzdGlvbiBmcm9tIHByZXZpb3VzIGVtYWlsLi4uIGFyZW4ndCB3ZSBlbmFibGluZyBp dCB0byBzb29uPwoKU2FtZSBhbnN3ZXJzIGFzIGluIHByZXZpb3VzIG1haWxzIHRvIHRoaXMgYW5k IHRoZSBjb21tZW50cyBiZWxvdy4KCkJSLApKYW5pLgoKPgo+Pgo+PiAgICAgICAgIGlmIChIQVNf UENIX0lCWChjb25uZWN0b3ItPmRldikpIHsKPj4gICAgICAgICAgICAgICAgIGhkbWl3X2hkbWll ZGlkID0gSUJYX0hETUlXX0hETUlFRElEKHBpcGUpOwo+PiBAQCAtMjM4LDU3ICsyNDUsNDQgQEAg c3RhdGljIHZvaWQgaWxrX2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yLAo+PiAgICAgICAgICAgICAgICAgYXVkX2NudHJsX3N0MiA9IENQVF9BVURfQ05U UkxfU1QyOwo+PiAgICAgICAgIH0KPj4KPj4gLSAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJFTEQg b24gcGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPj4gLQo+PiAtICAgICAgIGlmIChJU19W QUxMRVlWSUVXKGNvbm5lY3Rvci0+ZGV2KSkgIHsKPj4gLSAgICAgICAgICAgICAgIHN0cnVjdCBp bnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0Owo+PiAtCj4+IC0gICAgICAgICAgICAg ICBpbnRlbF9kaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4+IC0g ICAgICAgICAgICAgICBwb3J0ID0gaW50ZWxfZGlnX3BvcnQtPnBvcnQ7Cj4+IC0gICAgICAgfSBl bHNlIHsKPj4gLSAgICAgICAgICAgICAgIHRtcCA9IEk5MTVfUkVBRChhdWRfY250bF9zdCk7Cj4+ IC0gICAgICAgICAgICAgICBwb3J0ID0gKHRtcCA+PiAyOSkgJiBESVBfUE9SVF9TRUxfTUFTSzsK Pj4gLSAgICAgICAgICAgICAgIC8qIERJUF9Qb3J0X1NlbGVjdCwgMHgxID0gUG9ydEIgKi8KPj4g LSAgICAgICB9Cj4+IC0KPj4gLSAgICAgICBpZiAoIXBvcnQpIHsKPj4gLSAgICAgICAgICAgICAg IERSTV9ERUJVR19EUklWRVIoIkF1ZGlvIGRpcmVjdGVkIHRvIHVua25vd24gcG9ydFxuIik7Cj4+ IC0gICAgICAgICAgICAgICAvKiBvcGVyYXRlIGJsaW5kbHkgb24gYWxsIHBvcnRzICovCj4+ICsg ICAgICAgaWYgKFdBUk5fT04oIXBvcnQpKSB7Cj4+ICAgICAgICAgICAgICAgICBlbGR2ID0gSUJY X0VMRF9WQUxJREI7Cj4+ICAgICAgICAgICAgICAgICBlbGR2IHw9IElCWF9FTERfVkFMSURCIDw8 IDQ7Cj4+ICAgICAgICAgICAgICAgICBlbGR2IHw9IElCWF9FTERfVkFMSURCIDw8IDg7Cj4+ICAg ICAgICAgfSBlbHNlIHsKPj4gLSAgICAgICAgICAgICAgIERSTV9ERUJVR19EUklWRVIoIkVMRCBv biBwb3J0ICVjXG4iLCBwb3J0X25hbWUocG9ydCkpOwo+PiAgICAgICAgICAgICAgICAgZWxkdiA9 IElCWF9FTERfVkFMSURCIDw8ICgocG9ydCAtIDEpICogNCk7Cj4+ICAgICAgICAgfQo+Pgo+PiAt ICAgICAgIGlmIChpbnRlbF9waXBlX2hhc190eXBlKGludGVsX2NydGMsIElOVEVMX09VVFBVVF9E SVNQTEFZUE9SVCkpCj4+IC0gICAgICAgICAgICAgICBJOTE1X1dSSVRFKGF1ZF9jb25maWcsIEFV RF9DT05GSUdfTl9WQUxVRV9JTkRFWCk7IC8qIDB4MSA9IERQICovCj4+IC0gICAgICAgZWxzZQo+ PiAtICAgICAgICAgICAgICAgSTkxNV9XUklURShhdWRfY29uZmlnLCBhdWRpb19jb25maWdfaGRt aV9waXhlbF9jbG9jayhtb2RlKSk7Cj4+IC0KPj4gLSAgICAgICBpZiAoaW50ZWxfZWxkX3VwdG9k YXRlKGNvbm5lY3RvciwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1ZF9jbnRy bF9zdDIsIGVsZHYsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhdWRfY250bF9z dCwgSUJYX0VMRF9BRERSRVNTX01BU0ssCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBoZG1pd19oZG1pZWRpZCkpCj4+IC0gICAgICAgICAgICAgICByZXR1cm47Cj4+IC0KPj4gKyAg ICAgICAvKiBJbnZhbGlkYXRlIEVMRCAqLwo+PiAgICAgICAgIHRtcCA9IEk5MTVfUkVBRChhdWRf Y250cmxfc3QyKTsKPj4gICAgICAgICB0bXAgJj0gfmVsZHY7Cj4+ICAgICAgICAgSTkxNV9XUklU RShhdWRfY250cmxfc3QyLCB0bXApOwo+Pgo+PiArICAgICAgIC8qIFJlc2V0IEVMRCB3cml0ZSBh ZGRyZXNzICovCj4+ICAgICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRsX3N0KTsKPj4gICAg ICAgICB0bXAgJj0gfklCWF9FTERfQUREUkVTU19NQVNLOwo+PiAgICAgICAgIEk5MTVfV1JJVEUo YXVkX2NudGxfc3QsIHRtcCk7Cj4KPiBzYW1lIGFzIGxhc3QgcGF0Y2guLi4gdGhpcyBpbnN0cnVj dGlvbiBkb2Vzbid0IGFwcGVhciBhdCBzcGVjIGF0IHRoaXMgcG9pbnQuCj4KPj4KPj4gLSAgICAg ICBsZW4gPSBtaW5fdChpbnQsIGVsZFsyXSwgMjEpOyAgIC8qIDg0IGJ5dGVzIG9mIGh3IEVMRCBi dWZmZXIgKi8KPj4gLSAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJFTEQgc2l6ZSAlZFxuIiwgbGVu KTsKPj4gKyAgICAgICAvKiBVcCB0byA4NCBieXRlcyBvZiBodyBFTEQgYnVmZmVyICovCj4+ICsg ICAgICAgbGVuID0gbWluX3QoaW50LCBlbGRbMl0sIDIxKTsKPj4gICAgICAgICBmb3IgKGkgPSAw OyBpIDwgbGVuOyBpKyspCj4+ICAgICAgICAgICAgICAgICBJOTE1X1dSSVRFKGhkbWl3X2hkbWll ZGlkLCAqKCh1aW50MzJfdCAqKWVsZCArIGkpKTsKPiBuZWl0aGVyIHRoaXMuCj4KPj4KPj4gKyAg ICAgICAvKiBFTEQgdmFsaWQgKi8KPj4gICAgICAgICB0bXAgPSBJOTE1X1JFQUQoYXVkX2NudHJs X3N0Mik7Cj4+ICAgICAgICAgdG1wIHw9IGVsZHY7Cj4+ICAgICAgICAgSTkxNV9XUklURShhdWRf Y250cmxfc3QyLCB0bXApOwo+PiArCj4+ICsgICAgICAgLyogRW5hYmxlIHRpbWVzdGFtcHMgKi8K Pj4gKyAgICAgICB0bXAgPSBJOTE1X1JFQUQoYXVkX2NvbmZpZyk7Cj4+ICsgICAgICAgdG1wICY9 IH5BVURfQ09ORklHX05fVkFMVUVfSU5ERVg7Cj4+ICsgICAgICAgdG1wICY9IH5BVURfQ09ORklH X05fUFJPR19FTkFCTEU7Cj4+ICsgICAgICAgdG1wICY9IH5BVURfQ09ORklHX1BJWEVMX0NMT0NL X0hETUlfTUFTSzsKPj4gKyAgICAgICBpZiAoaW50ZWxfcGlwZV9oYXNfdHlwZShpbnRlbF9jcnRj LCBJTlRFTF9PVVRQVVRfRElTUExBWVBPUlQpKQo+PiArICAgICAgICAgICAgICAgdG1wIHw9IEFV RF9DT05GSUdfTl9WQUxVRV9JTkRFWDsKPj4gKyAgICAgICBlbHNlCj4+ICsgICAgICAgICAgICAg ICB0bXAgfD0gYXVkaW9fY29uZmlnX2hkbWlfcGl4ZWxfY2xvY2sobW9kZSk7Cj4+ICsgICAgICAg STkxNV9XUklURShhdWRfY29uZmlnLCB0bXApOwo+PiAgfQo+Pgo+PiAgLyoqCj4+IC0tCj4+IDIu MS4xCj4+Cj4KPgo+Cj4gLS0gCj4gUm9kcmlnbyBWaXZpCj4gQmxvZzogaHR0cDovL2Jsb2cudml2 aS5lbmcuYnIKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK