From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated for latest VLV revision Date: Mon, 30 Jun 2014 13:20:32 +0300 Message-ID: <87egy6itqn.fsf@intel.com> References: <539AEE01.1040208@linux.intel.com> <1403934971-3748-1-git-send-email-deepak.s@linux.intel.com> <8761jmlqpz.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 40CC66E1BF for ; Mon, 30 Jun 2014 03:21:05 -0700 (PDT) In-Reply-To: <8761jmlqpz.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: deepak.s@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 27 Jun 2014, Jani Nikula wrote: > On Sat, 28 Jun 2014, deepak.s@linux.intel.com wrote: >> From: Deepak S >> >> Workaround fixed in Latest VLV revision. Forcing Gfx clk up not needed, and Requesting the >> min freq should bring bring the voltage Vnn. >> >> v2: Drop WA for Latest VLV revision (Ville) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75244 Per comments in the bug, scratch that. Deepak, I presume this patch is needed nonetheless? BR, Jani. > >> Signed-off-by: Deepak S >> --- >> drivers/gpu/drm/i915/intel_pm.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> index a90fdbd..6b6cfd4 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -3212,6 +3212,14 @@ void gen6_set_rps(struct drm_device *dev, u8 val) >> */ >> static void vlv_set_rps_idle(struct drm_i915_private *dev_priv) >> { >> + struct drm_device *dev = dev_priv->dev; >> + >> + /* Latest VLV doesn't need Vnn WA*/ >> + if (dev->pdev->revision >= 0xd) { >> + valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit); >> + return; >> + } >> + >> /* >> * When we are idle. Drop to min voltage state. >> */ >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center