From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: Add debug module option for VTd validation
Date: Tue, 01 Apr 2014 09:52:37 +0300 [thread overview]
Message-ID: <87eh1hee2y.fsf@intel.com> (raw)
In-Reply-To: <1396275785-8815-3-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 31 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> VTd has a few too many "outright disable the damn thing" workarounds
> accumulated and for validation we want a simple knob to make sure we
> disable them all.
>
> Since this is for bdw+ validation and atm we don't have any
> workarounds for bdw this option currently does nothing. So currently
> this is just a placeholder to make sure reality will match with the
> documented process for our validation people.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_params.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ff02225d5edd..610ff70f8609 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1925,6 +1925,7 @@ struct i915_params {
> bool prefault_disable;
> bool reset;
> bool disable_display;
> + bool disable_vtd_wa;
> };
> extern struct i915_params i915 __read_mostly;
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index e1027cc5f0ee..60bfcfa2f339 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -47,6 +47,7 @@ struct i915_params i915 __read_mostly = {
> .invert_brightness = 0,
> .disable_display = 0,
> .enable_cmd_parser = 1,
> + .disable_vtd_wa = 0,
> };
>
> module_param_named(modeset, i915.modeset, int, 0400);
> @@ -149,6 +150,9 @@ MODULE_PARM_DESC(invert_brightness,
> module_param_named(disable_display, i915.disable_display, bool, 0600);
> MODULE_PARM_DESC(disable_display, "Disable display (default: false)");
>
> +module_param_named(disable_vtd_wa, i915.disable_vtd_wa, bool, 0600);
> +MODULE_PARM_DESC(disable_display, "Disable all VT-d workarounds (default: false)");
disable_display?!
Jani.
> +
> module_param_named(enable_cmd_parser, i915.enable_cmd_parser, int, 0600);
> MODULE_PARM_DESC(enable_cmd_parser,
> "Enable command parsing (1=enabled [default], 0=disabled)");
> --
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-01 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 14:23 [PATCH 1/3] drm/i915: Deprecate UMS harder Daniel Vetter
2014-03-31 14:23 ` [PATCH 2/3] drm/i915: dmesg output for VT-d testing Daniel Vetter
2014-03-31 14:23 ` [PATCH 3/3] drm/i915: Add debug module option for VTd validation Daniel Vetter
2014-04-01 6:52 ` Jani Nikula [this message]
2014-04-01 7:33 ` [PATCH] " Daniel Vetter
2014-04-01 7:33 ` Daniel Vetter
2014-04-01 8:14 ` Jani Nikula
2014-04-03 9:25 ` Daniel Vetter
2014-03-31 15:44 ` [PATCH 1/3] drm/i915: Deprecate UMS harder Chris Wilson
2014-03-31 17:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh1hee2y.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox