From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix open-coded DIV_ROUND_UP Date: Mon, 21 Oct 2013 10:03:47 +0300 Message-ID: <87eh7f3y24.fsf@intel.com> References: <1382132904-3455-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id CB4C1E5F48 for ; Mon, 21 Oct 2013 00:02:15 -0700 (PDT) In-Reply-To: <1382132904-3455-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Sat, 19 Oct 2013, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the nice Kernel macro, it makes the code much more readable. > > Signed-off-by: Paulo Zanoni Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > drivers/gpu/drm/i915/intel_fbdev.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 34df59b..e7b39d7 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -261,7 +261,7 @@ i915_gem_dumb_create(struct drm_file *file, > struct drm_mode_create_dumb *args) > { > /* have to work out size/pitch and return them */ > - args->pitch = ALIGN(args->width * ((args->bpp + 7) / 8), 64); > + args->pitch = ALIGN(args->width * DIV_ROUND_UP(args->bpp, 8), 64); > args->size = args->pitch * args->height; > return i915_gem_create(file, dev, > args->size, &args->handle); > diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c > index acc8395..895fcb4 100644 > --- a/drivers/gpu/drm/i915/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/intel_fbdev.c > @@ -78,8 +78,8 @@ static int intelfb_create(struct drm_fb_helper *helper, > mode_cmd.width = sizes->surface_width; > mode_cmd.height = sizes->surface_height; > > - mode_cmd.pitches[0] = ALIGN(mode_cmd.width * ((sizes->surface_bpp + 7) / > - 8), 64); > + mode_cmd.pitches[0] = ALIGN(mode_cmd.width * > + DIV_ROUND_UP(sizes->surface_bpp, 8), 64); > mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp, > sizes->surface_depth); > > -- > 1.8.4.rc3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center