From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [patch] drm/i915: precendence bug in GT_PARITY_ERROR() Date: Tue, 24 Sep 2013 11:22:56 +0300 Message-ID: <87eh8e6333.fsf@intel.com> References: <20130924075735.GB29141@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20130924075735.GB29141@elgon.mountain> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Sep 2013, Dan Carpenter wrote: > The | operation has higher precedence than "?:" so the macro always > returns GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1. > > Signed-off-by: Dan Carpenter Reviewed-by: Jani Nikula Introduced in commit 35a85ac60618521d41cfdb14f3fbfc8ad7329e9e Author: Ben Widawsky Date: Thu Sep 19 11:13:41 2013 -0700 drm/i915: Add second slice l3 remapping which hasn't been merged to Linus' tree yet. BR, Jani. > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index c4f9bef..876666b 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -940,7 +940,7 @@ > > #define GT_PARITY_ERROR(dev) \ > (GT_RENDER_L3_PARITY_ERROR_INTERRUPT | \ > - IS_HASWELL(dev) ? GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1 : 0) > + (IS_HASWELL(dev) ? GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1 : 0)) > > /* These are all the "old" interrupts */ > #define ILK_BSD_USER_INTERRUPT (1<<5) > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center