From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] i965: Add hardware context support. Date: Wed, 13 Jun 2012 10:59:47 -0700 Message-ID: <87ehpjm6ss.fsf@eliezer.anholt.net> References: <1339528029-7470-1-git-send-email-kenneth@whitecape.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2031074413==" Return-path: In-Reply-To: <1339528029-7470-1-git-send-email-kenneth@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces+gcvmd-mesa3d-493=gmane.org@lists.freedesktop.org Errors-To: mesa-dev-bounces+gcvmd-mesa3d-493=gmane.org@lists.freedesktop.org To: Kenneth Graunke , mesa-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============2031074413== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 12 Jun 2012 12:07:09 -0700, Kenneth Graunke = wrote: > With fixes and updates from Ben Widawsky and comments from Paul Berry. >=20 > This should not be pushed until libdrm 2.4.36 is released with Ben's > hardware context support. >=20 > I haven't hooked up the context destroy function yet as I'm not entirely > sure about tear-down, but they will be freed on fd close, so it should > only be a problem for long running processes that open and destroy many > GL contexts. What's wrong with just freeing our context at brw_destroy_context()? We definietly have to manually free the stuff, since some apps (web browsers) will have many context create/destroy cycles. > diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/driver= s/dri/intel/intel_context.c > index c2f7d29..fc244c1 100644 > --- a/src/mesa/drivers/dri/intel/intel_context.c > +++ b/src/mesa/drivers/dri/intel/intel_context.c > @@ -593,6 +593,8 @@ intelInitContext(struct intel_context *intel, > if (intelScreen->bufmgr =3D=3D NULL) > return false; >=20=20 > + intel->hw_ctx =3D NULL; it's rzalloced, so we don't manually zero most of our data. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk/Y1RMACgkQHUdvYGzw6ve/dgCgilpWDsfAi6Q4hsDmfJtbyohC yRIAn37K22F+X6ooEDhoWwciblXvtKRP =MmD5 -----END PGP SIGNATURE----- --=-=-=-- --===============2031074413== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev --===============2031074413==--