From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 4/6] drm/i915: simplify i915_reset a bit Date: Wed, 25 Apr 2012 16:14:28 -0700 Message-ID: <87ehrbqu97.fsf@eliezer.anholt.net> References: <1335355033-3854-1-git-send-email-daniel.vetter@ffwll.ch> <1335355033-3854-5-git-send-email-daniel.vetter@ffwll.ch> <20120425091821.19fc7808@jbarnes-desktop> <20120425202712.GH5079@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0239600155==" Return-path: In-Reply-To: <20120425202712.GH5079@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Jesse Barnes Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org --===============0239600155== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 25 Apr 2012 22:27:12 +0200, Daniel Vetter wrote: > On Wed, Apr 25, 2012 at 09:18:21AM -0700, Jesse Barnes wrote: > > On Wed, 25 Apr 2012 13:57:11 +0200 > > Daniel Vetter wrote: > >=20 > > > - need_display is always true, scrap it. > > > - don't reacquire the mutex to do nothing after having restored the > > > gem state. > > >=20 > >=20 > > Actually I think we generally *don't* need to reset display. It's > > currently there just because we haven't tried reset handling without > > it. But not resetting display would make resets a little less visible, > > which would be nice. Now that you have a nice test setup, can you try > > testing without the display engine bit set (i.e. only reset render and > > media at hang time)? >=20 > Imo 'less visible' and gpu hang don't go well together, the 3 second > freeze plus screen flicker at least ensure that users report bugs. And I > have no idea whether resetting the entire gpu or just the render portion > has a greater chance of survival. So I'm not sure whether working on this > has much benefit ... at least opposed to working on the bugs ;-) I've been hanging my system every couple of minutes most of today, and this DP panel takes about 15 seconds to light up after a modeset. Please stop resetting display when I hang the GPU. (Then if we could get rid of the random decision to fallback to sw in the 2d driver on a gpu hang, I'd be happy) --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+YhVQACgkQHUdvYGzw6vf3UACfZRVAiiokSEyDWqRMi6LKb+E7 OskAn1TQGlTxhZzHUizIIAOXkGKdT7XI =B15g -----END PGP SIGNATURE----- --=-=-=-- --===============0239600155== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0239600155==--