Re: [PATCH] drm/i915/rps: fix stale reference to i915->irq_lock

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 07 May 2025, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2025-05-07 05:31:36-03:00)
>>The RPS code has been switched from using i915->irq_lock to gt->irq_lock
>>years ago in commit d762043f7ab1 ("drm/i915: Extract GT powermanagement
>>interrupt handling"). Fix the stale comment referencing i915->irq_lock,
>>which has also ceased to exist.
>>
>>Reported-by: Gustavo Sousa <gustavo.sousa@intel.com>
>>Closes: https://lore.kernel.org/r/174656703321.1401.8627403371256302933@intel.com
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

Thanks, pushed.

BR,
Jani.

>
>>---
>> drivers/gpu/drm/i915/gt/intel_rps_types.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/gpu/drm/i915/gt/intel_rps_types.h b/drivers/gpu/drm/i915/gt/intel_rps_types.h
>>index 5135b90a2a40..ece445109305 100644
>>--- a/drivers/gpu/drm/i915/gt/intel_rps_types.h
>>+++ b/drivers/gpu/drm/i915/gt/intel_rps_types.h
>>@@ -57,7 +57,7 @@ struct intel_rps {
>> 
>>         /*
>>          * work, interrupts_enabled and pm_iir are protected by
>>-         * i915->irq_lock
>>+         * gt->irq_lock
>>          */
>>         struct timer_list timer;
>>         struct work_struct work;
>>-- 
>>2.39.5
>>

-- 
Jani Nikula, Intel