From: Jani Nikula <jani.nikula@intel.com>
To: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>,
Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging
Date: Thu, 29 Feb 2024 13:23:08 +0200 [thread overview]
Message-ID: <87frxb8qg3.fsf@intel.com> (raw)
In-Reply-To: <4b7b2711-040c-4aed-ab05-e752527cf5cb@intel.com>
On Thu, 29 Feb 2024, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> On 2/28/2024 8:08 PM, Mitul Golani wrote:
>> +enum operation_mode {
>> + DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00,
>> + DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01,
>> + DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02,
>> + DP_AS_SDP_FAVT_TRR_REACHED = 0x03
>> +};
>
> We can drop the initialization here.
For stuff that needs to match the spec it's common to include the
initializations instead of relying on the auto enumeration.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-02-29 11:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 14:38 [PATCH v12 0/8] Enable Adaptive Sync SDP Support for DP Mitul Golani
2024-02-28 14:38 ` [PATCH v12 1/8] drm/dp: Add support to indicate if sink supports AS SDP Mitul Golani
2024-02-29 10:01 ` Nautiyal, Ankit K
2024-02-28 14:38 ` [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging Mitul Golani
2024-02-29 10:07 ` Nautiyal, Ankit K
2024-02-29 11:23 ` Jani Nikula [this message]
2024-02-29 12:13 ` Nautiyal, Ankit K
2024-02-29 10:37 ` Jani Nikula
2024-02-29 16:33 ` Golani, Mitulkumar Ajitkumar
2024-02-29 19:30 ` Jani Nikula
2024-02-29 19:53 ` Golani, Mitulkumar Ajitkumar
2024-02-28 14:38 ` [PATCH v12 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP Mitul Golani
2024-02-29 10:28 ` Nautiyal, Ankit K
2024-02-28 14:38 ` [PATCH v12 4/8] drm/i915/display/dp: Add wrapper function to check AS SDP Mitul Golani
2024-02-29 10:30 ` Nautiyal, Ankit K
2024-02-28 14:38 ` [PATCH v12 5/8] drm/i915/display: Compute AS SDP parameters Mitul Golani
2024-02-29 11:07 ` Nautiyal, Ankit K
2024-02-28 14:38 ` [PATCH v12 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP Mitul Golani
2024-02-29 11:52 ` Nautiyal, Ankit K
2024-02-28 14:38 ` [PATCH v12 7/8] drm/i915/display: Compute vrr_vsync params Mitul Golani
2024-02-28 14:38 ` [PATCH v12 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled Mitul Golani
2024-02-28 15:14 ` [PATCH v12 0/8] Enable Adaptive Sync SDP Support for DP Jani Nikula
2024-02-29 4:38 ` Golani, Mitulkumar Ajitkumar
2024-02-29 9:51 ` Jani Nikula
2024-02-28 22:43 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Adaptive Sync SDP Support for DP (rev12) Patchwork
2024-02-28 22:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-28 22:54 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-29 17:20 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frxb8qg3.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).