intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, thomas.hellstrom@intel.com,
	intel-xe@lists.freedesktop.org
Subject: Re: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings
Date: Mon, 29 Jan 2024 18:36:13 +0200	[thread overview]
Message-ID: <87frygjdvm.fsf@intel.com> (raw)
In-Reply-To: <ZbfCsl4xF4ymsSbm@intel.com>

On Mon, 29 Jan 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Mon, Jan 29, 2024 at 09:18:59AM -0600, Lucas De Marchi wrote:
>> no. the issue is not that it doesn't exist, but that the same path is
>> documented in 2 different places. If the interface is exactly the same,
>> there could be just 1 place to document it and then reuse the same file
>> (without the module name). If the interfaces are not identical, then we
>> should differentiate them like is done here.

Completely agreed.

>> 
>> +i915 maintainers
>> 
>> Are you ok with merging this through either xe or i915 trees
>> instead of splitting the patch? My preference is the first option.
>
> it won't conflict with anything we have on our side there, so
> it can go with drm-xe-next.
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel

  reply	other threads:[~2024-01-29 16:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-27 16:50 [PATCH v2] drm/hwmon: Fix abi doc warnings Badal Nilawar
2024-01-27 17:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-01-27 17:20 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-27 18:43 ` ✓ Fi.CI.IGT: " Patchwork
2024-01-27 20:10 ` [PATCH v2] " Dixit, Ashutosh
2024-01-29 15:18   ` Lucas De Marchi
2024-01-29 15:22     ` Rodrigo Vivi
2024-01-29 16:36       ` Jani Nikula [this message]
2024-01-30  4:43         ` Lucas De Marchi
2024-01-29 16:24     ` Dixit, Ashutosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frygjdvm.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).