From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA70BC0015E for ; Fri, 11 Aug 2023 09:18:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AF0110E08F; Fri, 11 Aug 2023 09:18:59 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE0E510E08F for ; Fri, 11 Aug 2023 09:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691745537; x=1723281537; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=d/Ed9izjYiyoLNIKbiwFaRrTelfBq1OuZkzRkNPy+uE=; b=QyN3XPXvTxHQZdpWZBpLWl8YHoEiqAVNwn9kt7KRBO2wLfjI4Ry/hPj1 6fkXhkKG5RCjuZ2mLxfcL4/5zhFOsGfzZQNKw3z9toHyRz5CclK/YICKH 9nxttu9o6LTEbhyP/fNtg3g8+cQp7x95A0NXn8mD8uz3U5BwXrr8REAVe cucyYLjMJy1LHDHtL6UmOz33T0crK+7+DRDU21uEMh8qrAGhMz0nOwGV7 P2Z/GOHjXdLFTAOL6S3ZOWVGtveuWCXoaZ6CGe6orE2xthQQNYlT/1iVW CdjUmQfO3XYZm3GKilVtaoLmra+MEHSr4zDRHY+3+n6Z4MkrpVM2Sqmv1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="374406102" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="374406102" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 02:18:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="726196727" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="726196727" Received: from unknown (HELO localhost) ([10.252.49.153]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 02:18:47 -0700 From: Jani Nikula To: "Lisovskiy, Stanislav" , intel-gfx@lists.freedesktop.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230719104833.25366-1-stanislav.lisovskiy@intel.com> Date: Fri, 11 Aug 2023 12:18:42 +0300 Message-ID: <87fs4qq6ml.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915: Start using plane scale factor for relative data rate X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 20 Jul 2023, "Lisovskiy, Stanislav" wrote: > On Wed, Jul 19, 2023 at 01:48:33PM +0300, Stanislav Lisovskiy wrote: >> BSpec clearly instructs us to use plane scale factor when calculating >> relative data rate to be used when allocating DDB blocks for each plane. >> For some reason we use scale factor for data_rate calculation, which is >> used for BW calculations, however we are not using it for DDB calculations. >> So lets fix it as described in BSpec 68907. >> >> Signed-off-by: Stanislav Lisovskiy >> --- >> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c >> index 7d9578ebae556..60a492e186ab8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c >> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c >> @@ -212,6 +212,7 @@ intel_plane_relative_data_rate(const struct intel_crtc_state *crtc_state, >> struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane); >> const struct drm_framebuffer *fb = plane_state->hw.fb; >> int width, height; >> + unsigned int rel_data_rate; >> >> if (plane->id == PLANE_CURSOR) >> return 0; >> @@ -241,7 +242,11 @@ intel_plane_relative_data_rate(const struct intel_crtc_state *crtc_state, >> height /= 2; >> } >> >> - return width * height * fb->format->cpp[color_plane]; >> + rel_data_rate = width * height * fb->format->cpp[color_plane]; >> + >> + return intel_adjusted_rate(&plane_state->uapi.src, >> + &plane_state->uapi.dst, >> + rel_data_rate); >> } >> >> int intel_plane_calc_min_cdclk(struct intel_atomic_state *state, >> -- >> 2.37.3 >> > > IGT failures are irrelevant here(test is aborted due to some timeout issue). Going through old mails... I think errors like that still warrant a retest before merging, because it can mask real issues that now won't get tested. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center