From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAAAAC001DC for ; Thu, 13 Jul 2023 12:48:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 946DE10E6A6; Thu, 13 Jul 2023 12:48:46 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3C3010E549; Wed, 12 Jul 2023 14:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689172533; x=1720708533; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=7EqKUdX8amzDodN7nIatZqqu7r5MTljrQuoCdn53hEQ=; b=a9UqAWc65MIY0tDFR7woBKTQ7PdJvKloaE11JNi6ZEGFF5k501iM06Jr OIdPWpNKzlHwS/I2RR2+6Bd/Ia8wQVmWo72oS4O8Bdl3iOPjUHmnQogw+ wVdbTrsXujqJSk96HOk8a4jI8oYEGmE52vpglbv93YibVDdcWO2512vA2 87MnV82lrcJ0h0qxmKT06OvkfjQ8SfSFZ6IwfhWdhDsyACDhtjl9S9ynF G0nhj4DiWY70mZcfWvZ/yCxF1Oep7Mf9moWDXEYlLJTisyqovkyNxfr/9 6d3ET/5hSkyY520f9Y4Yg5UPOZdk++rH58NkCtJJ3Z5h2y5g2RXke0GB7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="428641961" X-IronPort-AV: E=Sophos;i="6.01,199,1684825200"; d="scan'208";a="428641961" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2023 07:35:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="845686939" X-IronPort-AV: E=Sophos;i="6.01,199,1684825200"; d="scan'208";a="845686939" Received: from pmessina-mobl.ger.corp.intel.com (HELO localhost) ([10.252.42.186]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2023 07:34:31 -0700 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "Pan, Xinhui" , Harry Wentland , Leo Li , Rodrigo Siqueira , Hamza Mahfooz , Javier Martinez Canillas , Guchun Chen , Srinivasan Shanmugam , Evan Quan , Likun Gao , Marek =?utf-8?B?T2zFocOhaw==?= , David Francis , Hawking Zhang , Graham Sider , Lang Yu , Philip Yang , Yifan Zhang , Tim Huang , Zack Rusin , Sam Ravnborg , xurui , Laurent Pinchart , =?utf-8?Q?Ma=C3=ADra?= Canal , =?utf-8?Q?Andr=C3=A9?= Almeida , Qingqing Zhuo , Aurabindo Pillai , Hersen Wu , Fangzhi Zuo , Stylon Wang , Alan Liu , Wayne Lin , Aaron Liu , Melissa Wen , Bhawanpreet Lakha , David Tadokoro , Wenjing Liu , Jiapeng Chong , Mario Limonciello , Alexey Kodanev , Roman Li , =?utf-8?Q?Joaqu=C3=ADn?= Ignacio =?utf-8?Q?Aramend=C3=ADa?= , Dave Airlie , Russell King , Liviu Dudau , Joel Stanley , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Stefan Agner , Alison Wang , Patrik Jakobsson , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Xinliang Liu , Tian Tao , Danilo Krummrich , Deepak Rawat , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Ville =?utf-8?B?U3lyasOkbMOk?= , Lucas De Marchi , Ankit Nautiyal , Andrzej Hajda , Matt Roper , Stanislav Lisovskiy , Radhakrishna Sripada , Hans de Goede , Luca Coelho , Niranjana Vishwanathapura , Kai Vehmanen , Vinod Govindapillai , =?utf-8?Q?=C5=81ukasz?= Bartosik , Anusha Srivatsa , Chaitanya Kumar Borah , Uma Shankar , Imre Deak , Mitul Golani , Swati Sharma , Jouni =?utf-8?Q?H=C3=B6gander?= , Mika Kahola , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , Arun R Murthy , Gustavo Sousa , Khaled Almahallawy , Juha-Pekka Heikkila , Andi Shyti , Nirmoy Das , Fei Yang , Animesh Manna , Deepak R Varma , "Jiri Slaby (SUSE)" , Dmitry Baryshkov , Vandita Kulkarni , Suraj Kandpal , Manasi Navare , Drew Davenport , Laurentiu Palcu , Shawn Guo , Sascha Hauer , Philipp Zabel , Marian Cichy , Dan Carpenter , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Rob Clark , Abhinav Kumar , Vinod Polimera , Jiasheng Jiang , Konrad Dybcio , Jessica Zhang , Liu Shixin , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Emma Anholt , Gerd Hoffmann , Kieran Bingham , Tomi Valkeinen , Wolfram Sang , Geert Uytterhoeven , Biju Das , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , David Lechner , Kamlesh Gurudasani , Rodrigo Siqueira , Melissa Wen , Oleksandr Andrushchenko , Michal Simek In-Reply-To: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> Date: Wed, 12 Jul 2023 17:34:28 +0300 Message-ID: <87fs5tgpvv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 13 Jul 2023 12:48:29 +0000 Subject: Re: [Intel-gfx] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Yongqin Liu , Alim Akhtar , Marijn Suijten , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, Xinwei Kong , VMware Graphics Reviewers , NXP Linux Team , spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Gurchetan Singh , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-mips@vger.kernel.org, Chia-I Wu , linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, John Stultz , freedreno@lists.freedesktop.org, Lucas Stach Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 12 Jul 2023, Uwe Kleine-K=C3=B6nig = wrote: > Hello, > > while I debugged an issue in the imx-lcdc driver I was constantly > irritated about struct drm_device pointer variables being named "dev" > because with that name I usually expect a struct device pointer. > > I think there is a big benefit when these are all renamed to "drm_dev". > I have no strong preference here though, so "drmdev" or "drm" are fine > for me, too. Let the bikesheding begin! > > Some statistics: > > $ git grep -ohE 'struct drm_device *\* *[^ (),;]*' v6.5-rc1 | sort | uniq= -c | sort -n > 1 struct drm_device *adev_to_drm > 1 struct drm_device *drm_ > 1 struct drm_device *drm_dev > 1 struct drm_device *drm_dev > 1 struct drm_device *pdev > 1 struct drm_device *rdev > 1 struct drm_device *vdev > 2 struct drm_device *dcss_drv_dev_to_drm > 2 struct drm_device **ddev > 2 struct drm_device *drm_dev_alloc > 2 struct drm_device *mock > 2 struct drm_device *p_ddev > 5 struct drm_device *device > 9 struct drm_device * dev > 25 struct drm_device *d > 95 struct drm_device * > 216 struct drm_device *ddev > 234 struct drm_device *drm_dev > 611 struct drm_device *drm > 4190 struct drm_device *dev > > This series starts with renaming struct drm_crtc::dev to drm_dev. If > it's not only me and others like the result of this effort it should be > followed up by adapting the other structs and the individual usages in > the different drivers. I think this is an unnecessary change. In drm, a dev is usually a drm device, i.e. struct drm_device *. As shown by the numbers above. If folks insist on following through with this anyway, I'm firmly in the camp the name should be "drm" and nothing else. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center