public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/display: Print usefull information on error
@ 2023-06-01  5:15 Arun R Murthy
  2023-06-01  6:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Arun R Murthy @ 2023-06-01  5:15 UTC (permalink / raw)
  To: intel-gfx

For modifier not supporting async flip, print the modifier and display
version. Helps in reading the error message.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index f51a55f4e9d0..0877f1e251a0 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6012,8 +6012,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
 			 */
 			if (DISPLAY_VER(i915) < 12) {
 				drm_dbg_kms(&i915->drm,
-					    "[PLANE:%d:%s] Modifier does not support async flips\n",
-					    plane->base.base.id, plane->base.name);
+					    "[PLANE:%d:%s] Asyn flip on modifier 0x%llx not supported on Display Ver %d\n",
+					    plane->base.base.id, plane->base.name,
+					    new_plane_state->hw.fb->modifier, DISPLAY_VER(i915));
 				return -EINVAL;
 			}
 			break;
@@ -6025,8 +6026,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
 			break;
 		default:
 			drm_dbg_kms(&i915->drm,
-				    "[PLANE:%d:%s] Modifier does not support async flips\n",
-				    plane->base.base.id, plane->base.name);
+				    "[PLANE:%d:%s] Unknown modifier 0x%llx ! async flip not supported\n",
+				    plane->base.base.id, plane->base.name,
+				    new_plane_state->hw.fb->modifier);
 			return -EINVAL;
 		}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-06-05 15:22 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01  5:15 [Intel-gfx] [PATCH] drm/i915/display: Print usefull information on error Arun R Murthy
2023-06-01  6:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-06-01  6:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-01  9:41 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-06-01 10:27 ` [Intel-gfx] [PATCHv2] drm/i915/display: Print useful " Arun R Murthy
2023-06-01 14:00   ` Jani Nikula
2023-06-01 19:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Print usefull information on error (rev2) Patchwork
2023-06-02  2:21 ` [Intel-gfx] [PATCHv3] drm/i915/display: Print useful information on error Arun R Murthy
2023-06-05 15:22   ` Jani Nikula
2023-06-02  3:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Print usefull information on error (rev3) Patchwork
2023-06-04  6:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox