From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C658BC77B7C for ; Sat, 13 May 2023 00:39:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04F5210E71B; Sat, 13 May 2023 00:39:39 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42B3C10E719; Sat, 13 May 2023 00:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683938377; x=1715474377; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=H/ZKk+oeD9FtPDl9IrO61VuDCyFv2/MJfh5H+c0pCvI=; b=XkqPEPxl0b1IlMyP1SyCGDLQCICevg6OzTMAdSpUk69KVaGAzjSsrJNJ u6FXmG7tdASDFbmoG8rTPBRoxTo4FHqgeIROHS+55bnp1u7LjBfhUTl+E ZdLrgta783eliBMsVuAUyY4IyxZg3qYofIkZw5VOHimmF6za0qaD4mdLd U0RiOBGygAv7XL1WlQkHlqHoooakbztSf+sbxrRyXTwv7UMNm/b6PVtUx 1YEiuzebwEQqHZLPS526U27t1YkOhmBodO9GBlstqvZU3k83zUoREygmF eSoCQRMKXR96YXftT3RSRfn9DZIszDEHmyrPnXvLJxk0e7qTMr/5OGKoL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="416550853" X-IronPort-AV: E=Sophos;i="5.99,271,1677571200"; d="scan'208";a="416550853" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 17:39:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="769981650" X-IronPort-AV: E=Sophos;i="5.99,271,1677571200"; d="scan'208";a="769981650" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.239.47]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 17:39:35 -0700 Date: Fri, 12 May 2023 17:39:25 -0700 Message-ID: <87fs81dpz6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20230512235603.431386-1-vinay.belgaumkar@intel.com> References: <20230512235603.431386-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > rps_boost debugfs shows host turbo related info. This is not valid > when SLPC is enabled. A couple of thoughts about this. It appears people are know only about rps_boost_info and don't know about guc_slpc_info? So: a. Instead of hiding the rps_boost_info file do we need to print there saying "SLPC is enabled, go look at guc_slpc_info"? b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two files will show the same SLPC information)? Ashutosh > guc_slpc_info already shows the number of boosts. Add num_waiters there > as well and disable rps_boost when SLPC is enabled. > > Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632 > Signed-off-by: Vinay Belgaumkar