* [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer
@ 2023-02-14 9:34 Arun R Murthy
2023-02-14 9:34 ` [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Arun R Murthy @ 2023-02-14 9:34 UTC (permalink / raw)
To: intel-gfx, dri-devel, jani.nikula
*** BLURB HERE ***
Arun R Murthy (2):
drm: Add SDP Error Detection Configuration Register
i915/display/dp: SDP CRC16 for 128b132b link layer
.../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++
include/drm/display/drm_dp.h | 3 +++
2 files changed, 15 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register 2023-02-14 9:34 [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy @ 2023-02-14 9:34 ` Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Arun R Murthy @ 2023-02-14 9:34 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula; +Cc: Harry Wentland DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device. v2: Update the macro name to reflect the DP spec(Harry) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 632376c291db..358db4a9f167 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -692,6 +692,9 @@ # define DP_FEC_LANE_2_SELECT (2 << 4) # define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION_CONFIGURATION 0x121 /* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) + #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0) -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer 2023-02-14 9:34 [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy @ 2023-02-14 9:34 ` Arun R Murthy 2023-02-27 9:56 ` Jani Nikula 2023-02-14 11:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for DP2.0 SDP CRC16 for 128/132b link layer (rev2) Patchwork 2023-02-14 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 1 reply; 9+ messages in thread From: Arun R Murthy @ 2023-02-14 9:34 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write. Corrective actions on SDP corruption is yet to be defined. v2: Moved the CRC enable to link training init(Jani N) v3: Moved crc enable to ddi pre enable <Jani N> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 254559abedfb..fa995341614d 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -2330,6 +2330,18 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state, crtc_state->port_clock, crtc_state->lane_count); + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ + if (intel_dp_is_uhbr(crtc_state)) + drm_dp_dpcd_writeb(&intel_dp->aux, + DP_SDP_ERROR_DETECTION_CONFIGURATION, + DP_SDP_CRC16_128B132B_EN); + /* + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not + * disable SDP CRC. This is applicable for Display version 13. + * Default value of bit 31 is '0' hence discarding the write + */ + /* TODO: Corrective actions on SDP corruption yet to be defined */ + /* * We only configure what the register value will be here. Actual * enabling happens during link training farther down. -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer 2023-02-14 9:34 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy @ 2023-02-27 9:56 ` Jani Nikula 0 siblings, 0 replies; 9+ messages in thread From: Jani Nikula @ 2023-02-27 9:56 UTC (permalink / raw) To: Arun R Murthy, intel-gfx, dri-devel On Tue, 14 Feb 2023, Arun R Murthy <arun.r.murthy@intel.com> wrote: > Enable SDP error detection configuration, this will set CRC16 in > 128b/132b link layer. > For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is > added to enable/disable SDP CRC applicable for DP2.0 only, but the > default value of this bit will enable CRC16 in 128b/132b hence > skipping this write. > Corrective actions on SDP corruption is yet to be defined. > > v2: Moved the CRC enable to link training init(Jani N) > v3: Moved crc enable to ddi pre enable <Jani N> > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 254559abedfb..fa995341614d 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -2330,6 +2330,18 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state, > crtc_state->port_clock, > crtc_state->lane_count); > > + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ > + if (intel_dp_is_uhbr(crtc_state)) > + drm_dp_dpcd_writeb(&intel_dp->aux, > + DP_SDP_ERROR_DETECTION_CONFIGURATION, > + DP_SDP_CRC16_128B132B_EN); > + /* > + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not > + * disable SDP CRC. This is applicable for Display version 13. > + * Default value of bit 31 is '0' hence discarding the write > + */ > + /* TODO: Corrective actions on SDP corruption yet to be defined */ > + So yeah, I told you to do this in this function. But look at the surroundings, does it look like a direct drm_dp_dpcd_writeb() call fits here? tgl_ddi_pre_enable_dp() is a function that calls functions, and doesn't bother with any details. No register or DPCD reads or writes. Sure, it's a matter of style, and I hate to feel like I'm pushing you around with this. But the above really needs to be in a separate function when it's done in tgl_ddi_pre_enable_dp(). It'll also help with placing the comments. You can have *one* block comment above the function with all the details, TODO notes and everything, indented at the top level. (Above, the comments are indented as if they were within a {} block.) BR, Jani. > /* > * We only configure what the register value will be here. Actual > * enabling happens during link training farther down. -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for DP2.0 SDP CRC16 for 128/132b link layer (rev2) 2023-02-14 9:34 [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy @ 2023-02-14 11:19 ` Patchwork 2023-02-14 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2023-02-14 11:19 UTC (permalink / raw) To: Arun R Murthy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 7080 bytes --] == Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev2) URL : https://patchwork.freedesktop.org/series/113134/ State : success == Summary == CI Bug Log - changes from CI_DRM_12736 -> Patchwork_113134v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/index.html Participating hosts (38 -> 39) ------------------------------ Additional (2): fi-kbl-soraka fi-tgl-1115g4 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_113134v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([i915#7456]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html * igt@gem_huc_copy@huc-copy: - fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([i915#2190]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@parallel-random-engines: - fi-tgl-1115g4: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html * igt@i915_pm_backlight@basic-brightness: - fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#7561]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html * igt@i915_selftest@live@execlists: - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][7] ([i915#7156] / [i915#7913]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-kbl-soraka/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_suspend@basic-s3-without-i915: - fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][9] ([i915#7443]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_chamelium_edid@dp-edid-read: - fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#7828]) +7 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@kms_chamelium_edid@dp-edid-read.html * igt@kms_chamelium_frames@hdmi-crc-fast: - fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271]) +15 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - fi-tgl-1115g4: NOTRUN -> [SKIP][12] ([i915#4103]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([fdo#109285]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@cursor_plane_move: - fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([fdo#110189]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@kms_psr@cursor_plane_move.html * igt@kms_setmode@basic-clone-single-crtc: - fi-tgl-1115g4: NOTRUN -> [SKIP][15] ([i915#3555]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-userptr: - fi-tgl-1115g4: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3301]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - {bat-dg2-11}: [ABORT][17] ([i915#7913]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/bat-dg2-11/igt@i915_selftest@live@hangcheck.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/bat-dg2-11/igt@i915_selftest@live@hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156 [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977 [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996 Build changes ------------- * Linux: CI_DRM_12736 -> Patchwork_113134v2 CI-20190529: 20190529 CI_DRM_12736: a2aa96584caf1f5ad2047cae0689b26d12c51d2f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_113134v2: a2aa96584caf1f5ad2047cae0689b26d12c51d2f @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits a57fe3bb23d7 i915/display/dp: SDP CRC16 for 128b132b link layer cca18423c78e drm: Add SDP Error Detection Configuration Register == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/index.html [-- Attachment #2: Type: text/html, Size: 8109 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for DP2.0 SDP CRC16 for 128/132b link layer (rev2) 2023-02-14 9:34 [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy ` (2 preceding siblings ...) 2023-02-14 11:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for DP2.0 SDP CRC16 for 128/132b link layer (rev2) Patchwork @ 2023-02-14 15:49 ` Patchwork 3 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2023-02-14 15:49 UTC (permalink / raw) To: Arun R Murthy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 26325 bytes --] == Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev2) URL : https://patchwork.freedesktop.org/series/113134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12736_full -> Patchwork_113134v2_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_113134v2_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_113134v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/index.html Participating hosts (11 -> 10) ------------------------------ Missing (1): shard-rkl0 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_113134v2_full: ### IGT changes ### #### Possible regressions #### * igt@gem_eio@in-flight-suspend: - shard-apl: [PASS][1] -> [ABORT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl1/igt@gem_eio@in-flight-suspend.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl2/igt@gem_eio@in-flight-suspend.html Known issues ------------ Here are the changes found in Patchwork_113134v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-deadline: - shard-apl: NOTRUN -> [FAIL][3] ([i915#2846]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][4] -> [FAIL][5] ([i915#2842]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_lmem_swapping@smem-oom: - shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl1/igt@gem_lmem_swapping@smem-oom.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][9] -> [ABORT][10] ([i915#5566]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl6/igt@gen9_exec_parse@allowed-single.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl4/igt@gen9_exec_parse@allowed-single.html * igt@i915_selftest@live@gt_heartbeat: - shard-apl: [PASS][11] -> [DMESG-FAIL][12] ([i915#5334]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs: - shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +88 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +2 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html * igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#2122]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-glk8/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt: - shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html * igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1: - shard-apl: NOTRUN -> [FAIL][18] ([i915#4573]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl1/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1: - shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +27 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-snb2/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area: - shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#658]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html * igt@kms_setmode@basic@pipe-a-hdmi-a-1: - shard-snb: NOTRUN -> [FAIL][21] ([i915#5465]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html * igt@kms_writeback@writeback-invalid-parameters: - shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#2437]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@kms_writeback@writeback-invalid-parameters.html #### Possible fixes #### * igt@drm_fdinfo@virtual-idle: - {shard-rkl}: [FAIL][23] ([i915#7742]) -> [PASS][24] +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@drm_fdinfo@virtual-idle.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html * igt@feature_discovery@psr2: - {shard-rkl}: [SKIP][25] ([i915#658]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-3/igt@feature_discovery@psr2.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@engines-hang@bcs0: - {shard-rkl}: [SKIP][27] ([i915#6252]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-2/igt@gem_ctx_persistence@engines-hang@bcs0.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][29] ([i915#6259]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-1/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [FAIL][31] ([i915#2842]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - {shard-rkl}: [FAIL][33] ([i915#2842]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-3/igt@gem_exec_fair@basic-pace-share@rcs0.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_reloc@basic-gtt-cpu: - {shard-rkl}: [SKIP][35] ([i915#3281]) -> [PASS][36] +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-4/igt@gem_exec_reloc@basic-gtt-cpu.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-cpu.html * igt@gem_exec_suspend@basic-s3@smem: - {shard-rkl}: [ABORT][37] ([i915#5122]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-4/igt@gem_exec_suspend@basic-s3@smem.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-5/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_partial_pwrite_pread@writes-after-reads-uncached: - {shard-rkl}: [SKIP][39] ([i915#3282]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html * igt@gen9_exec_parse@bb-start-far: - {shard-rkl}: [SKIP][41] ([i915#2527]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@gen9_exec_parse@bb-start-far.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-5/igt@gen9_exec_parse@bb-start-far.html * igt@i915_pm_dc@dc5-dpms: - {shard-rkl}: [FAIL][43] ([i915#7330]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-1/igt@i915_pm_dc@dc5-dpms.html * igt@i915_pm_rc6_residency@rc6-idle@bcs0: - {shard-dg1}: [FAIL][45] ([i915#3591]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-dg1-12/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html * igt@i915_pm_rpm@dpms-lpsp: - {shard-rkl}: [SKIP][47] ([i915#1397]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html * igt@kms_big_fb@linear-32bpp-rotate-0: - {shard-rkl}: [SKIP][49] ([i915#1845] / [i915#4098]) -> [PASS][50] +10 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@kms_big_fb@linear-32bpp-rotate-0.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@kms_big_fb@linear-32bpp-rotate-0.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1: - shard-apl: [ABORT][51] -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [FAIL][53] ([i915#72]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions: - shard-glk: [FAIL][55] ([i915#2346]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-apl: [FAIL][57] ([i915#2346]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1: - shard-apl: [FAIL][59] ([i915#79]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@b-dp1: - shard-apl: [ABORT][61] ([i915#180]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-apl2/igt@kms_flip@flip-vs-suspend@b-dp1.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-apl1/igt@kms_flip@flip-vs-suspend@b-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][63] ([i915#1849] / [i915#4098]) -> [PASS][64] +9 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_plane@plane-position-hole@pipe-b-planes: - {shard-rkl}: [SKIP][65] ([i915#1849]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-3/igt@kms_plane@plane-position-hole@pipe-b-planes.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@kms_plane@plane-position-hole@pipe-b-planes.html * igt@kms_psr@no_drrs: - {shard-rkl}: [SKIP][67] ([i915#1072]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-3/igt@kms_psr@no_drrs.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-6/igt@kms_psr@no_drrs.html * igt@perf@mi-rpc: - {shard-rkl}: [SKIP][69] ([i915#2434]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-rkl-1/igt@perf@mi-rpc.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-rkl-5/igt@perf@mi-rpc.html #### Warnings #### * igt@i915_pm_rpm@pm-tiling: - shard-snb: [SKIP][71] ([fdo#109271]) -> [INCOMPLETE][72] ([i915#2295]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12736/shard-snb4/igt@i915_pm_rpm@pm-tiling.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/shard-snb6/igt@i915_pm_rpm@pm-tiling.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884 [i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294 [i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330 [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949 [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957 [i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150 [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152 Build changes ------------- * Linux: CI_DRM_12736 -> Patchwork_113134v2 CI-20190529: 20190529 CI_DRM_12736: a2aa96584caf1f5ad2047cae0689b26d12c51d2f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_113134v2: a2aa96584caf1f5ad2047cae0689b26d12c51d2f @ git://anongit.freedesktop.org/gfx-ci/linux == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v2/index.html [-- Attachment #2: Type: text/html, Size: 20546 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCHv2 0/2] DP2.0 SDP CRC16 for 128/132b link layer @ 2023-01-20 6:15 Arun R Murthy 2023-01-20 6:16 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b " Arun R Murthy 0 siblings, 1 reply; 9+ messages in thread From: Arun R Murthy @ 2023-01-20 6:15 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula *** BLURB HERE *** Arun R Murthy (2): drm: Add SDP Error Detection Configuration Register i915/display/dp: SDP CRC16 for 128b132b link layer .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ include/drm/display/drm_dp.h | 3 +++ 2 files changed, 15 insertions(+) -- 2.25.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer 2023-01-20 6:15 [Intel-gfx] [PATCHv2 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy @ 2023-01-20 6:16 ` Arun R Murthy 2023-01-26 15:00 ` Jani Nikula 0 siblings, 1 reply; 9+ messages in thread From: Arun R Murthy @ 2023-01-20 6:16 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write. Corrective actions on SDP corruption is yet to be defined. v2: Moved the CRC enable to link training init(Jani N) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c index 3d3efcf02011..7064e465423b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp, if (!passed) intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); + + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ + if (intel_dp_is_uhbr(crtc_state) && passed) + drm_dp_dpcd_writeb(&intel_dp->aux, + DP_SDP_ERROR_DETECTION_CONFIGURATION, + DP_SDP_CRC16_128B132B_EN); + /* + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not + * disable SDP CRC. This is applicable for Display version 13. + * Default value of bit 31 is '0' hence discarding the write + */ + /* TODO: Corrective actions on SDP corruption yet to be defined */ } -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer 2023-01-20 6:16 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b " Arun R Murthy @ 2023-01-26 15:00 ` Jani Nikula 0 siblings, 0 replies; 9+ messages in thread From: Jani Nikula @ 2023-01-26 15:00 UTC (permalink / raw) To: Arun R Murthy, intel-gfx, dri-devel On Fri, 20 Jan 2023, Arun R Murthy <arun.r.murthy@intel.com> wrote: > Enable SDP error detection configuration, this will set CRC16 in > 128b/132b link layer. > For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is > added to enable/disable SDP CRC applicable for DP2.0 only, but the > default value of this bit will enable CRC16 in 128b/132b hence > skipping this write. > Corrective actions on SDP corruption is yet to be defined. > > v2: Moved the CRC enable to link training init(Jani N) Yeah, well, I said where this doesn't belong, and I don't think it really belongs here either. :( It has nothing to do with link training or intel_dp_start_link_train(). Alas, I'm not really sure what the right place is, I just know this isn't it. The specs don't give us any clues. The DP specs says absolutely nothing about when this could or should be written. *Maybe* in intel_ddi_pre_enable() or intel_mst_pre_enable_dp()? Before sending any SDPs. BR, Jani. > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index 3d3efcf02011..7064e465423b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp, > > if (!passed) > intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); > + > + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ > + if (intel_dp_is_uhbr(crtc_state) && passed) > + drm_dp_dpcd_writeb(&intel_dp->aux, > + DP_SDP_ERROR_DETECTION_CONFIGURATION, > + DP_SDP_CRC16_128B132B_EN); > + /* > + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not > + * disable SDP CRC. This is applicable for Display version 13. > + * Default value of bit 31 is '0' hence discarding the write > + */ > + /* TODO: Corrective actions on SDP corruption yet to be defined */ > } -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm: Add SDP Error Detection Configuration Register @ 2023-01-13 4:36 Arun R Murthy 2023-01-20 5:59 ` [Intel-gfx] [PATCHv2 " Arun R Murthy 0 siblings, 1 reply; 9+ messages in thread From: Arun R Murthy @ 2023-01-13 4:36 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device. Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 9bc22a02874d..8bf6f0a60c38 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -691,6 +691,9 @@ # define DP_FEC_LANE_2_SELECT (2 << 4) # define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION 0x121 /* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) + #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0) -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register 2023-01-13 4:36 [Intel-gfx] [PATCH 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy @ 2023-01-20 5:59 ` Arun R Murthy 2023-01-20 5:59 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy 0 siblings, 1 reply; 9+ messages in thread From: Arun R Murthy @ 2023-01-20 5:59 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula; +Cc: Harry Wentland DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device. v2: Update the macro name to reflect the DP spec(Harry) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 632376c291db..358db4a9f167 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -692,6 +692,9 @@ # define DP_FEC_LANE_2_SELECT (2 << 4) # define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION_CONFIGURATION 0x121 /* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) + #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0) -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer 2023-01-20 5:59 ` [Intel-gfx] [PATCHv2 " Arun R Murthy @ 2023-01-20 5:59 ` Arun R Murthy 0 siblings, 0 replies; 9+ messages in thread From: Arun R Murthy @ 2023-01-20 5:59 UTC (permalink / raw) To: intel-gfx, dri-devel, jani.nikula Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write. Corrective actions on SDP corruption is yet to be defined. v2: Moved the CRC enable to link training init(Jani N) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c index 3d3efcf02011..7064e465423b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp, if (!passed) intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); + + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ + if (intel_dp_is_uhbr(crtc_state) && passed) + drm_dp_dpcd_writeb(&intel_dp->aux, + DP_SDP_ERROR_DETECTION_CONFIGURATION, + DP_SDP_CRC16_128B132B_EN); + /* + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not + * disable SDP CRC. This is applicable for Display version 13. + * Default value of bit 31 is '0' hence discarding the write + */ + /* TODO: Corrective actions on SDP corruption yet to be defined */ } -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-27 9:56 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-14 9:34 [Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy 2023-02-14 9:34 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy 2023-02-27 9:56 ` Jani Nikula 2023-02-14 11:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for DP2.0 SDP CRC16 for 128/132b link layer (rev2) Patchwork 2023-02-14 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2023-01-20 6:15 [Intel-gfx] [PATCHv2 0/2] DP2.0 SDP CRC16 for 128/132b link layer Arun R Murthy 2023-01-20 6:16 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b " Arun R Murthy 2023-01-26 15:00 ` Jani Nikula 2023-01-13 4:36 [Intel-gfx] [PATCH 1/2] drm: Add SDP Error Detection Configuration Register Arun R Murthy 2023-01-20 5:59 ` [Intel-gfx] [PATCHv2 " Arun R Murthy 2023-01-20 5:59 ` [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Arun R Murthy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).