From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: Lionel G Landwerlin <lionel.g.landwerlin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups
Date: Thu, 16 Feb 2023 20:10:29 +0200 [thread overview]
Message-ID: <87fsb5zdka.fsf@intel.com> (raw)
In-Reply-To: <87r0upmr4i.wl-ashutosh.dixit@intel.com>
On Thu, 16 Feb 2023, "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote:
> On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote:
>>
>> > +static int oa_init_gt(struct intel_gt *gt)
>> > +{
>> > + u32 num_groups = __num_perf_groups_per_gt(gt);
>> > + struct intel_engine_cs *engine;
>> > + struct i915_perf_group *g;
>> > + intel_engine_mask_t tmp;
>> > +
>> > + g = kcalloc(num_groups, sizeof(*g), GFP_KERNEL);
>> > + if (drm_WARN_ON(>->i915->drm, !g))
>> > + return -ENOMEM;
>>
>> No warnings or messages on -ENOMEM is standard policy.
>
> Hmm I think this is the only error for which this code is failing the
> probe. So if we are not going to fail the probe, we should at least allow a
> WARN_ON? Exception proves the rule?
A whole lot of other things are going to go bonkers on -ENOMEM, and
getting that warn isn't going to help anyone...
Maybe we do need to fail probe on this after all, but it just seemed
pointless at the time it was introduced a few patches earlier.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-02-16 18:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 0:54 [Intel-gfx] [PATCH 0/9] Add OAM support for MTL Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 1/9] drm/i915/perf: Drop wakeref on GuC RC error Umesh Nerlige Ramappa
2023-02-16 3:56 ` Dixit, Ashutosh
2023-02-15 0:54 ` [Intel-gfx] [PATCH 2/9] drm/i915/perf: Add helper to check supported OA engines Umesh Nerlige Ramappa
2023-02-16 3:58 ` Dixit, Ashutosh
2023-02-16 17:30 ` Umesh Nerlige Ramappa
2023-02-17 0:53 ` Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch Umesh Nerlige Ramappa
2023-02-16 5:08 ` Dixit, Ashutosh
2023-02-16 5:36 ` Dixit, Ashutosh
2023-02-16 16:31 ` Dixit, Ashutosh
2023-02-16 17:37 ` Umesh Nerlige Ramappa
2023-02-16 23:11 ` Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 4/9] drm/i915/perf: Fail modprobe if i915_perf_init fails Umesh Nerlige Ramappa
2023-02-16 6:10 ` Dixit, Ashutosh
2023-02-16 10:43 ` Jani Nikula
2023-02-15 0:54 ` [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups Umesh Nerlige Ramappa
2023-02-16 10:51 ` Jani Nikula
2023-02-16 17:55 ` Dixit, Ashutosh
2023-02-16 18:10 ` Jani Nikula [this message]
2023-02-16 20:55 ` Umesh Nerlige Ramappa
2023-02-16 23:58 ` Umesh Nerlige Ramappa
2023-02-16 23:44 ` Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 6/9] drm/i915/perf: Parse 64bit report header formats correctly Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 7/9] drm/i915/perf: Handle non-power-of-2 reports Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 8/9] drm/i915/perf: Add engine class instance parameters to perf Umesh Nerlige Ramappa
2023-02-15 0:54 ` [Intel-gfx] [PATCH 9/9] drm/i915/perf: Add support for OA media units Umesh Nerlige Ramappa
2023-02-16 17:27 ` Dixit, Ashutosh
2023-02-16 21:07 ` Umesh Nerlige Ramappa
2023-02-16 21:23 ` Dixit, Ashutosh
2023-02-15 1:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add OAM support for MTL Patchwork
2023-02-15 2:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsb5zdka.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox