From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B0FECAAD1 for ; Tue, 30 Aug 2022 15:32:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B86410E121; Tue, 30 Aug 2022 15:32:53 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 600E310E121 for ; Tue, 30 Aug 2022 15:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661873571; x=1693409571; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jPV+PSAWv1lBhuMrtvMCGjJHIBRumybCLfCf07bV9Cg=; b=ftiZlT+1tUqSsf3eDNuif9Mw+aRz08w/yqxy4JGramEU21mcdcZVdaYW fKBc5bfPfk1rteeNw5JgsSycqFWHJa7MTPMRUY7ki69tJVV7heRROK/26 0vruT930gX/2nebTOFH4fPLXqCV2KZrF6t+OlhJ4W/4GP9kAUF7wJRWZg 1j+1tp6AZVXHrwaqoiGpVGJ7S+yGFZrk/CdH7tvt8ZA6nDWe6EWhzmovC qH1UzRtU7KVSyLu1iFHkGiZIog8c4kLi7AmpoOZVcQw6EOQHKnbfwkRuE vM9WaeN/syjdQ3t2hwyywO7PtI1APYnjrx50e+2f3UW1F0sRv4auF8PvZ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="292784038" X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="292784038" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 08:32:31 -0700 X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="715339349" Received: from deepashu-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.252.128.174]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 08:32:31 -0700 Date: Tue, 30 Aug 2022 08:30:11 -0700 Message-ID: <87fshdzr3w.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: <20220830150229.165214-1-rodrigo.vivi@intel.com> References: <20220830150229.165214-1-rodrigo.vivi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Dan Carpenter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 30 Aug 2022 08:02:29 -0700, Rodrigo Vivi wrote: > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > index 9d49ccef03bb..f8a2bbcdf14f 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > @@ -477,7 +477,7 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc *slpc, u32 val) > if (unlikely(ret)) { > i915_probe_error(i915, "Failed to toggle efficient freq (%pe)\n", > ERR_PTR(ret)); > - return ret; > + goto unlock; I think leaking runtime_pm wakeref now... > } > > ret = slpc_set_param(slpc, > @@ -492,6 +492,7 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc *slpc, u32 val) > if (!ret) > slpc->min_freq_softlimit = val; > > +unlock: > mutex_unlock(&slpc->lock); > > return ret; > -- > 2.37.2 >