From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 00/12] drm/edid: low level EDID block read refactoring etc.
Date: Mon, 11 Apr 2022 12:51:54 +0300 [thread overview]
Message-ID: <87fsmkhrr9.fsf@intel.com> (raw)
In-Reply-To: <Yk7csG+mdZ9LwA4+@intel.com>
On Thu, 07 Apr 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Apr 07, 2022 at 12:14:26PM +0300, Jani Nikula wrote:
>> Ever so slowly moving towards cleaner EDID reading.
>>
>> Jani Nikula (12):
>> drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks
>> drm/edid: have edid_block_check() detect blocks that are all zero
>> drm/edid: refactor EDID block status printing
>> drm/edid: add a helper to log dump an EDID block
>> drm/edid: pass struct edid to connector_bad_edid()
>> drm/edid: add typedef for block read function
>> drm/edid: abstract an EDID block read helper
>> drm/edid: use EDID block read helper in drm_do_get_edid()
>> drm/edid: convert extension block read to EDID block read helper
>> drm/edid: drop extra local var
>> drm/edid: add single point of return to drm_do_get_edid()
>> drm/edid: add EDID block count and size helpers
>
> Some of the stuff was a bit hard to follow, but I suppose that's mostly
> an indication of the messy state of the current code. Didn't spot
> anything obviously wrong at least.
I'm painfully aware. I'm just hoping the end result has more clarity. At
least highlights the warts in the logic that I tried to preserve...
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Again, thanks a bunch!
BR,
Jani.
>
>>
>> drivers/gpu/drm/drm_edid.c | 350 ++++++++++++++++++++++++-------------
>> 1 file changed, 225 insertions(+), 125 deletions(-)
>>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-04-11 9:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:14 [Intel-gfx] [PATCH 00/12] drm/edid: low level EDID block read refactoring etc Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 01/12] drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 02/12] drm/edid: have edid_block_check() detect blocks that are all zero Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 03/12] drm/edid: refactor EDID block status printing Jani Nikula
2022-04-07 11:54 ` Ville Syrjälä
2022-04-11 9:49 ` Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 04/12] drm/edid: add a helper to log dump an EDID block Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 05/12] drm/edid: pass struct edid to connector_bad_edid() Jani Nikula
2022-04-07 11:56 ` Ville Syrjälä
2022-04-07 9:14 ` [Intel-gfx] [PATCH 06/12] drm/edid: add typedef for block read function Jani Nikula
2022-04-07 12:06 ` Ville Syrjälä
2022-04-11 9:48 ` Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 07/12] drm/edid: abstract an EDID block read helper Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 08/12] drm/edid: use EDID block read helper in drm_do_get_edid() Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 09/12] drm/edid: convert extension block read to EDID block read helper Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 10/12] drm/edid: drop extra local var Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 11/12] drm/edid: add single point of return to drm_do_get_edid() Jani Nikula
2022-04-07 9:14 ` [Intel-gfx] [PATCH 12/12] drm/edid: add EDID block count and size helpers Jani Nikula
2022-04-07 15:07 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2022-04-07 12:24 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/edid: low level EDID block read refactoring etc Patchwork
2022-04-07 12:41 ` Jani Nikula
2022-04-07 12:44 ` [Intel-gfx] [PATCH 00/12] " Ville Syrjälä
2022-04-11 9:51 ` Jani Nikula [this message]
2022-04-07 17:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: low level EDID block read refactoring etc. (rev2) Patchwork
2022-04-07 23:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: low level EDID block read refactoring etc. (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsmkhrr9.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox