From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E530EC433EF for ; Mon, 13 Dec 2021 18:44:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35C2910E893; Mon, 13 Dec 2021 18:44:24 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E74610E893; Mon, 13 Dec 2021 18:44:23 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="238615470" X-IronPort-AV: E=Sophos;i="5.88,203,1635231600"; d="scan'208";a="238615470" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 10:44:22 -0800 X-IronPort-AV: E=Sophos;i="5.88,203,1635231600"; d="scan'208";a="505017490" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 10:44:18 -0800 From: Jani Nikula To: broonie@kernel.org, Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter In-Reply-To: <20211213170753.3680209-1-broonie@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213170753.3680209-1-broonie@kernel.org> Date: Mon, 13 Dec 2021 20:44:14 +0200 Message-ID: <87fsqw73b5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix implicit use of struct pci_dev X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Mark Brown , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 13 Dec 2021, broonie@kernel.org wrote: > From: Mark Brown > > intel_device_info.h references struct pci_dev but does not ensure that > the struct has been declared, causing build failures if something in > other headers changes so that the implicit dependency it is relying on > is no longer satisfied: > > In file included from /tmp/next/build/drivers/gpu/drm/i915/intel_device_info.h:32, > from /tmp/next/build/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h:11, > from /tmp/next/build/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:11: > /tmp/next/build/drivers/gpu/drm/i915/display/intel_display.h:643:39: error: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > 643 | bool intel_modeset_probe_defer(struct pci_dev *pdev); > | ^~~~~~~ > cc1: all warnings being treated as errors > > Add a declaration of the struct to fix this. > > Signed-off-by: Mark Brown Thanks, Fixes: 94b541f53db1 ("drm/i915: Add intel_modeset_probe_defer() helper") Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h > index 4b688a9727b39..377790393a855 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.h > +++ b/drivers/gpu/drm/i915/display/intel_display.h > @@ -57,6 +57,7 @@ struct intel_plane; > struct intel_plane_state; > struct intel_remapped_info; > struct intel_rotation_info; > +struct pci_dev; > > enum i915_gpio { > GPIOA, -- Jani Nikula, Intel Open Source Graphics Center