From: Jani Nikula <jani.nikula@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Alan Previn <alan.previn.teres.alexis@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC 2/7] drm/i915/guc: Update GuC ADS size for error capture lists
Date: Wed, 24 Nov 2021 11:52:41 +0200 [thread overview]
Message-ID: <87fsrlnamu.fsf@intel.com> (raw)
In-Reply-To: <3d153da0-8bef-1a6b-d292-34b1f54ac938@intel.com>
On Tue, 23 Nov 2021, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> Hi,
>
> just few random nits below
>
> -Michal
>
>
> On 23.11.2021 00:03, Alan Previn wrote:
>> +/* Define all device tables of GuC error capture register lists */
>> +
>> +/********************************* Gen12 LP *********************************/
>
> didn't we move away from "GEN" naming ?
Yes.
>
>> +/************** GLOBAL *************/
>
> do we really need all these decorations ?
No, please remove them.
>
>> +struct __guc_mmio_reg_descr gen12lp_global_regs[] = {
>> + {SWF_ILK(0), 0, 0, "SWF_ILK0"},
>> + /* Add additional register list */
>
> do we need this reminder ?
No, please remove them.
Also, all of these need to be static.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-11-24 9:52 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 23:03 [Intel-gfx] [RFC 0/7] Add GuC Error Capture Support Alan Previn
2021-11-22 23:03 ` [Intel-gfx] [RFC 1/7] drm/i915/guc: Add basic support for error capture lists Alan Previn
2021-11-23 21:12 ` Michal Wajdeczko
2021-12-08 18:23 ` Teres Alexis, Alan Previn
2021-11-22 23:03 ` [Intel-gfx] [RFC 2/7] drm/i915/guc: Update GuC ADS size " Alan Previn
2021-11-23 21:46 ` Michal Wajdeczko
2021-11-24 9:52 ` Jani Nikula [this message]
2021-11-24 17:34 ` Teres Alexis, Alan Previn
2021-12-21 23:15 ` Teres Alexis, Alan Previn
2021-12-22 1:49 ` Teres Alexis, Alan Previn
2021-12-22 20:13 ` Teres Alexis, Alan Previn
2021-11-24 10:06 ` Jani Nikula
2021-11-24 17:37 ` Teres Alexis, Alan Previn
2021-11-22 23:03 ` [Intel-gfx] [RFC 3/7] drm/i915/guc: Populate XE_LP register lists for GuC error state capture Alan Previn
2021-11-23 21:55 ` Michal Wajdeczko
2021-11-24 17:16 ` Teres Alexis, Alan Previn
2021-11-22 23:03 ` [Intel-gfx] [RFC 4/7] drm/i915/guc: Add GuC's error state capture output structures Alan Previn
2021-11-24 10:08 ` Jani Nikula
2021-11-24 17:37 ` Teres Alexis, Alan Previn
2021-12-07 21:01 ` Matthew Brost
2021-12-07 23:35 ` Teres Alexis, Alan Previn
2021-11-22 23:04 ` [Intel-gfx] [RFC 5/7] drm/i915/guc: Update GuC's log-buffer-state access for error capture Alan Previn
2021-12-07 22:31 ` Matthew Brost
2021-12-07 23:33 ` Teres Alexis, Alan Previn
2021-12-07 23:30 ` Matthew Brost
2021-11-22 23:04 ` [Intel-gfx] [RFC 6/7] drm/i915/guc: Copy new GuC error capture logs upon G2H notification Alan Previn
2021-12-07 22:58 ` Matthew Brost
2021-12-08 5:14 ` Teres Alexis, Alan Previn
2021-12-08 18:22 ` Teres Alexis, Alan Previn
2021-11-22 23:04 ` [Intel-gfx] [RFC 7/7] drm/i915/guc: Print the GuC error capture output register list Alan Previn
2021-11-23 0:25 ` Teres Alexis, Alan Previn
2021-12-08 0:22 ` Matthew Brost
2021-12-08 6:31 ` Teres Alexis, Alan Previn
2021-12-23 18:54 ` Teres Alexis, Alan Previn
2021-12-24 12:09 ` Tvrtko Ursulin
2021-12-24 13:34 ` Teres Alexis, Alan Previn
2022-01-04 13:56 ` Tvrtko Ursulin
2022-01-05 17:30 ` Teres Alexis, Alan Previn
2022-01-06 9:38 ` Tvrtko Ursulin
2022-01-06 18:33 ` Teres Alexis, Alan Previn
2022-01-07 9:03 ` Tvrtko Ursulin
2022-01-07 17:03 ` Teres Alexis, Alan Previn
2022-01-10 8:07 ` Tvrtko Ursulin
2022-01-10 18:19 ` Teres Alexis, Alan Previn
2022-01-11 10:08 ` Tvrtko Ursulin
2022-01-14 7:16 ` Teres Alexis, Alan Previn
2021-11-22 23:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GuC Error Capture Support Patchwork
2021-11-22 23:45 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-23 0:16 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-11-23 0:40 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add GuC Error Capture Support (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsrlnamu.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox