From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0916C433EF for ; Tue, 2 Nov 2021 01:45:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57B6A60EDF for ; Tue, 2 Nov 2021 01:45:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 57B6A60EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F47D6F621; Tue, 2 Nov 2021 01:45:15 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E34EB6F621; Tue, 2 Nov 2021 01:45:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="231119184" X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="231119184" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 18:45:14 -0700 X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="488887581" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.137.218]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 18:45:13 -0700 Date: Mon, 01 Nov 2021 18:35:55 -0700 Message-ID: <87fssf2vb8.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20211102012608.8609-1-vinay.belgaumkar@intel.com> References: <20211102012608.8609-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v3 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 01 Nov 2021 18:26:05 -0700, Vinay Belgaumkar wrote: > > Waitboost is a legacy feature implemented in the Host Turbo algorithm. This > patch set implements it for the SLPC path. A boost can happen when a request > is waiting for an unmet dependency. GT frequency gets temporarily bumped to > boost freq to allow the previous request to finish quickly. We achieve this > on SLPC by setting the min frequency, SLPC will set that as the requested > frequency. > > The boost will occur through a worker thread that will be scheduled > when the required conditions are met. > > Like before, boost frequency is configurable through sysfs, so we can > adjust it to any specific value as long as it is between [min, RP0]. > > v2: Add a worker thread to perform freq boost. > v3: Address comments (Ashutosh) For the series: Reviewed-by: Ashutosh Dixit > Cc: Ashutosh Dixit > Signed-off-by: Vinay Belgaumkar > > Vinay Belgaumkar (3): > drm/i915/guc/slpc: Define and initialize boost frequency > drm/i915/guc/slpc: Add waitboost functionality for SLPC > drm/i915/guc/slpc: Update boost sysfs hooks for SLPC > > drivers/gpu/drm/i915/gt/intel_rps.c | 72 +++++++++ > drivers/gpu/drm/i915/gt/intel_rps.h | 3 + > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 151 +++++++++++++++--- > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 3 + > .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 13 ++ > drivers/gpu/drm/i915/i915_request.c | 2 +- > drivers/gpu/drm/i915/i915_sysfs.c | 19 +-- > 7 files changed, 223 insertions(+), 40 deletions(-) > > -- > 2.25.0 >