From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4CDC33CB1 for ; Fri, 17 Jan 2020 15:15:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C91B12064C for ; Fri, 17 Jan 2020 15:15:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C91B12064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A4D86F5DD; Fri, 17 Jan 2020 15:15:43 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC7E06F5DD; Fri, 17 Jan 2020 15:15:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 07:15:42 -0800 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="218934603" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 07:15:39 -0800 From: Jani Nikula To: Chris Wilson , Zhenyu Wang In-Reply-To: <157164501001.24426.17278525357815707355@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191016183902.13614-1-chris@chris-wilson.co.uk> <20191016183902.13614-2-chris@chris-wilson.co.uk> <20191021053724.GB8745@zhen-hp.sh.intel.com> <157164501001.24426.17278525357815707355@skylake-alporthouse-com> Date: Fri, 17 Jan 2020 17:15:36 +0200 Message-ID: <87ftgegllz.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Wean gvt off dev_priv->engine[] X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 21 Oct 2019, Chris Wilson wrote: > Quoting Zhenyu Wang (2019-10-21 06:37:24) >> On 2019.10.16 19:39:02 +0100, Chris Wilson wrote: >> > Stop trying to escape out of the gvt layer to find the engine that we >> > initially setup for use with gvt. Record the engines during initialisation >> > and use them henceforth. >> > >> > add/remove: 1/4 grow/shrink: 22/28 up/down: 341/-1410 (-1069) >> > >> > Signed-off-by: Chris Wilson >> > --- >> >> Thanks for this cleanup! Quick review seems good to me, although it >> looks pretty fine for me on ring_id replacement, this big one also >> includes other changes like indent fix, debugfs item change, etc. >> Could we split them for easier merge? Can have a gvt developer to >> help on that. > > Just make gvt/ checkpatch clean so that CI doesn't reject patches > because the surrounding code does not conform to coding style. Sadly this has fallen between the cracks. Could someone pick this up again please, maybe from the gvt team? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx