intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/oa: add content to Makefile
Date: Thu, 01 Aug 2019 15:24:17 +0300	[thread overview]
Message-ID: <87ftmlm5u6.fsf@intel.com> (raw)
In-Reply-To: <op.z5qt3mzhxaggs7@mwajdecz-mobl1.ger.corp.intel.com>

On Tue, 30 Jul 2019, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On Tue, 30 Jul 2019 13:34:30 +0200, Jani Nikula <jani.nikula@intel.com>  
> wrote:
>
>> Apparently the empty Makefile has caused some confusion. Add the
>> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
>> to subdir Makefiles") which should be useful.
>>
>> The generated headers still aren't self-contained, so can't add that.
>>
>> References:  
>> http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Thanks, pushed the one patch to dinq. May I trouble you for review on
patches 2 and 3 as well please?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-01 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 11:34 [PATCH 1/3] drm/i915/oa: add content to Makefile Jani Nikula
2019-07-30 11:34 ` [PATCH 2/3] drm/i915: add SPDX headers to subdir Makefiles Jani Nikula
2019-08-01 12:24   ` Chris Wilson
2019-07-30 11:34 ` [PATCH 3/3] drm/i915/oa: update the generated files Jani Nikula
2019-08-01 12:26   ` Chris Wilson
2019-08-02 12:11     ` Jani Nikula
2019-07-30 13:04 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/oa: add content to Makefile Patchwork
2019-07-30 13:24 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-30 13:51 ` [PATCH 1/3] " Michal Wajdeczko
2019-08-01 12:24   ` Jani Nikula [this message]
2019-07-30 23:39 ` ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftmlm5u6.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).