Re: [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full

From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full
Date: Fri, 27 Oct 2017 11:03:20 +0300	[thread overview]
Message-ID: <87fua5f25z.fsf@intel.com> (raw)
In-Reply-To: <150905046471.2864.5878970656124081681@mail.alporthouse.com>

On Thu, 26 Oct 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2017-10-26 15:36:34)
>> On Tue, 24 Oct 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression
>> > that had been lurking for 6 months, so lets try enabling the full set of
>> > warnings for CI builds. This means more patches will be rejected early
>> > that contain trivial and sometimes not so trivial bugs. However, our
>> > code does not yet compile cleanly with W=1, so we have to apply a filter
>> > to the set of warnings until we can eliminate the mistakes. It also
>> > means that developers will have to be running the full gamut of gcc to
>> > ensure that as warnings come and go with gcc updates, we have the CI
>> > build prepared.
>> >
>> > v2: Use fine-grained -Wno overrides. Inside the makefile, we can
>> > specify CFLAGS on a per-object level, which allows us to limit the scope
>> > of any particular warning override.
>> > v3: Place per-file overrides after the main enabling block.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> > Cc: Jani Nikula <jani.nikula@intel.com>
>> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
>> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > Acked-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
>> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> > ---
>> > Seeking more acks for making our lives harder by giving gcc free reign
>> > in its warnings.
>> 
>> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> So be it. I hope I don't regret letting gcc rule over us!

I figured we have git revert for regrets. ;)

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx