From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Michal Wajdeczko" <michal.wajdeczko@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i915: Rename global i915 to i915_params
Date: Wed, 13 Sep 2017 12:04:28 +0300 [thread overview]
Message-ID: <87fubrj7fn.fsf@nikula.org> (raw)
In-Reply-To: <150523100247.29947.586907039081201872@mail.alporthouse.com>
On Tue, 12 Sep 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Ville Syrjälä (2017-09-12 16:36:57)
>> > -module_param_named(modeset, i915.modeset, int, 0400);
>> > +module_param_named(modeset, i915_params.modeset, int, 0400);
>
> We could clear the bulk of this patch
>
> #define i915_param_named(name, T, perm) module_param_named(name, i915.##name, T, perm)
> #define i915_param_named_unsafe(name, T, perm) module_param_named_unsafe(name, i915.##name, T, perm)
>
> as step 1.
That's not unreasonable, as it's all stowed away in one file. Perhaps
throw in MODULE_PARM_DESC to the same macro?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:28 [RFC] drm/i915: Rename global i915 to i915_params Michal Wajdeczko
2017-09-12 15:36 ` Ville Syrjälä
2017-09-12 15:43 ` Chris Wilson
2017-09-13 9:04 ` Jani Nikula [this message]
2017-09-13 8:59 ` Jani Nikula
2017-09-12 15:43 ` Tvrtko Ursulin
2017-09-12 15:58 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-12 20:23 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fubrj7fn.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox