From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira
<ander.conselvan.de.oliveira@intel.com>,
Arun Siluvery <arun.siluvery@intel.com>
Subject: Re: [PATCH v2] drm/i915/glk: Enable pooled EUs for Geminilake
Date: Fri, 17 Mar 2017 17:19:09 +0200 [thread overview]
Message-ID: <87fuicylqq.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170317140436.24645-1-ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
writes:
> Geminilake also supports pooled EUs. Enable it.
>
> It is unclear if the recommendation to disable it for 2x6 configurations
> from commit e015dd69b2cf ("drm/i915/bxt: Add WaEnablePooledEuFor2x6")
> should also apply to GLK, but it is applied anyway to be on the safe
> side. That restriction can be lifted later if determined not to impact
> performance.
>
> The extra restriction should not impact user space either. The only user
> space that uses this feature is Beignet, and it only does so for 3x6
> devices. See See Beignet's commit 6901899ec90a ("Runtime: set the sub
> slice according to kernel pooled EU configure.").
>
> v2: Improve commit message. (Mika, Roy)
>
> Cc: Arun Siluvery <arun.siluvery@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Yang Rong <rong.r.yang@intel.com>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Pushed, thanks for patch and review.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-17 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 13:12 [PATCH] drm/915/glk: Enable pooled EUs for Geminilake Ander Conselvan de Oliveira
2017-02-24 13:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-28 6:25 ` [PATCH] " Yang, Rong R
2017-03-03 13:10 ` Ander Conselvan De Oliveira
2017-03-17 10:18 ` Mika Kuoppala
2017-03-17 14:04 ` [PATCH v2] drm/i915/glk: " Ander Conselvan de Oliveira
2017-03-17 14:53 ` Mika Kuoppala
2017-03-17 15:19 ` Mika Kuoppala [this message]
2017-03-17 14:36 ` ✓ Fi.CI.BAT: success for drm/915/glk: Enable pooled EUs for Geminilake (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuicylqq.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=arun.siluvery@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox