Re: [PATCH v2 2/8] drm/i915/dp: Remove debug dependency of DPCD SW/HW revision read

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 24 Oct 2016, Imre Deak <imre.deak@intel.com> wrote:
> Performing DPCD AUX reads based on debug settings may introduce obscure
> bugs in other places that depend on the read being done (or being not
> done). To reduce the uncertainty perform the reads unconditionally.
>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 3c2293b..1c1a8c8 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1456,9 +1456,6 @@ static void intel_dp_print_hw_revision(struct intel_dp *intel_dp)
>  	uint8_t rev;
>  	int len;
>  
> -	if ((drm_debug & DRM_UT_KMS) == 0)
> -		return;
> -
>  	if (!drm_dp_is_branch(intel_dp->dpcd))
>  		return;
>  
> @@ -1474,9 +1471,6 @@ static void intel_dp_print_sw_revision(struct intel_dp *intel_dp)
>  	uint8_t rev[2];
>  	int len;
>  
> -	if ((drm_debug & DRM_UT_KMS) == 0)
> -		return;
> -
>  	if (!drm_dp_is_branch(intel_dp->dpcd))
>  		return;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx